From: Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [bug report] drm/ttm: Fix dummy res NULL ptr deref bug
Date: Thu, 11 Aug 2022 16:36:33 +0530 [thread overview]
Message-ID: <28f5d71e-34ca-214a-f8a8-14e227bb42cf@amd.com> (raw)
In-Reply-To: <YvTSD44z0csJ8YsP@kili>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
Hi Dan,
drm-misc-fixes doesn't have the updated ttm_bo.c file, we have the
updated ttm_bo.c version in
drm-misc-next branch. Please find below for the line number 907.
On 8/11/2022 3:25 PM, Dan Carpenter wrote:
> Hello Arunpravin Paneer Selvam,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch cf4b7387c0a8: "drm/ttm: Fix dummy res NULL ptr deref bug"
> from Aug 9, 2022, leads to the following Smatch complaint:
>
> drivers/gpu/drm/ttm/ttm_bo.c:915 ttm_bo_validate()
> warn: variable dereferenced before check 'bo->resource' (see line 907)
>
> drivers/gpu/drm/ttm/ttm_bo.c
> 906 */
> 907 if (!ttm_resource_compat(bo->resource, placement)) {
> ^^^^^^^^^^^^
> Unchecked dereference here inside the function.
|if (!bo->resource || !ttm_resource_compat(bo->resource, placement)) {
we have this version in drm-misc-next Regards, Arun |
>
> 908 ret = ttm_bo_move_buffer(bo, placement, ctx);
> 909 if (ret)
> 910 return ret;
> 911 }
> 912 /*
> 913 * We might need to add a TTM.
> 914 */
> 915 if (!bo->resource || bo->resource->mem_type == TTM_PL_SYSTEM) {
> ^^^^^^^^^^^^
> Checked too late.
>
> This NULL check was added deliberately based on a report from the kbuild
> bot, but it's not clear why bo->resource is NULL at this point. Was the
> patch tested? There is astable@vger.kernel.org but there is no Fixes
> tag.
>
> 916 ret = ttm_tt_create(bo, true);
> 917 if (ret)
>
> regards,
> dan carpenter
[-- Attachment #2: Type: text/html, Size: 2597 bytes --]
next prev parent reply other threads:[~2022-08-11 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:55 [bug report] drm/ttm: Fix dummy res NULL ptr deref bug Dan Carpenter
2022-08-11 11:06 ` Arunpravin Paneer Selvam [this message]
2022-08-11 11:56 ` Dan Carpenter
2022-08-14 6:00 ` Arunpravin Paneer Selvam
2022-08-14 17:50 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28f5d71e-34ca-214a-f8a8-14e227bb42cf@amd.com \
--to=arunpravin.paneerselvam@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.