* [patch] 2.4.17-pre5 oops on floppy type 6
@ 2001-12-07 3:30 Keith Owens
0 siblings, 0 replies; only message in thread
From: Keith Owens @ 2001-12-07 3:30 UTC (permalink / raw
To: Marcelo Tosatti; +Cc: lkml
IBM Thinkpads i1200/1300 with USB floppy (type 6) oops in
drivers/block/floppy.c register_devfs_entries(). Off by one bug when
comparing an index with the array size.
Index: 17-pre5.1/drivers/block/floppy.c
--- 17-pre5.1/drivers/block/floppy.c Fri, 07 Dec 2001 09:35:49 +1100 kaos (linux-2.4/c/c/40_floppy.c 1.2.1.1.1.5 644)
+++ 17-pre5.1(w)/drivers/block/floppy.c Fri, 07 Dec 2001 14:27:37 +1100 kaos (linux-2.4/c/c/40_floppy.c 1.2.1.1.1.5 644)
@@ -3917,7 +3917,7 @@ static void __init register_devfs_entrie
{NULL, t360, t1200, t3in+5+8, t3in+5, t3in, t3in};
base_minor = (drive < 4) ? drive : (124 + drive);
- if (UDP->cmos <= NUMBER(default_drive_params)) {
+ if (UDP->cmos < NUMBER(default_drive_params)) {
i = 0;
do {
char name[16];
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-12-07 3:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-12-07 3:30 [patch] 2.4.17-pre5 oops on floppy type 6 Keith Owens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.