* [bug report] drm/amd/display: Use per pipe P-State force for FPO
@ 2023-04-04 6:50 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2023-04-04 6:50 UTC (permalink / raw
To: Alvin.Lee2; +Cc: amd-gfx
Hello Alvin Lee,
This is a semi-automatic email about new static checker warnings.
The patch 4ed793083afc: "drm/amd/display: Use per pipe P-State force
for FPO" from Mar 15, 2023, leads to the following Smatch complaint:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2009 dcn20_post_unlock_program_front_end()
error: we previously assumed 'hwseq' could be null (see line 2003)
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c
2002 */
2003 if (hwseq && hwseq->funcs.update_force_pstate)
^^^^^
The patch adds this NULL check but hopefully it can be deleted.
Otherwise we are screwed.
2004 dc->hwseq->funcs.update_force_pstate(dc, context);
2005
2006 /* Only program the MALL registers after all the main and phantom pipes
2007 * are done programming.
2008 */
2009 if (hwseq->funcs.program_mall_pipe_config)
2010 hwseq->funcs.program_mall_pipe_config(dc, context);
2011
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-04 7:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 6:50 [bug report] drm/amd/display: Use per pipe P-State force for FPO Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.