From: Sven Eckelmann <sven@narfation.org>
To: syzbot <syzbot+a6a4b5bb3da165594cff@syzkaller.appspotmail.com>,
Eric Dumazet <edumazet@google.com>
Cc: a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org,
davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, mareklindner@neomailbox.ch,
netdev@vger.kernel.org, pabeni@redhat.com, sw@simonwunderlich.de,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [batman?] BUG: soft lockup in sys_sendmsg
Date: Mon, 12 Feb 2024 12:23:51 +0100 [thread overview]
Message-ID: <2173575.irdbgypaU6@ripper> (raw)
In-Reply-To: <CANn89iKPYAY226+kV9D0jUn6Kfjq1gQJBAjSRxxFgQJK-QbLwA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On Monday, 12 February 2024 11:41:38 CET Eric Dumazet wrote:
> This patch [1] looks suspicious
Shouldn't be caused by this - but this might be another way to trigger the
problem. The problem would be visible even without it when a mtu is explicitly
set. But the reproducer is not available so I can't actually check what is
going on.
> I think batman-adv should reject too small MTU values.
You are refering to the size calculated by
batadv_tt_local_table_transmit_size(), right? And yes, I would agree that it
looks suspicious and might not have been correctly integrated in
batadv_max_header_len() when commit a19d3d85e1b8 ("batman-adv: limit local
translation table max size") introduced the code. But I think we also need to
remove interfaces again when receiving NETDEV_CHANGEMTU and an interface is
not having the correctly sized anymore. So have to check how to do this the
best way.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-02-12 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 10:26 [syzbot] [batman?] BUG: soft lockup in sys_sendmsg syzbot
2024-02-12 10:41 ` Eric Dumazet
2024-02-12 11:23 ` Sven Eckelmann [this message]
2024-02-12 13:28 ` Sven Eckelmann
2024-02-12 13:28 ` Sven Eckelmann
2024-02-12 13:28 ` syzbot
2024-03-21 18:26 ` [syzbot] [tipc?] " syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2173575.irdbgypaU6@ripper \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sw@simonwunderlich.de \
--cc=syzbot+a6a4b5bb3da165594cff@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.