From: Martin Wilck <mwilck@suse.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Ewan D. Milne" <emilne@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
John Pittman <jpittman@redhat.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_dh_alua: signedness bug in alua_rtpg()
Date: Fri, 04 Jun 2021 15:03:46 +0200 [thread overview]
Message-ID: <20d1fe70b03a74cb89c9446457eff93fe7988532.camel@suse.com> (raw)
In-Reply-To: <YLjMEAFNxOas1mIp@mwanda>
On Do, 2021-06-03 at 15:33 +0300, Dan Carpenter wrote:
> The "retval" variable needs to be signed for the error handling to
> work.
>
> Fixes: 7e26e3ea0287 ("scsi: scsi_dh_alua: Check for negative result
> value")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
> b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 7baee18ebd03..37d06f993b76 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -518,7 +518,8 @@ static int alua_rtpg(struct scsi_device *sdev,
> struct alua_port_group *pg)
> int len, k, off, bufflen = ALUA_RTPG_SIZE;
> int group_id_old, state_old, pref_old, valid_states_old;
> unsigned char *desc, *buff;
> - unsigned err, retval;
> + unsigned err;
> + int retval;
> unsigned int tpg_desc_tbl_off;
> unsigned char orig_transition_tmo;
> unsigned long flags;
next prev parent reply other threads:[~2021-06-04 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 12:33 [PATCH] scsi: scsi_dh_alua: signedness bug in alua_rtpg() Dan Carpenter
2021-06-04 13:03 ` Martin Wilck [this message]
2021-06-08 1:48 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d1fe70b03a74cb89c9446457eff93fe7988532.camel@suse.com \
--to=mwilck@suse.com \
--cc=bvanassche@acm.org \
--cc=dan.carpenter@oracle.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=jpittman@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.