* bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found
@ 2024-04-03 8:23 Horst Prote
2024-04-26 23:27 ` Glenn Washburn
0 siblings, 1 reply; 4+ messages in thread
From: Horst Prote @ 2024-04-03 8:23 UTC (permalink / raw
To: grub-devel
Hi,
could the patch supplied in bug #61620
(https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
reviewed and applied.
Thanks,
Horst Prote
--
Horst Prote, FMI __o Systemadministration Abt. ALG und TI
Universitaet Stuttgart `\<, Tel: +49 711 685-88348, FAX: -88310
Universitaetsstr. 38 ( )/( ) prote@fmi.uni-stuttgart.de
D-70569 Stuttgart www.fmi.uni-stuttgart.de/alg/team/prote
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found
2024-04-03 8:23 bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found Horst Prote
@ 2024-04-26 23:27 ` Glenn Washburn
2024-05-02 16:40 ` Horst Prote
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Washburn @ 2024-04-26 23:27 UTC (permalink / raw
To: Horst Prote; +Cc: The development of GNU GRUB
On Wed, 3 Apr 2024 10:23:59 +0200
Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
> Hi,
>
> could the patch supplied in bug #61620
> (https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
> reviewed and applied.
Unfortunately, the issues tracker is mostly unused. Patches are
exclusively reviewed on this list. It would be nice if patches
submitted on the issue tracker were automatically submitted to this
list, but alas they are not. There should be really annoying blinking
text on the issue tracker saying that patches will not be looked at
unless they are sent to this list for review.
Would you be willing to submit the patch to the list so it can be
reviewed?
Glenn
>
> Thanks,
> Horst Prote
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found
2024-04-26 23:27 ` Glenn Washburn
@ 2024-05-02 16:40 ` Horst Prote
2024-05-06 20:17 ` Glenn Washburn
0 siblings, 1 reply; 4+ messages in thread
From: Horst Prote @ 2024-05-02 16:40 UTC (permalink / raw
To: grub-devel
On 26.04.2024, Glenn Washburn wrote:
> On Wed, 3 Apr 2024 10:23:59 +0200
> Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
>
> > Hi,
> >
> > could the patch supplied in bug #61620
> > (https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
> > reviewed and applied.
>
> Unfortunately, the issues tracker is mostly unused. Patches are
> exclusively reviewed on this list. It would be nice if patches
> submitted on the issue tracker were automatically submitted to this
> list, but alas they are not. There should be really annoying blinking
> text on the issue tracker saying that patches will not be looked at
> unless they are sent to this list for review.
>
> Would you be willing to submit the patch to the list so it can be
> reviewed?
OK, here is the patch from bug #61620 as supplied by
https://savannah.gnu.org/users/rogier777
---------------------------------------------------
Index: grub2-2.02+dfsg1/grub-core/disk/lvm.c
===================================================================
--- grub2-2.02+dfsg1.orig/grub-core/disk/lvm.c
+++ grub2-2.02+dfsg1/grub-core/disk/lvm.c
@@ -253,7 +253,7 @@ error_parsing_metadata:
p = q = (char *)ptr;
- if (grub_add ((grub_size_t)metadatabuf, (grub_size_t)mda_size, &ptr))
+ if (grub_add (ptr, (grub_size_t)grub_le_to_cpu64 (rlocn->size), &ptr))
goto error_parsing_metadata;
mda_end = (char *)ptr;
----------------------------------------------------
> Glenn
Horst
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found
2024-05-02 16:40 ` Horst Prote
@ 2024-05-06 20:17 ` Glenn Washburn
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Washburn @ 2024-05-06 20:17 UTC (permalink / raw
To: Horst Prote; +Cc: The development of GNU GRUB
On Thu, 2 May 2024 18:40:16 +0200
Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
> On 26.04.2024, Glenn Washburn wrote:
>
> > On Wed, 3 Apr 2024 10:23:59 +0200
> > Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
> >
> > > Hi,
> > >
> > > could the patch supplied in bug #61620
> > > (https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
> > > reviewed and applied.
> >
> > Unfortunately, the issues tracker is mostly unused. Patches are
> > exclusively reviewed on this list. It would be nice if patches
> > submitted on the issue tracker were automatically submitted to this
> > list, but alas they are not. There should be really annoying blinking
> > text on the issue tracker saying that patches will not be looked at
> > unless they are sent to this list for review.
> >
> > Would you be willing to submit the patch to the list so it can be
> > reviewed?
> OK, here is the patch from bug #61620 as supplied by
> https://savannah.gnu.org/users/rogier777
Thank you Horst,
Unfortunately, this has a near zero chance of even being looked at by
Daniel for various reasons. The foremost being that its a patch against
a debian version of 2.02, and not current master. The patch is also not
in an acceptable form for this list (see other patches submitted here).
I've looked at the issue and it is a little worrying. I'm surprised
there haven't been more complaints or that I've not yet run into this
(I suppose I nor many others have a VG that has been changed more than
220 times). I'll submit a proper patch to the list to get the ball
moving on this.
Glenn
>
> ---------------------------------------------------
> Index: grub2-2.02+dfsg1/grub-core/disk/lvm.c
> ===================================================================
> --- grub2-2.02+dfsg1.orig/grub-core/disk/lvm.c
> +++ grub2-2.02+dfsg1/grub-core/disk/lvm.c
> @@ -253,7 +253,7 @@ error_parsing_metadata:
>
> p = q = (char *)ptr;
>
> - if (grub_add ((grub_size_t)metadatabuf, (grub_size_t)mda_size, &ptr))
> + if (grub_add (ptr, (grub_size_t)grub_le_to_cpu64 (rlocn->size), &ptr))
> goto error_parsing_metadata;
>
> mda_end = (char *)ptr;
> ----------------------------------------------------
>
> > Glenn
> Horst
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-06 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-03 8:23 bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found Horst Prote
2024-04-26 23:27 ` Glenn Washburn
2024-05-02 16:40 ` Horst Prote
2024-05-06 20:17 ` Glenn Washburn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.