Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found

From: Glenn Washburn <development@efficientek.com>
To: Horst Prote <prote@fmi.uni-stuttgart.de>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found
Date: Mon, 6 May 2024 15:17:45 -0500	[thread overview]
Message-ID: <20240506151729.42b61a5b@crass-HP-ZBook-15-G2> (raw)
In-Reply-To: <20240502184016.19058b8d@fmi.uni-stuttgart.de>

On Thu, 2 May 2024 18:40:16 +0200
Horst Prote <prote@fmi.uni-stuttgart.de> wrote:

> On 26.04.2024, Glenn Washburn wrote:
> 
> > On Wed, 3 Apr 2024 10:23:59 +0200
> > Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
> > 
> > > Hi,
> > > 
> > > could the patch supplied in bug #61620
> > > (https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
> > > reviewed and applied.  
> > 
> > Unfortunately, the issues tracker is mostly unused. Patches are
> > exclusively reviewed on this list. It would be nice if patches
> > submitted on the issue tracker were automatically submitted to this
> > list, but alas they are not. There should be really annoying blinking
> > text on the issue tracker saying that patches will not be looked at
> > unless they are sent to this list for review.
> > 
> > Would you be willing to submit the patch to the list so it can be
> > reviewed?
> OK, here is the patch from bug #61620 as supplied by
> https://savannah.gnu.org/users/rogier777

Thank you Horst,

Unfortunately, this has a near zero chance of even being looked at by
Daniel for various reasons. The foremost being that its a patch against
a debian version of 2.02, and not current master. The patch is also not
in an acceptable form for this list (see other patches submitted here).

I've looked at the issue and it is a little worrying. I'm surprised
there haven't been more complaints or that I've not yet run into this
(I suppose I nor many others have a VG that has been changed more than
220 times). I'll submit a proper patch to the list to get the ball
moving on this.

Glenn

> 
> ---------------------------------------------------
> Index: grub2-2.02+dfsg1/grub-core/disk/lvm.c
> ===================================================================
> --- grub2-2.02+dfsg1.orig/grub-core/disk/lvm.c
> +++ grub2-2.02+dfsg1/grub-core/disk/lvm.c
> @@ -253,7 +253,7 @@ error_parsing_metadata:
> 
>    p = q = (char *)ptr;
> 
> -  if (grub_add ((grub_size_t)metadatabuf, (grub_size_t)mda_size, &ptr))
> +  if (grub_add (ptr, (grub_size_t)grub_le_to_cpu64 (rlocn->size), &ptr))
>      goto error_parsing_metadata;
> 
>    mda_end = (char *)ptr;
> ----------------------------------------------------
> 
> > Glenn
> Horst
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel