All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: git@luigi311.com
To: linux-media@vger.kernel.org
Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
	mchehab@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	sakari.ailus@linux.intel.com, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pavel@ucw.cz,
	phone-devel@vger.kernel.org, Ondrej Jirman <megi@xff.cz>,
	Luis Garcia <git@luigi311.com>
Subject: [PATCH v5 22/25] media: i2c: imx258: Add support for powerdown gpio
Date: Wed,  1 May 2024 09:24:39 -0600	[thread overview]
Message-ID: <20240501152442.1072627-23-git@luigi311.com> (raw)
In-Reply-To: <20240501152442.1072627-1-git@luigi311.com>

From: Ondrej Jirman <megi@xff.cz>

On some boards powerdown signal needs to be deasserted for this
sensor to be enabled.

Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Luis Garcia <git@luigi311.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
---
 drivers/media/i2c/imx258.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index f043200e336e..f0bd72f241e4 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -698,6 +698,8 @@ struct imx258 {
 	unsigned int lane_mode_idx;
 	unsigned int csi2_flags;
 
+	struct gpio_desc *powerdown_gpio;
+
 	/*
 	 * Mutex for serialized access:
 	 * Protect sensor module set pad format and start/stop streaming safely.
@@ -1231,6 +1233,8 @@ static int imx258_power_on(struct device *dev)
 	struct imx258 *imx258 = to_imx258(sd);
 	int ret;
 
+	gpiod_set_value_cansleep(imx258->powerdown_gpio, 0);
+
 	ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES,
 				    imx258->supplies);
 	if (ret) {
@@ -1242,6 +1246,7 @@ static int imx258_power_on(struct device *dev)
 	ret = clk_prepare_enable(imx258->clk);
 	if (ret) {
 		dev_err(dev, "failed to enable clock\n");
+		gpiod_set_value_cansleep(imx258->powerdown_gpio, 1);
 		regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
 	}
 
@@ -1254,6 +1259,9 @@ static int imx258_power_off(struct device *dev)
 	struct imx258 *imx258 = to_imx258(sd);
 
 	clk_disable_unprepare(imx258->clk);
+
+	gpiod_set_value_cansleep(imx258->powerdown_gpio, 1);
+
 	regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
 
 	return 0;
@@ -1559,6 +1567,12 @@ static int imx258_probe(struct i2c_client *client)
 	if (!imx258->variant_cfg)
 		imx258->variant_cfg = &imx258_cfg;
 
+	/* request optional power down pin */
+	imx258->powerdown_gpio = devm_gpiod_get_optional(&client->dev, "powerdown",
+							 GPIOD_OUT_HIGH);
+	if (IS_ERR(imx258->powerdown_gpio))
+		return PTR_ERR(imx258->powerdown_gpio);
+
 	/* Initialize subdev */
 	v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops);
 
-- 
2.44.0


WARNING: multiple messages have this Message-ID (diff)
From: git@luigi311.com
To: linux-media@vger.kernel.org
Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
	mchehab@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	sakari.ailus@linux.intel.com, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pavel@ucw.cz,
	phone-devel@vger.kernel.org, Ondrej Jirman <megi@xff.cz>,
	Luis Garcia <git@luigi311.com>
Subject: [PATCH v5 22/25] media: i2c: imx258: Add support for powerdown gpio
Date: Wed,  1 May 2024 09:24:39 -0600	[thread overview]
Message-ID: <20240501152442.1072627-23-git@luigi311.com> (raw)
In-Reply-To: <20240501152442.1072627-1-git@luigi311.com>

From: Ondrej Jirman <megi@xff.cz>

On some boards powerdown signal needs to be deasserted for this
sensor to be enabled.

Signed-off-by: Ondrej Jirman <megi@xff.cz>
Signed-off-by: Luis Garcia <git@luigi311.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
---
 drivers/media/i2c/imx258.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index f043200e336e..f0bd72f241e4 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -698,6 +698,8 @@ struct imx258 {
 	unsigned int lane_mode_idx;
 	unsigned int csi2_flags;
 
+	struct gpio_desc *powerdown_gpio;
+
 	/*
 	 * Mutex for serialized access:
 	 * Protect sensor module set pad format and start/stop streaming safely.
@@ -1231,6 +1233,8 @@ static int imx258_power_on(struct device *dev)
 	struct imx258 *imx258 = to_imx258(sd);
 	int ret;
 
+	gpiod_set_value_cansleep(imx258->powerdown_gpio, 0);
+
 	ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES,
 				    imx258->supplies);
 	if (ret) {
@@ -1242,6 +1246,7 @@ static int imx258_power_on(struct device *dev)
 	ret = clk_prepare_enable(imx258->clk);
 	if (ret) {
 		dev_err(dev, "failed to enable clock\n");
+		gpiod_set_value_cansleep(imx258->powerdown_gpio, 1);
 		regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
 	}
 
@@ -1254,6 +1259,9 @@ static int imx258_power_off(struct device *dev)
 	struct imx258 *imx258 = to_imx258(sd);
 
 	clk_disable_unprepare(imx258->clk);
+
+	gpiod_set_value_cansleep(imx258->powerdown_gpio, 1);
+
 	regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies);
 
 	return 0;
@@ -1559,6 +1567,12 @@ static int imx258_probe(struct i2c_client *client)
 	if (!imx258->variant_cfg)
 		imx258->variant_cfg = &imx258_cfg;
 
+	/* request optional power down pin */
+	imx258->powerdown_gpio = devm_gpiod_get_optional(&client->dev, "powerdown",
+							 GPIOD_OUT_HIGH);
+	if (IS_ERR(imx258->powerdown_gpio))
+		return PTR_ERR(imx258->powerdown_gpio);
+
 	/* Initialize subdev */
 	v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops);
 
-- 
2.44.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-05-01 15:30 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 15:24 [PATCH v5 00/25] imx258 improvement series git
2024-05-01 15:24 ` git
2024-05-01 15:24 ` [PATCH v5 01/25] media: i2c: imx258: Remove unused defines git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 02/25] media: i2c: imx258: Make image geometry meet sensor requirements git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 03/25] media: i2c: imx258: Disable digital cropping on binned modes git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 04/25] media: i2c: imx258: Remove redundant I2C writes git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 05/25] media: i2c: imx258: Add regulator control git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 06/25] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 07/25] media: i2c: imx258: Split out common registers from the mode based ones git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 08/25] media: i2c: imx258: Add support for 24MHz clock git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 10/25] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 11/25] media: i2c: imx258: Add get_selection for pixel array information git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 13/25] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 14/25] media: i2c: imx258: Issue reset before starting streaming git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 15/25] media: i2c: imx258: Set pixel_rate range to the same as the value git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 16/25] media: i2c: imx258: Support faster pixel rate on binned modes git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 17/25] dt-bindings: media: imx258: Rename to include vendor prefix git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 18/25] dt-bindings: media: imx258: Add alternate compatible strings git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 19/25] media: i2c: imx258: Change register settings for variants of the sensor git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 20/25] media: i2c: imx258: Make HFLIP and VFLIP controls writable git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 21/25] dt-bindings: media: imx258: Add binding for powerdown-gpio git
2024-05-01 15:24   ` git
2024-05-17  8:31   ` Sakari Ailus
2024-05-17  8:31     ` Sakari Ailus
2024-05-20 12:50     ` Sakari Ailus
2024-05-20 12:50       ` Sakari Ailus
2024-06-02 20:20       ` Luis Garcia
2024-06-02 20:20         ` Luis Garcia
2024-05-20 12:55     ` Ondřej Jirman
2024-05-20 12:55       ` Ondřej Jirman
2024-05-20 13:19       ` Sakari Ailus
2024-05-20 13:19         ` Sakari Ailus
2024-05-20 13:20       ` Dave Stevenson
2024-05-20 13:20         ` Dave Stevenson
2024-05-20 19:04         ` Ondřej Jirman
2024-05-20 19:04           ` Ondřej Jirman
2024-05-01 15:24 ` git [this message]
2024-05-01 15:24   ` [PATCH v5 22/25] media: i2c: imx258: Add support for powerdown gpio git
2024-05-01 15:24 ` [PATCH v5 23/25] media: i2c: imx258: Add support for reset gpio git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 24/25] media: i2c: imx258: Use v4l2_link_freq_to_bitmap helper git
2024-05-01 15:24   ` git
2024-05-01 15:24 ` [PATCH v5 25/25] media: i2c: imx258: Convert to new CCI register access helpers git
2024-05-01 15:24   ` git

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240501152442.1072627-23-git@luigi311.com \
    --to=git@luigi311.com \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=megi@xff.cz \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.