* [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list
@ 2024-04-30 21:19 Gustavo Sousa
2024-04-30 22:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Gustavo Sousa @ 2024-04-30 21:19 UTC (permalink / raw
To: igt-dev
The function job_list_from_test_list() uses a while loop to read entries
from the testlist.
The condition ((delim = strchr(binary, '@')) != NULL) checks if the
current entry specifies a subtest. When no subtest is specified, the
else clause will cause a jump to the next iteration. That means that we
are certain any statement executed after that if block has (delim !=
NULL). As such, all null checks on that variable after that point are
pointless.
In fact, certain unnecessary null checks might even cause confusion to
readers. One example is the block meant to display the "Unexpected test
without subtests ..." message: it would never happen, since that
condition is handled earlier in the iteration (i.e. the full set of
subtests is expanded for that entry in the else clause previously
mentioned). The following execution (done before this change)
illustrates that:
$ cat <<EOF > /tmp/foo.testlist
igt@xe_pm@s2idle-basic
igt@xe_pm
igt@xe_pm@s2idle-exec-after
EOF
$ ./build/runner/igt_runner -d -m --test-list /tmp/foo.testlist build/tests /tmp/results
[36408.109043] Dry run, not executing. Invoke igt_resume if you want to execute.
Done.
$ cat /tmp/results/joblist.txt | sed 's/^\(.\{50\}\).\+/\1.../'
xe_pm s2idle-basic
xe_pm s2idle-basic,s2idle-basic-exec,s2idle-exec-a...
xe_pm s2idle-exec-after
Let's remove those unnecessary checks.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
runner/job_list.c | 21 +++++----------------
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/runner/job_list.c b/runner/job_list.c
index 27cbb10bce56..aeabb59f49d3 100644
--- a/runner/job_list.c
+++ b/runner/job_list.c
@@ -276,16 +276,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
* specified, also start a new entry.
*/
if (entry.binary && !strcmp(entry.binary, binary) &&
- (delim == NULL || strchr(delim, '@') == NULL)) {
- if (!delim) {
- /* ... except we didn't get a subtest */
- fprintf(stderr,
- "Error: Unexpected test without subtests "
- "after same test had subtests\n");
- free(binary);
- fclose(f);
- return false;
- }
+ strchr(delim, '@') == NULL) {
entry.subtest_count++;
entry.subtests = realloc(entry.subtests,
entry.subtest_count *
@@ -303,7 +294,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
memset(&entry, 0, sizeof(entry));
- if (delim != NULL && strchr(delim, '@') != NULL) {
+ if (strchr(delim, '@') != NULL) {
/* Dynamic subtest specified. Add to job list alone. */
char **subtests;
@@ -314,11 +305,9 @@ static bool job_list_from_test_list(struct job_list *job_list,
any = true;
} else {
entry.binary = strdup(binary);
- if (delim) {
- entry.subtests = malloc(sizeof(*entry.subtests));
- entry.subtests[0] = strdup(delim);
- entry.subtest_count = 1;
- }
+ entry.subtests = malloc(sizeof(*entry.subtests));
+ entry.subtests[0] = strdup(delim);
+ entry.subtest_count = 1;
}
free(binary);
--
2.44.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for runner: Remove useless null check for delim in job_list_from_test_list
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
@ 2024-04-30 22:12 ` Patchwork
2024-04-30 22:15 ` ✓ CI.xeBAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2024-04-30 22:12 UTC (permalink / raw
To: Gustavo Sousa; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8670 bytes --]
== Series Details ==
Series: runner: Remove useless null check for delim in job_list_from_test_list
URL : https://patchwork.freedesktop.org/series/133106/
State : failure
== Summary ==
CI Bug Log - changes from IGT_7827 -> IGTPW_11087
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_11087 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_11087, please notify your bug team ('I915-ci-infra@lists.freedesktop.org') to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/index.html
Participating hosts (42 -> 40)
------------------------------
Additional (1): bat-dg2-11
Missing (3): fi-kbl-8809g fi-apl-guc fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_11087:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- bat-arls-1: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7827/bat-arls-1/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-arls-1/igt@i915_selftest@live@hangcheck.html
Known issues
------------
Here are the changes found in IGTPW_11087 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-dg2-11: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg2-11: NOTRUN -> [SKIP][4] ([i915#4077]) +2 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg2-11: NOTRUN -> [SKIP][5] ([i915#4079]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-11: NOTRUN -> [SKIP][6] ([i915#6621])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@hangcheck:
- bat-mtlp-6: [PASS][7] -> [ABORT][8] ([i915#9840])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7827/bat-mtlp-6/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-mtlp-6/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][9] ([i915#4212]) +7 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][10] ([i915#5190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#4215] / [i915#5190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg2-11: NOTRUN -> [SKIP][12] ([i915#4103] / [i915#4213]) +1 other test skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- bat-dg2-11: NOTRUN -> [SKIP][13] ([i915#3555] / [i915#3840])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-11: NOTRUN -> [SKIP][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-11: NOTRUN -> [SKIP][15] ([i915#5274])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pm_backlight@basic-brightness:
- bat-dg2-11: NOTRUN -> [SKIP][16] ([i915#5354])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-sprite-plane-onoff:
- bat-dg2-11: NOTRUN -> [SKIP][17] ([i915#1072] / [i915#9732]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-11: NOTRUN -> [SKIP][18] ([i915#3555])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-11: NOTRUN -> [SKIP][19] ([i915#3708])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-11: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4077]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-read:
- bat-dg2-11: NOTRUN -> [SKIP][21] ([i915#3291] / [i915#3708]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-dg2-11/igt@prime_vgem@basic-read.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- {bat-mtlp-9}: [WARN][22] ([i915#10436]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7827/bat-mtlp-9/igt@i915_pm_rpm@module-reload.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-mtlp-9/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_engines:
- bat-adls-6: [TIMEOUT][24] ([i915#10026]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7827/bat-adls-6/igt@i915_selftest@live@gt_engines.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/bat-adls-6/igt@i915_selftest@live@gt_engines.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10026]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10026
[i915#10436]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10436
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4215
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9840
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7827 -> IGTPW_11087
CI-20190529: 20190529
CI_DRM_14685: 3ac3efef3a1fc9d494b0a63c78bd0039a0b3d009 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_11087: 29b010aa4715d4c05e65e92b9862d2c45daf5256 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_7827: 973652fb579733234d1ecbc9304788153e462f11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11087/index.html
[-- Attachment #2: Type: text/html, Size: 10194 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ CI.xeBAT: success for runner: Remove useless null check for delim in job_list_from_test_list
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
2024-04-30 22:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2024-04-30 22:15 ` Patchwork
2024-05-01 4:37 ` ✗ CI.xeFULL: failure " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2024-04-30 22:15 UTC (permalink / raw
To: Gustavo Sousa; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 14264 bytes --]
== Series Details ==
Series: runner: Remove useless null check for delim in job_list_from_test_list
URL : https://patchwork.freedesktop.org/series/133106/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7827_BAT -> XEIGTPW_11087_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (0 -> 5)
------------------------------
Additional (5): bat-pvc-2 bat-lnl-1 bat-dg2-oem2 bat-adlp-7 bat-atsm-2
Known issues
------------
Here are the changes found in XEIGTPW_11087_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-pvc-2: NOTRUN -> [SKIP][1] ([i915#6077]) +30 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-oem2: NOTRUN -> [SKIP][2] ([Intel XE#623])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@invalid-set-prop-any:
- bat-atsm-2: NOTRUN -> [SKIP][3] ([i915#6077]) +30 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_addfb_basic@invalid-set-prop-any.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-pvc-2: NOTRUN -> [SKIP][4] ([Intel XE#1024] / [Intel XE#782]) +5 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- bat-atsm-2: NOTRUN -> [SKIP][5] ([Intel XE#1024] / [Intel XE#782]) +5 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-atsm-2: NOTRUN -> [SKIP][6] ([Intel XE#1024] / [Intel XE#784])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_dsc@dsc-basic.html
- bat-pvc-2: NOTRUN -> [SKIP][7] ([Intel XE#1024] / [Intel XE#784])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_dsc@dsc-basic.html
- bat-dg2-oem2: NOTRUN -> [SKIP][8] ([Intel XE#455])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@kms_dsc@dsc-basic.html
- bat-adlp-7: NOTRUN -> [SKIP][9] ([Intel XE#455])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@kms_dsc@dsc-basic.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-pvc-2: NOTRUN -> [SKIP][10] ([Intel XE#1024] / [Intel XE#947]) +3 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_flip@basic-flip-vs-modeset:
- bat-atsm-2: NOTRUN -> [SKIP][11] ([Intel XE#1024] / [Intel XE#947]) +3 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_flip@basic-flip-vs-modeset.html
* igt@kms_force_connector_basic@force-connector-state:
- bat-pvc-2: NOTRUN -> [SKIP][12] ([Intel XE#540]) +3 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_force_connector_basic@force-connector-state.html
- bat-atsm-2: NOTRUN -> [SKIP][13] ([Intel XE#540]) +3 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-oem2: NOTRUN -> [SKIP][14] ([i915#5274])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-pvc-2: NOTRUN -> [SKIP][15] ([Intel XE#1024] / [Intel XE#783])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_frontbuffer_tracking@basic.html
- bat-adlp-7: NOTRUN -> [FAIL][16] ([Intel XE#616])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
- bat-atsm-2: NOTRUN -> [SKIP][17] ([Intel XE#1024] / [Intel XE#783])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- bat-atsm-2: NOTRUN -> [SKIP][18] ([i915#1836]) +6 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-pvc-2: NOTRUN -> [SKIP][19] ([Intel XE#829]) +6 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_prop_blob@basic:
- bat-pvc-2: NOTRUN -> [SKIP][20] ([Intel XE#780])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_prop_blob@basic.html
- bat-atsm-2: NOTRUN -> [SKIP][21] ([Intel XE#780])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_prop_blob@basic.html
* igt@kms_psr@psr-cursor-plane-move:
- bat-pvc-2: NOTRUN -> [SKIP][22] ([Intel XE#1024]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@kms_psr@psr-cursor-plane-move.html
- bat-dg2-oem2: NOTRUN -> [SKIP][23] ([Intel XE#929]) +2 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@kms_psr@psr-cursor-plane-move.html
* igt@kms_psr@psr-primary-page-flip:
- bat-atsm-2: NOTRUN -> [SKIP][24] ([Intel XE#1024]) +2 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@kms_psr@psr-primary-page-flip.html
* igt@xe_evict@evict-beng-small-external:
- bat-pvc-2: NOTRUN -> [FAIL][25] ([Intel XE#1000]) +3 other tests fail
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_evict@evict-beng-small-external.html
- bat-adlp-7: NOTRUN -> [SKIP][26] ([Intel XE#261] / [Intel XE#688]) +15 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_evict@evict-beng-small-external.html
* igt@xe_evict@evict-small-cm:
- bat-pvc-2: NOTRUN -> [DMESG-FAIL][27] ([Intel XE#482]) +3 other tests dmesg-fail
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_evict@evict-small-cm.html
* igt@xe_evict_ccs@evict-overcommit-simple:
- bat-adlp-7: NOTRUN -> [SKIP][28] ([Intel XE#688]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_evict_ccs@evict-overcommit-simple.html
* igt@xe_exec_fault_mode@many-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][29] ([Intel XE#288]) +32 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@xe_exec_fault_mode@many-basic.html
* igt@xe_exec_fault_mode@twice-userptr:
- bat-adlp-7: NOTRUN -> [SKIP][30] ([Intel XE#288]) +32 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_exec_fault_mode@twice-userptr.html
* igt@xe_exec_fault_mode@twice-userptr-invalidate-imm:
- bat-atsm-2: NOTRUN -> [SKIP][31] ([Intel XE#288]) +32 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@xe_exec_fault_mode@twice-userptr-invalidate-imm.html
* igt@xe_gt_freq@freq_range_idle:
- bat-pvc-2: NOTRUN -> [SKIP][32] ([Intel XE#1021]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_gt_freq@freq_range_idle.html
* igt@xe_huc_copy@huc_copy:
- bat-pvc-2: NOTRUN -> [SKIP][33] ([Intel XE#255])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_huc_copy@huc_copy.html
- bat-dg2-oem2: NOTRUN -> [SKIP][34] ([Intel XE#255])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html
- bat-atsm-2: NOTRUN -> [SKIP][35] ([Intel XE#255])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@xe_huc_copy@huc_copy.html
* igt@xe_intel_bb@render:
- bat-pvc-2: NOTRUN -> [SKIP][36] ([Intel XE#532])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_intel_bb@render.html
* igt@xe_mmap@vram:
- bat-adlp-7: NOTRUN -> [SKIP][37] ([Intel XE#1008])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_mmap@vram.html
* igt@xe_pat@pat-index-xe2:
- bat-pvc-2: NOTRUN -> [SKIP][38] ([Intel XE#977]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_pat@pat-index-xe2.html
- bat-adlp-7: NOTRUN -> [SKIP][39] ([Intel XE#977])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_pat@pat-index-xe2.html
- bat-atsm-2: NOTRUN -> [SKIP][40] ([Intel XE#977])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@xe_pat@pat-index-xe2.html
- bat-dg2-oem2: NOTRUN -> [SKIP][41] ([Intel XE#977])
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@xe_pat@pat-index-xe2.html
* igt@xe_pat@pat-index-xehpc:
- bat-dg2-oem2: NOTRUN -> [SKIP][42] ([Intel XE#979]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-dg2-oem2/igt@xe_pat@pat-index-xehpc.html
- bat-adlp-7: NOTRUN -> [SKIP][43] ([Intel XE#979]) +1 other test skip
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-adlp-7/igt@xe_pat@pat-index-xehpc.html
* igt@xe_pat@pat-index-xehpc@render:
- bat-pvc-2: NOTRUN -> [SKIP][44] ([Intel XE#976])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_pat@pat-index-xehpc@render.html
* igt@xe_pat@pat-index-xelpg:
- bat-atsm-2: NOTRUN -> [SKIP][45] ([Intel XE#979]) +1 other test skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-atsm-2/igt@xe_pat@pat-index-xelpg.html
- bat-pvc-2: NOTRUN -> [SKIP][46] ([Intel XE#979])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_pat@pat-index-xelpg.html
* igt@xe_pm_residency@gt-c6-on-idle:
- bat-pvc-2: NOTRUN -> [SKIP][47] ([Intel XE#531])
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/bat-pvc-2/igt@xe_pm_residency@gt-c6-on-idle.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1000]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1000
[Intel XE#1008]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1008
[Intel XE#1021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1021
[Intel XE#1024]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1024
[Intel XE#1416]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1416
[Intel XE#1420]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1420
[Intel XE#1442]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1442
[Intel XE#1446]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1446
[Intel XE#1462]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1462
[Intel XE#1466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1466
[Intel XE#1470]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1470
[Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
[Intel XE#261]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/261
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/352
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/482
[Intel XE#531]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/531
[Intel XE#532]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/532
[Intel XE#540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/540
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#780]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/780
[Intel XE#782]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/782
[Intel XE#783]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/783
[Intel XE#784]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/784
[Intel XE#829]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/829
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#947]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/947
[Intel XE#976]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/976
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
[i915#1836]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1836
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#6077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6077
Build changes
-------------
* IGT: IGT_7827 -> IGTPW_11087
IGTPW_11087: 29b010aa4715d4c05e65e92b9862d2c45daf5256 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_7827: 973652fb579733234d1ecbc9304788153e462f11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-1213-3ac3efef3a1fc9d494b0a63c78bd0039a0b3d009: 3ac3efef3a1fc9d494b0a63c78bd0039a0b3d009
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/index.html
[-- Attachment #2: Type: text/html, Size: 16966 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ CI.xeFULL: failure for runner: Remove useless null check for delim in job_list_from_test_list
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
2024-04-30 22:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-04-30 22:15 ` ✓ CI.xeBAT: success " Patchwork
@ 2024-05-01 4:37 ` Patchwork
2024-05-07 17:13 ` [i-g-t] " Ngai-Mint Kwan
2024-05-10 17:37 ` [PATCH i-g-t] " Kamil Konieczny
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2024-05-01 4:37 UTC (permalink / raw
To: Gustavo Sousa; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 41345 bytes --]
== Series Details ==
Series: runner: Remove useless null check for delim in job_list_from_test_list
URL : https://patchwork.freedesktop.org/series/133106/
State : failure
== Summary ==
CI Bug Log - changes from XEIGT_7827_full -> XEIGTPW_11087_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with XEIGTPW_11087_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_11087_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (3 -> 1)
------------------------------
ERROR: It appears as if the changes made in XEIGTPW_11087_full prevented too many machines from booting.
Missing (2): shard-adlp shard-lnl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_11087_full:
### IGT changes ###
#### Possible regressions ####
* igt@xe_evict@evict-large-multi-vm-cm:
- shard-dg2-set2: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@xe_evict@evict-large-multi-vm-cm.html
Known issues
------------
Here are the changes found in XEIGTPW_11087_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@bad-pitch-32:
- shard-dg2-set2: [PASS][2] -> [SKIP][3] ([Intel XE#1201] / [i915#6077])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_addfb_basic@bad-pitch-32.html
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_addfb_basic@bad-pitch-32.html
* igt@kms_atomic@plane-invalid-params-fence:
- shard-dg2-set2: [PASS][4] -> [SKIP][5] ([Intel XE#1201]) +15 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_atomic@plane-invalid-params-fence.html
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_atomic@plane-invalid-params-fence.html
* igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][6] -> [DMESG-WARN][7] ([Intel XE#1214]) +1 other test dmesg-warn
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6.html
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_atomic_interruptible@atomic-setmode@pipe-a-hdmi-a-6.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- shard-dg2-set2: NOTRUN -> [SKIP][8] ([Intel XE#1201] / [Intel XE#316]) +1 other test skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_big_fb@4-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- shard-dg2-set2: NOTRUN -> [SKIP][9] ([Intel XE#1124] / [Intel XE#1201])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
* igt@kms_bw@linear-tiling-2-displays-1920x1080p:
- shard-dg2-set2: NOTRUN -> [SKIP][10] ([Intel XE#1201] / [Intel XE#367])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_bw@linear-tiling-2-displays-1920x1080p.html
* igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-a-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][11] ([Intel XE#1201] / [Intel XE#787]) +62 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-a-dp-4.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-mc-ccs@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [FAIL][12] ([Intel XE#650]) +3 other tests fail
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-mc-ccs@pipe-d-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][13] ([Intel XE#1201] / [Intel XE#829])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs.html
* igt@kms_ccs@random-ccs-data-y-tiled-gen12-mc-ccs@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][14] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) +17 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_ccs@random-ccs-data-y-tiled-gen12-mc-ccs@pipe-d-dp-4.html
* igt@kms_cdclk@mode-transition:
- shard-dg2-set2: [PASS][15] -> [SKIP][16] ([Intel XE#1201] / [Intel XE#1235])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_cdclk@mode-transition.html
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_cdclk@mode-transition.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][17] ([Intel XE#1152] / [Intel XE#1201]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_cdclk@plane-scaling@pipe-b-dp-4.html
* igt@kms_chamelium_color@ctm-0-50:
- shard-dg2-set2: NOTRUN -> [SKIP][18] ([Intel XE#1201] / [Intel XE#306])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_chamelium_color@ctm-0-50.html
* igt@kms_cursor_crc@cursor-rapid-movement-256x256@pipe-d-hdmi-a-6:
- shard-dg2-set2: [PASS][19] -> [DMESG-WARN][20] ([Intel XE#1214] / [Intel XE#282]) +14 other tests dmesg-warn
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_cursor_crc@cursor-rapid-movement-256x256@pipe-d-hdmi-a-6.html
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_cursor_crc@cursor-rapid-movement-256x256@pipe-d-hdmi-a-6.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-dg2-set2: NOTRUN -> [SKIP][21] ([Intel XE#1201] / [Intel XE#323])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@single-move@pipe-a:
- shard-dg2-set2: [PASS][22] -> [DMESG-WARN][23] ([Intel XE#1214] / [Intel XE#282] / [Intel XE#877])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_cursor_legacy@single-move@pipe-a.html
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_cursor_legacy@single-move@pipe-a.html
* igt@kms_feature_discovery@display-3x:
- shard-dg2-set2: NOTRUN -> [SKIP][24] ([Intel XE#1201] / [Intel XE#703])
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_feature_discovery@display-3x.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-dg2-set2: [PASS][25] -> [SKIP][26] ([Intel XE#1201] / [Intel XE#1234])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend@a-hdmi-a6:
- shard-dg2-set2: [PASS][27] -> [DMESG-WARN][28] ([Intel XE#1162] / [Intel XE#1214]) +3 other tests dmesg-warn
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-464/igt@kms_flip@flip-vs-suspend@a-hdmi-a6.html
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_flip@flip-vs-suspend@a-hdmi-a6.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-upscaling:
- shard-dg2-set2: NOTRUN -> [SKIP][29] ([Intel XE#1201]) +1 other test skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-upscaling.html
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscren-pri-indfb-draw-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][30] ([Intel XE#1201] / [Intel XE#651]) +2 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render:
- shard-dg2-set2: NOTRUN -> [SKIP][31] ([Intel XE#1201] / [Intel XE#653]) +5 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render.html
* igt@kms_pipe_crc_basic@bad-source:
- shard-dg2-set2: [PASS][32] -> [SKIP][33] ([Intel XE#1201] / [Intel XE#829]) +5 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_pipe_crc_basic@bad-source.html
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_pipe_crc_basic@bad-source.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-a-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][34] ([Intel XE#1201] / [Intel XE#498]) +2 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-a-hdmi-a-6.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-d-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][35] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#498])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers@pipe-d-hdmi-a-6.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25:
- shard-dg2-set2: NOTRUN -> [SKIP][36] ([Intel XE#1201] / [Intel XE#305] / [Intel XE#455])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][37] ([Intel XE#1201] / [Intel XE#305]) +2 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-hdmi-a-6.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][38] ([Intel XE#1201] / [Intel XE#455]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-d-hdmi-a-6.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2-set2: NOTRUN -> [SKIP][39] ([Intel XE#1122] / [Intel XE#1201])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@fbc-psr2-primary-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][40] ([Intel XE#1201] / [Intel XE#929]) +2 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_psr@fbc-psr2-primary-blt.html
* igt@kms_sysfs_edid_timing:
- shard-dg2-set2: [PASS][41] -> [FAIL][42] ([Intel XE#1174])
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_sysfs_edid_timing.html
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_sysfs_edid_timing.html
* igt@kms_writeback@writeback-check-output:
- shard-dg2-set2: NOTRUN -> [SKIP][43] ([Intel XE#1201] / [Intel XE#756])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_writeback@writeback-check-output.html
* igt@xe_evict@evict-beng-mixed-threads-large:
- shard-dg2-set2: [PASS][44] -> [TIMEOUT][45] ([Intel XE#1041] / [Intel XE#1473] / [Intel XE#392])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@xe_evict@evict-beng-mixed-threads-large.html
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@xe_evict@evict-beng-mixed-threads-large.html
* igt@xe_evict@evict-beng-threads-large:
- shard-dg2-set2: [PASS][46] -> [INCOMPLETE][47] ([Intel XE#1195] / [Intel XE#1473])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@xe_evict@evict-beng-threads-large.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@xe_evict@evict-beng-threads-large.html
* igt@xe_evict@evict-cm-threads-large:
- shard-dg2-set2: [PASS][48] -> [TIMEOUT][49] ([Intel XE#1473] / [Intel XE#392])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@xe_evict@evict-cm-threads-large.html
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@xe_evict@evict-cm-threads-large.html
* igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-rebind-imm:
- shard-dg2-set2: NOTRUN -> [SKIP][50] ([Intel XE#1201] / [Intel XE#288]) +3 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-rebind-imm.html
* igt@xe_exec_fault_mode@once-userptr-imm:
- shard-dg2-set2: NOTRUN -> [SKIP][51] ([Intel XE#1201] / [Intel XE#1562]) +1 other test skip
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-434/igt@xe_exec_fault_mode@once-userptr-imm.html
* igt@xe_exec_reset@gt-reset-stress:
- shard-dg2-set2: NOTRUN -> [DMESG-WARN][52] ([Intel XE#1214] / [Intel XE#1638])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@xe_exec_reset@gt-reset-stress.html
* igt@xe_pat@display-vs-wb-transient:
- shard-dg2-set2: NOTRUN -> [SKIP][53] ([Intel XE#1201] / [Intel XE#1337])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@xe_pat@display-vs-wb-transient.html
* igt@xe_pm@s4-d3hot-basic-exec:
- shard-dg2-set2: NOTRUN -> [FAIL][54] ([Intel XE#1043] / [Intel XE#845])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@xe_pm@s4-d3hot-basic-exec.html
#### Possible fixes ####
* igt@kms_addfb_basic@addfb25-bad-modifier:
- shard-dg2-set2: [SKIP][55] ([Intel XE#1201] / [i915#6077]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_addfb_basic@addfb25-bad-modifier.html
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-434/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-dp-4:
- shard-dg2-set2: [FAIL][57] ([Intel XE#827]) -> [PASS][58] +1 other test pass
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-dp-4.html
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-434/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-dp-4.html
* igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs:
- shard-dg2-set2: [SKIP][59] ([Intel XE#1201] / [Intel XE#829]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs.html
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_ccs@bad-rotation-90-4-tiled-dg2-rc-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-rc-ccs-cc@pipe-c-hdmi-a-6:
- shard-dg2-set2: [FAIL][61] ([Intel XE#616]) -> [PASS][62] +8 other tests pass
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-434/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-rc-ccs-cc@pipe-c-hdmi-a-6.html
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-dg2-rc-ccs-cc@pipe-c-hdmi-a-6.html
* igt@kms_cdclk@plane-scaling:
- shard-dg2-set2: [SKIP][63] ([Intel XE#1201] / [Intel XE#1234]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_cdclk@plane-scaling.html
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_cdclk@plane-scaling.html
* igt@kms_cursor_edge_walk@128x128-right-edge:
- shard-dg2-set2: [FAIL][65] ([Intel XE#581]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_cursor_edge_walk@128x128-right-edge.html
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_cursor_edge_walk@128x128-right-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-dg2-set2: [DMESG-WARN][67] ([Intel XE#1214] / [Intel XE#282] / [Intel XE#910]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@torture-bo@pipe-b:
- shard-dg2-set2: [DMESG-WARN][69] ([Intel XE#1214] / [Intel XE#282]) -> [PASS][70] +1 other test pass
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-434/igt@kms_cursor_legacy@torture-bo@pipe-b.html
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_cursor_legacy@torture-bo@pipe-b.html
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-dg2-set2: [SKIP][71] ([Intel XE#1201]) -> [PASS][72] +8 other tests pass
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
* igt@kms_hdmi_inject@inject-audio:
- shard-dg2-set2: [SKIP][73] ([Intel XE#1201] / [Intel XE#417]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-464/igt@kms_hdmi_inject@inject-audio.html
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_sequence@get-idle:
- shard-dg2-set2: [INCOMPLETE][75] ([Intel XE#1195]) -> [PASS][76] +2 other tests pass
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_sequence@get-idle.html
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-434/igt@kms_sequence@get-idle.html
* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-dg2-set2: [TIMEOUT][77] ([Intel XE#1473] / [Intel XE#402]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@xe_evict@evict-beng-mixed-many-threads-small.html
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@xe_evict@evict-beng-mixed-many-threads-small.html
* igt@xe_exec_threads@threads-hang-fd-userptr-invalidate-race:
- shard-dg2-set2: [FAIL][79] ([Intel XE#1081]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@xe_exec_threads@threads-hang-fd-userptr-invalidate-race.html
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@xe_exec_threads@threads-hang-fd-userptr-invalidate-race.html
* igt@xe_live_ktest@xe_bo:
- shard-dg2-set2: [SKIP][81] ([Intel XE#1192] / [Intel XE#1201]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@xe_live_ktest@xe_bo.html
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@xe_live_ktest@xe_bo.html
* {igt@xe_pm@s3-vm-bind-unbind-all}:
- shard-dg2-set2: [DMESG-WARN][83] ([Intel XE#1162] / [Intel XE#1214]) -> [PASS][84] +1 other test pass
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@xe_pm@s3-vm-bind-unbind-all.html
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@xe_pm@s3-vm-bind-unbind-all.html
#### Warnings ####
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-dg2-set2: [SKIP][85] ([Intel XE#1201] / [Intel XE#316]) -> [SKIP][86] ([Intel XE#1201] / [Intel XE#829])
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-dg2-set2: [SKIP][87] ([Intel XE#1124] / [Intel XE#1201]) -> [SKIP][88] ([Intel XE#1201] / [Intel XE#829]) +2 other tests skip
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-435/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-dg2-set2: [SKIP][89] ([Intel XE#1201] / [Intel XE#829]) -> [SKIP][90] ([Intel XE#1124] / [Intel XE#1201]) +1 other test skip
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_bw@linear-tiling-4-displays-2560x1440p:
- shard-dg2-set2: [SKIP][91] ([Intel XE#1201]) -> [SKIP][92] ([Intel XE#1201] / [Intel XE#367])
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_bw@linear-tiling-4-displays-2560x1440p.html
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_bw@linear-tiling-4-displays-2560x1440p.html
* igt@kms_ccs@bad-aux-stride-y-tiled-ccs:
- shard-dg2-set2: [SKIP][93] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) -> [SKIP][94] ([Intel XE#1201] / [Intel XE#829]) +2 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_ccs@bad-aux-stride-y-tiled-ccs.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_ccs@bad-aux-stride-y-tiled-ccs.html
* igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc:
- shard-dg2-set2: [SKIP][95] ([Intel XE#1201] / [Intel XE#829]) -> [SKIP][96] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) +1 other test skip
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc.html
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm-disable:
- shard-dg2-set2: [SKIP][97] ([Intel XE#1201]) -> [SKIP][98] ([Intel XE#1201] / [Intel XE#373])
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_chamelium_hpd@hdmi-hpd-storm-disable.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_chamelium_hpd@hdmi-hpd-storm-disable.html
* igt@kms_chamelium_hpd@hdmi-hpd-with-enabled-mode:
- shard-dg2-set2: [SKIP][99] ([Intel XE#1201] / [Intel XE#373]) -> [SKIP][100] ([Intel XE#1201]) +1 other test skip
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-434/igt@kms_chamelium_hpd@hdmi-hpd-with-enabled-mode.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_chamelium_hpd@hdmi-hpd-with-enabled-mode.html
* igt@kms_chamelium_hpd@vga-hpd-with-enabled-mode:
- shard-dg2-set2: [SKIP][101] ([Intel XE#1201] / [Intel XE#1234]) -> [SKIP][102] ([Intel XE#1201] / [Intel XE#373])
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_chamelium_hpd@vga-hpd-with-enabled-mode.html
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_chamelium_hpd@vga-hpd-with-enabled-mode.html
* igt@kms_content_protection@srm:
- shard-dg2-set2: [FAIL][103] ([Intel XE#1178]) -> [SKIP][104] ([Intel XE#1201] / [Intel XE#455])
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_content_protection@srm.html
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_content_protection@srm.html
* igt@kms_content_protection@uevent:
- shard-dg2-set2: [FAIL][105] ([Intel XE#1188]) -> [SKIP][106] ([Intel XE#1201] / [Intel XE#1234])
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-434/igt@kms_content_protection@uevent.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_content_protection@uevent.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-dg2-set2: [DMESG-WARN][107] ([Intel XE#1214] / [Intel XE#282] / [Intel XE#910]) -> [SKIP][108] ([Intel XE#1201] / [Intel XE#1234])
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size:
- shard-dg2-set2: [SKIP][109] ([Intel XE#1201] / [Intel XE#323]) -> [SKIP][110] ([Intel XE#1201])
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@single-move:
- shard-dg2-set2: [DMESG-WARN][111] ([Intel XE#1214] / [Intel XE#282]) -> [DMESG-WARN][112] ([Intel XE#1214] / [Intel XE#282] / [Intel XE#877])
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_cursor_legacy@single-move.html
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_cursor_legacy@single-move.html
* igt@kms_feature_discovery@display-4x:
- shard-dg2-set2: [SKIP][113] ([Intel XE#1138] / [Intel XE#1201]) -> [SKIP][114] ([Intel XE#1201])
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_feature_discovery@display-4x.html
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_feature_discovery@display-4x.html
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-dg2-set2: [SKIP][115] ([Intel XE#1201] / [i915#5274]) -> [SKIP][116] ([Intel XE#1201])
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_force_connector_basic@prune-stale-modes.html
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-onoff:
- shard-dg2-set2: [SKIP][117] ([Intel XE#1201]) -> [SKIP][118] ([Intel XE#1201] / [Intel XE#651]) +2 other tests skip
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-onoff.html
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-cur-indfb-move:
- shard-dg2-set2: [SKIP][119] ([Intel XE#1201] / [Intel XE#651]) -> [SKIP][120] ([Intel XE#1201] / [Intel XE#1234])
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-cur-indfb-move.html
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbcdrrs-slowdraw:
- shard-dg2-set2: [SKIP][121] ([Intel XE#1201] / [Intel XE#651]) -> [SKIP][122] ([Intel XE#1201]) +6 other tests skip
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcdrrs-slowdraw.html
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcdrrs-slowdraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-render:
- shard-dg2-set2: [SKIP][123] ([Intel XE#1201] / [Intel XE#653]) -> [SKIP][124] ([Intel XE#1201] / [Intel XE#1234])
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-render.html
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff:
- shard-dg2-set2: [SKIP][125] ([Intel XE#1201] / [Intel XE#653]) -> [SKIP][126] ([Intel XE#1201]) +6 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_plane@pixel-format:
- shard-dg2-set2: [FAIL][127] ([Intel XE#650]) -> [SKIP][128] ([Intel XE#1201] / [Intel XE#829])
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-466/igt@kms_plane@pixel-format.html
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_plane@pixel-format.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers:
- shard-dg2-set2: [SKIP][129] ([Intel XE#1201]) -> [SKIP][130] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#498])
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers.html
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-modifiers.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format:
- shard-dg2-set2: [TIMEOUT][131] ([Intel XE#380] / [Intel XE#904] / [Intel XE#909]) -> [INCOMPLETE][132] ([Intel XE#1195] / [Intel XE#904] / [Intel XE#909])
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-435/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format.html
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format.html
* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-a-hdmi-a-6:
- shard-dg2-set2: [TIMEOUT][133] ([Intel XE#904] / [Intel XE#909]) -> [INCOMPLETE][134] ([Intel XE#1195] / [Intel XE#904] / [Intel XE#909])
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-435/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-a-hdmi-a-6.html
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_plane_scaling@plane-downscale-factor-0-5-with-pixel-format@pipe-a-hdmi-a-6.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format:
- shard-dg2-set2: [INCOMPLETE][135] ([Intel XE#1195] / [Intel XE#904] / [Intel XE#909]) -> [TIMEOUT][136] ([Intel XE#380] / [Intel XE#904] / [Intel XE#909])
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format.html
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format@pipe-a-hdmi-a-6:
- shard-dg2-set2: [INCOMPLETE][137] ([Intel XE#1195] / [Intel XE#904] / [Intel XE#909]) -> [TIMEOUT][138] ([Intel XE#904] / [Intel XE#909])
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-436/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format@pipe-a-hdmi-a-6.html
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-433/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format@pipe-a-hdmi-a-6.html
* igt@kms_pm_backlight@basic-brightness:
- shard-dg2-set2: [SKIP][139] ([Intel XE#1201] / [Intel XE#870]) -> [SKIP][140] ([Intel XE#1201])
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-464/igt@kms_pm_backlight@basic-brightness.html
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@fbc-psr2-cursor-render:
- shard-dg2-set2: [SKIP][141] ([Intel XE#1201] / [Intel XE#929]) -> [SKIP][142] ([Intel XE#1201]) +3 other tests skip
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_psr@fbc-psr2-cursor-render.html
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_psr@fbc-psr2-cursor-render.html
* igt@kms_psr@psr2-cursor-render:
- shard-dg2-set2: [SKIP][143] ([Intel XE#1201]) -> [SKIP][144] ([Intel XE#1201] / [Intel XE#929])
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_psr@psr2-cursor-render.html
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@kms_psr@psr2-cursor-render.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-dg2-set2: [SKIP][145] ([Intel XE#1201] / [Intel XE#327]) -> [SKIP][146] ([Intel XE#1201] / [Intel XE#829])
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-433/igt@kms_rotation_crc@bad-pixel-format.html
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-464/igt@kms_rotation_crc@bad-pixel-format.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-dg2-set2: [SKIP][147] ([Intel XE#1201] / [Intel XE#829]) -> [SKIP][148] ([Intel XE#1201] / [Intel XE#327])
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-466/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-dg2-set2: [SKIP][149] ([Intel XE#1201] / [Intel XE#362]) -> [FAIL][150] ([Intel XE#1729])
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern.html
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-dg2-set2: [SKIP][151] ([Intel XE#1201]) -> [SKIP][152] ([Intel XE#1201] / [Intel XE#362])
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
* igt@xe_evict@evict-beng-mixed-many-threads-large:
- shard-dg2-set2: [TIMEOUT][153] ([Intel XE#1041] / [Intel XE#1473] / [Intel XE#392]) -> [INCOMPLETE][154] ([Intel XE#1195] / [Intel XE#1473] / [Intel XE#392])
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-434/igt@xe_evict@evict-beng-mixed-many-threads-large.html
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-436/igt@xe_evict@evict-beng-mixed-many-threads-large.html
* igt@xe_evict@evict-mixed-threads-large:
- shard-dg2-set2: [TIMEOUT][155] ([Intel XE#1041] / [Intel XE#1473] / [Intel XE#392]) -> [TIMEOUT][156] ([Intel XE#1473] / [Intel XE#392])
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7827/shard-dg2-435/igt@xe_evict@evict-mixed-threads-large.html
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11087/shard-dg2-435/igt@xe_evict@evict-mixed-threads-large.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1041]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1041
[Intel XE#1043]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1043
[Intel XE#1081]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1081
[Intel XE#1122]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1122
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1138
[Intel XE#1152]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1152
[Intel XE#1162]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1162
[Intel XE#1174]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1174
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1188]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1188
[Intel XE#1192]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1192
[Intel XE#1195]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1195
[Intel XE#1201]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1201
[Intel XE#1214]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1214
[Intel XE#1234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1234
[Intel XE#1235]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1235
[Intel XE#1337]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1337
[Intel XE#1473]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1473
[Intel XE#1562]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1562
[Intel XE#1638]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1638
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#305]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/305
[Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#323]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/323
[Intel XE#327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/327
[Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/380
[Intel XE#392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/392
[Intel XE#402]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/402
[Intel XE#417]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/417
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#498]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/498
[Intel XE#581]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/581
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#650]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/650
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#703]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/703
[Intel XE#756]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/756
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#827]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/827
[Intel XE#829]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/829
[Intel XE#845]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/845
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#877]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/877
[Intel XE#904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/904
[Intel XE#909]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/909
[Intel XE#910]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/910
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#6077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6077
Build changes
-------------
* IGT: IGT_7827 -> IGTPW_11087
IGTPW_11087: 29b010aa4715d4c05e65e92b9862d2c45daf5256 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_7827: 973652fb579733234d1ecbc9304788153e462f11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-1213-3ac3efef3a1fc9d494b0a63c78bd0039a0b3d009: 3ac3efef3a1fc9d494b0a63c78bd0039a0b3d009
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-133106v1/index.html
[-- Attachment #2: Type: text/html, Size: 56989 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t] runner: Remove useless null check for delim in job_list_from_test_list
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
` (2 preceding siblings ...)
2024-05-01 4:37 ` ✗ CI.xeFULL: failure " Patchwork
@ 2024-05-07 17:13 ` Ngai-Mint Kwan
2024-05-17 21:32 ` Matt Roper
2024-05-10 17:37 ` [PATCH i-g-t] " Kamil Konieczny
4 siblings, 1 reply; 8+ messages in thread
From: Ngai-Mint Kwan @ 2024-05-07 17:13 UTC (permalink / raw
To: Gustavo Sousa, igt-dev
Hi Gustavo,
On 2024-04-30 14:19, Gustavo Sousa wrote:
> The function job_list_from_test_list() uses a while loop to read entries
> from the testlist.
>
> The condition ((delim = strchr(binary, '@')) != NULL) checks if the
> current entry specifies a subtest. When no subtest is specified, the
> else clause will cause a jump to the next iteration. That means that we
> are certain any statement executed after that if block has (delim !=
> NULL). As such, all null checks on that variable after that point are
> pointless.
>
> In fact, certain unnecessary null checks might even cause confusion to
> readers. One example is the block meant to display the "Unexpected test
> without subtests ..." message: it would never happen, since that
> condition is handled earlier in the iteration (i.e. the full set of
> subtests is expanded for that entry in the else clause previously
> mentioned). The following execution (done before this change)
> illustrates that:
>
> $ cat <<EOF > /tmp/foo.testlist
> igt@xe_pm@s2idle-basic
> igt@xe_pm
> igt@xe_pm@s2idle-exec-after
> EOF
>
> $ ./build/runner/igt_runner -d -m --test-list /tmp/foo.testlist build/tests /tmp/results
> [36408.109043] Dry run, not executing. Invoke igt_resume if you want to execute.
> Done.
>
> $ cat /tmp/results/joblist.txt | sed 's/^\(.\{50\}\).\+/\1.../'
> xe_pm s2idle-basic
> xe_pm s2idle-basic,s2idle-basic-exec,s2idle-exec-a...
> xe_pm s2idle-exec-after
>
> Let's remove those unnecessary checks.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Ngai-Mint Kwan <ngai-mint.kwan@linux.intel.com>
Thanks,
Ngai-Mint Kwan
> ---
> runner/job_list.c | 21 +++++----------------
> 1 file changed, 5 insertions(+), 16 deletions(-)
>
> diff --git a/runner/job_list.c b/runner/job_list.c
> index 27cbb10bce56..aeabb59f49d3 100644
> --- a/runner/job_list.c
> +++ b/runner/job_list.c
> @@ -276,16 +276,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
> * specified, also start a new entry.
> */
> if (entry.binary && !strcmp(entry.binary, binary) &&
> - (delim == NULL || strchr(delim, '@') == NULL)) {
> - if (!delim) {
> - /* ... except we didn't get a subtest */
> - fprintf(stderr,
> - "Error: Unexpected test without subtests "
> - "after same test had subtests\n");
> - free(binary);
> - fclose(f);
> - return false;
> - }
> + strchr(delim, '@') == NULL) {
> entry.subtest_count++;
> entry.subtests = realloc(entry.subtests,
> entry.subtest_count *
> @@ -303,7 +294,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
>
> memset(&entry, 0, sizeof(entry));
>
> - if (delim != NULL && strchr(delim, '@') != NULL) {
> + if (strchr(delim, '@') != NULL) {
> /* Dynamic subtest specified. Add to job list alone. */
> char **subtests;
>
> @@ -314,11 +305,9 @@ static bool job_list_from_test_list(struct job_list *job_list,
> any = true;
> } else {
> entry.binary = strdup(binary);
> - if (delim) {
> - entry.subtests = malloc(sizeof(*entry.subtests));
> - entry.subtests[0] = strdup(delim);
> - entry.subtest_count = 1;
> - }
> + entry.subtests = malloc(sizeof(*entry.subtests));
> + entry.subtests[0] = strdup(delim);
> + entry.subtest_count = 1;
> }
>
> free(binary);
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
` (3 preceding siblings ...)
2024-05-07 17:13 ` [i-g-t] " Ngai-Mint Kwan
@ 2024-05-10 17:37 ` Kamil Konieczny
2024-05-10 17:58 ` Gustavo Sousa
4 siblings, 1 reply; 8+ messages in thread
From: Kamil Konieczny @ 2024-05-10 17:37 UTC (permalink / raw
To: igt-dev; +Cc: Gustavo Sousa, Petri Latvala
Hi Gustavo,
On 2024-04-30 at 18:19:35 -0300, Gustavo Sousa wrote:
> The function job_list_from_test_list() uses a while loop to read entries
> from the testlist.
>
> The condition ((delim = strchr(binary, '@')) != NULL) checks if the
> current entry specifies a subtest. When no subtest is specified, the
> else clause will cause a jump to the next iteration. That means that we
> are certain any statement executed after that if block has (delim !=
> NULL). As such, all null checks on that variable after that point are
> pointless.
>
> In fact, certain unnecessary null checks might even cause confusion to
> readers. One example is the block meant to display the "Unexpected test
> without subtests ..." message: it would never happen, since that
> condition is handled earlier in the iteration (i.e. the full set of
> subtests is expanded for that entry in the else clause previously
> mentioned). The following execution (done before this change)
> illustrates that:
>
> $ cat <<EOF > /tmp/foo.testlist
> igt@xe_pm@s2idle-basic
> igt@xe_pm
> igt@xe_pm@s2idle-exec-after
> EOF
I do not know if 'igt@' was always used in tests lists.
Adding Petri to cc.
+Cc: Petri Latvala <adrinael@adrinael.net>
Regards,
Kamil
>
> $ ./build/runner/igt_runner -d -m --test-list /tmp/foo.testlist build/tests /tmp/results
> [36408.109043] Dry run, not executing. Invoke igt_resume if you want to execute.
> Done.
>
> $ cat /tmp/results/joblist.txt | sed 's/^\(.\{50\}\).\+/\1.../'
> xe_pm s2idle-basic
> xe_pm s2idle-basic,s2idle-basic-exec,s2idle-exec-a...
> xe_pm s2idle-exec-after
>
> Let's remove those unnecessary checks.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> runner/job_list.c | 21 +++++----------------
> 1 file changed, 5 insertions(+), 16 deletions(-)
>
> diff --git a/runner/job_list.c b/runner/job_list.c
> index 27cbb10bce56..aeabb59f49d3 100644
> --- a/runner/job_list.c
> +++ b/runner/job_list.c
> @@ -276,16 +276,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
> * specified, also start a new entry.
> */
> if (entry.binary && !strcmp(entry.binary, binary) &&
> - (delim == NULL || strchr(delim, '@') == NULL)) {
> - if (!delim) {
> - /* ... except we didn't get a subtest */
> - fprintf(stderr,
> - "Error: Unexpected test without subtests "
> - "after same test had subtests\n");
> - free(binary);
> - fclose(f);
> - return false;
> - }
> + strchr(delim, '@') == NULL) {
> entry.subtest_count++;
> entry.subtests = realloc(entry.subtests,
> entry.subtest_count *
> @@ -303,7 +294,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
>
> memset(&entry, 0, sizeof(entry));
>
> - if (delim != NULL && strchr(delim, '@') != NULL) {
> + if (strchr(delim, '@') != NULL) {
> /* Dynamic subtest specified. Add to job list alone. */
> char **subtests;
>
> @@ -314,11 +305,9 @@ static bool job_list_from_test_list(struct job_list *job_list,
> any = true;
> } else {
> entry.binary = strdup(binary);
> - if (delim) {
> - entry.subtests = malloc(sizeof(*entry.subtests));
> - entry.subtests[0] = strdup(delim);
> - entry.subtest_count = 1;
> - }
> + entry.subtests = malloc(sizeof(*entry.subtests));
> + entry.subtests[0] = strdup(delim);
> + entry.subtest_count = 1;
> }
>
> free(binary);
> --
> 2.44.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list
2024-05-10 17:37 ` [PATCH i-g-t] " Kamil Konieczny
@ 2024-05-10 17:58 ` Gustavo Sousa
0 siblings, 0 replies; 8+ messages in thread
From: Gustavo Sousa @ 2024-05-10 17:58 UTC (permalink / raw
To: Kamil Konieczny, igt-dev; +Cc: Petri Latvala
Quoting Kamil Konieczny (2024-05-10 14:37:26-03:00)
>Hi Gustavo,
>On 2024-04-30 at 18:19:35 -0300, Gustavo Sousa wrote:
>> The function job_list_from_test_list() uses a while loop to read entries
>> from the testlist.
>>
>> The condition ((delim = strchr(binary, '@')) != NULL) checks if the
>> current entry specifies a subtest. When no subtest is specified, the
>> else clause will cause a jump to the next iteration. That means that we
>> are certain any statement executed after that if block has (delim !=
>> NULL). As such, all null checks on that variable after that point are
>> pointless.
>>
>> In fact, certain unnecessary null checks might even cause confusion to
>> readers. One example is the block meant to display the "Unexpected test
>> without subtests ..." message: it would never happen, since that
>> condition is handled earlier in the iteration (i.e. the full set of
>> subtests is expanded for that entry in the else clause previously
>> mentioned). The following execution (done before this change)
>> illustrates that:
>>
>> $ cat <<EOF > /tmp/foo.testlist
>> igt@xe_pm@s2idle-basic
>> igt@xe_pm
>> igt@xe_pm@s2idle-exec-after
>> EOF
>
>I do not know if 'igt@' was always used in tests lists.
Hm... Not sure I get the point here.
Regardless, (delim == NULL) is an impossible condition at the points
this patch is touching, no?
>Adding Petri to cc.
>+Cc: Petri Latvala <adrinael@adrinael.net>
Thanks!
--
Gustavo Sousa
>
>Regards,
>Kamil
>
>>
>> $ ./build/runner/igt_runner -d -m --test-list /tmp/foo.testlist build/tests /tmp/results
>> [36408.109043] Dry run, not executing. Invoke igt_resume if you want to execute.
>> Done.
>>
>> $ cat /tmp/results/joblist.txt | sed 's/^\(.\{50\}\).\+/\1.../'
>> xe_pm s2idle-basic
>> xe_pm s2idle-basic,s2idle-basic-exec,s2idle-exec-a...
>> xe_pm s2idle-exec-after
>>
>> Let's remove those unnecessary checks.
>>
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>> ---
>> runner/job_list.c | 21 +++++----------------
>> 1 file changed, 5 insertions(+), 16 deletions(-)
>>
>> diff --git a/runner/job_list.c b/runner/job_list.c
>> index 27cbb10bce56..aeabb59f49d3 100644
>> --- a/runner/job_list.c
>> +++ b/runner/job_list.c
>> @@ -276,16 +276,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
>> * specified, also start a new entry.
>> */
>> if (entry.binary && !strcmp(entry.binary, binary) &&
>> - (delim == NULL || strchr(delim, '@') == NULL)) {
>> - if (!delim) {
>> - /* ... except we didn't get a subtest */
>> - fprintf(stderr,
>> - "Error: Unexpected test without subtests "
>> - "after same test had subtests\n");
>> - free(binary);
>> - fclose(f);
>> - return false;
>> - }
>> + strchr(delim, '@') == NULL) {
>> entry.subtest_count++;
>> entry.subtests = realloc(entry.subtests,
>> entry.subtest_count *
>> @@ -303,7 +294,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
>>
>> memset(&entry, 0, sizeof(entry));
>>
>> - if (delim != NULL && strchr(delim, '@') != NULL) {
>> + if (strchr(delim, '@') != NULL) {
>> /* Dynamic subtest specified. Add to job list alone. */
>> char **subtests;
>>
>> @@ -314,11 +305,9 @@ static bool job_list_from_test_list(struct job_list *job_list,
>> any = true;
>> } else {
>> entry.binary = strdup(binary);
>> - if (delim) {
>> - entry.subtests = malloc(sizeof(*entry.subtests));
>> - entry.subtests[0] = strdup(delim);
>> - entry.subtest_count = 1;
>> - }
>> + entry.subtests = malloc(sizeof(*entry.subtests));
>> + entry.subtests[0] = strdup(delim);
>> + entry.subtest_count = 1;
>> }
>>
>> free(binary);
>> --
>> 2.44.0
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t] runner: Remove useless null check for delim in job_list_from_test_list
2024-05-07 17:13 ` [i-g-t] " Ngai-Mint Kwan
@ 2024-05-17 21:32 ` Matt Roper
0 siblings, 0 replies; 8+ messages in thread
From: Matt Roper @ 2024-05-17 21:32 UTC (permalink / raw
To: Ngai-Mint Kwan; +Cc: Gustavo Sousa, igt-dev
On Tue, May 07, 2024 at 10:13:45AM -0700, Ngai-Mint Kwan wrote:
> Hi Gustavo,
>
> On 2024-04-30 14:19, Gustavo Sousa wrote:
> > The function job_list_from_test_list() uses a while loop to read entries
> > from the testlist.
> >
> > The condition ((delim = strchr(binary, '@')) != NULL) checks if the
> > current entry specifies a subtest. When no subtest is specified, the
> > else clause will cause a jump to the next iteration. That means that we
> > are certain any statement executed after that if block has (delim !=
> > NULL). As such, all null checks on that variable after that point are
> > pointless.
> >
> > In fact, certain unnecessary null checks might even cause confusion to
> > readers. One example is the block meant to display the "Unexpected test
> > without subtests ..." message: it would never happen, since that
> > condition is handled earlier in the iteration (i.e. the full set of
> > subtests is expanded for that entry in the else clause previously
> > mentioned). The following execution (done before this change)
> > illustrates that:
> >
> > $ cat <<EOF > /tmp/foo.testlist
> > igt@xe_pm@s2idle-basic
> > igt@xe_pm
> > igt@xe_pm@s2idle-exec-after
> > EOF
> >
> > $ ./build/runner/igt_runner -d -m --test-list /tmp/foo.testlist build/tests /tmp/results
> > [36408.109043] Dry run, not executing. Invoke igt_resume if you want to execute.
> > Done.
> >
> > $ cat /tmp/results/joblist.txt | sed 's/^\(.\{50\}\).\+/\1.../'
> > xe_pm s2idle-basic
> > xe_pm s2idle-basic,s2idle-basic-exec,s2idle-exec-a...
> > xe_pm s2idle-exec-after
> >
> > Let's remove those unnecessary checks.
> >
> > Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>
> Reviewed-by: Ngai-Mint Kwan <ngai-mint.kwan@linux.intel.com>
>
> Thanks,
> Ngai-Mint Kwan
Applied, thanks for the patch and review.
Matt
>
> > ---
> > runner/job_list.c | 21 +++++----------------
> > 1 file changed, 5 insertions(+), 16 deletions(-)
> >
> > diff --git a/runner/job_list.c b/runner/job_list.c
> > index 27cbb10bce56..aeabb59f49d3 100644
> > --- a/runner/job_list.c
> > +++ b/runner/job_list.c
> > @@ -276,16 +276,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
> > * specified, also start a new entry.
> > */
> > if (entry.binary && !strcmp(entry.binary, binary) &&
> > - (delim == NULL || strchr(delim, '@') == NULL)) {
> > - if (!delim) {
> > - /* ... except we didn't get a subtest */
> > - fprintf(stderr,
> > - "Error: Unexpected test without subtests "
> > - "after same test had subtests\n");
> > - free(binary);
> > - fclose(f);
> > - return false;
> > - }
> > + strchr(delim, '@') == NULL) {
> > entry.subtest_count++;
> > entry.subtests = realloc(entry.subtests,
> > entry.subtest_count *
> > @@ -303,7 +294,7 @@ static bool job_list_from_test_list(struct job_list *job_list,
> > memset(&entry, 0, sizeof(entry));
> > - if (delim != NULL && strchr(delim, '@') != NULL) {
> > + if (strchr(delim, '@') != NULL) {
> > /* Dynamic subtest specified. Add to job list alone. */
> > char **subtests;
> > @@ -314,11 +305,9 @@ static bool job_list_from_test_list(struct job_list *job_list,
> > any = true;
> > } else {
> > entry.binary = strdup(binary);
> > - if (delim) {
> > - entry.subtests = malloc(sizeof(*entry.subtests));
> > - entry.subtests[0] = strdup(delim);
> > - entry.subtest_count = 1;
> > - }
> > + entry.subtests = malloc(sizeof(*entry.subtests));
> > + entry.subtests[0] = strdup(delim);
> > + entry.subtest_count = 1;
> > }
> > free(binary);
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-17 21:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 21:19 [PATCH i-g-t] runner: Remove useless null check for delim in job_list_from_test_list Gustavo Sousa
2024-04-30 22:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-04-30 22:15 ` ✓ CI.xeBAT: success " Patchwork
2024-05-01 4:37 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-07 17:13 ` [i-g-t] " Ngai-Mint Kwan
2024-05-17 21:32 ` Matt Roper
2024-05-10 17:37 ` [PATCH i-g-t] " Kamil Konieczny
2024-05-10 17:58 ` Gustavo Sousa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.