From: kangyang <quic_kangyang@quicinc.com>
To: <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <quic_kangyang@quicinc.com>
Subject: [PATCH 5/5] wifi: ath12k: remove invalid peer create logic
Date: Mon, 29 Apr 2024 16:15:25 +0800 [thread overview]
Message-ID: <20240429081525.983-6-quic_kangyang@quicinc.com> (raw)
In-Reply-To: <20240429081525.983-1-quic_kangyang@quicinc.com>
From: Kang Yang <quic_kangyang@quicinc.com>
In ath12k_mac_op_assign_vif_chanctx(), there is a logic to
create peer using ar->mac_addr for a STA vdev. This is invalid
because a STA vdev should have a peer created using AP's
MAC address. Besides, if we run into that logic, it means a peer
has already been created earlier, we should not create it again.
So remove it.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index f994a78e7dc5..be961de26c6d 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7242,7 +7242,6 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw,
struct ath12k_base *ab;
struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif);
int ret;
- struct ath12k_wmi_peer_create_arg param;
/* For multi radio wiphy, the vdev was not created during add_interface
* create now since we have a channel ctx now to assign to a specific ar/fw
@@ -7278,21 +7277,6 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw,
goto out;
}
- if (ab->hw_params->vdev_start_delay &&
- arvif->vdev_type != WMI_VDEV_TYPE_AP &&
- arvif->vdev_type != WMI_VDEV_TYPE_MONITOR) {
- param.vdev_id = arvif->vdev_id;
- param.peer_type = WMI_PEER_TYPE_DEFAULT;
- param.peer_addr = ar->mac_addr;
-
- ret = ath12k_peer_create(ar, arvif, NULL, ¶m);
- if (ret) {
- ath12k_warn(ab, "failed to create peer after vdev start delay: %d",
- ret);
- goto out;
- }
- }
-
if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) {
ret = ath12k_mac_monitor_start(ar);
if (ret)
--
2.34.1
next prev parent reply other threads:[~2024-04-29 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:15 [PATCH 0/5] prepare work for monitor mode on WCN7850 kangyang
2024-04-29 8:15 ` [PATCH 1/5] wifi: ath12k: remove unused variable monitor_flags kangyang
2024-04-30 1:49 ` Jeff Johnson
2024-05-07 10:18 ` Kalle Valo
2024-04-29 8:15 ` [PATCH 2/5] wifi: ath12k: avoid duplicated vdev stop kangyang
2024-04-30 1:51 ` Jeff Johnson
2024-04-29 8:15 ` [PATCH 3/5] wifi: ath12k: avoid duplicated vdev down kangyang
2024-04-30 1:52 ` Jeff Johnson
2024-04-29 8:15 ` [PATCH 4/5] wifi: ath12k: remove redundant peer delete kangyang
2024-04-30 1:53 ` Jeff Johnson
2024-05-07 10:20 ` Kalle Valo
2024-05-07 11:20 ` Kang Yang
2024-04-29 8:15 ` kangyang [this message]
2024-04-30 1:55 ` [PATCH 5/5] wifi: ath12k: remove invalid peer create logic Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429081525.983-6-quic_kangyang@quicinc.com \
--to=quic_kangyang@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.