From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Subject: Re: [tip: x86/cpu] x86/mce: Switch to new Intel CPU model defines
Date: Sun, 28 Apr 2024 20:31:42 +0200 [thread overview]
Message-ID: <20240428183142.GHZi6WDu5nbmJJ_BcH@fat_crate.local> (raw)
In-Reply-To: <171415513118.10875.11391783217612357854.tip-bot2@tip-bot2>
On Fri, Apr 26, 2024 at 06:12:11PM -0000, tip-bot2 for Tony Luck wrote:
> @@ -398,7 +398,7 @@ static noinstr int mce_severity_intel(struct mce *m, struct pt_regs *regs, char
> continue;
> if (s->excp && excp != s->excp)
> continue;
> - if (s->cpu_model && boot_cpu_data.x86_model != s->cpu_model)
> + if (s->cpu_vfm && boot_cpu_data.x86_model != s->cpu_vfm)
Hold on, isn't this supposed to be:
if (s->cpu_vfm && boot_cpu_data.cpu_vfm != s->cpu_vfm)
?
You're getting rid of the ->x86_model checking altogether...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-04-28 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 18:12 [tip: x86/cpu] x86/mce: Switch to new Intel CPU model defines tip-bot2 for Tony Luck
2024-04-28 18:31 ` Borislav Petkov [this message]
2024-04-29 2:20 ` [PATCH] x86/cpu: Fix thinko comparing x86_vfm with x86_model Tony Luck
2024-04-29 8:22 ` Borislav Petkov
2024-04-29 16:05 ` Luck, Tony
2024-04-29 22:10 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 18:12 [tip: x86/cpu] x86/mce: Switch to new Intel CPU model defines tip-bot2 for Tony Luck
2024-04-26 18:12 tip-bot2 for Tony Luck
2024-04-29 9:01 tip-bot2 for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240428183142.GHZi6WDu5nbmJJ_BcH@fat_crate.local \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.