From: Jens Wiklander <jens.wiklander@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: patches@linaro.org, Jens Wiklander <jens.wiklander@linaro.org>,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>
Subject: [XEN PATCH v3 1/5] xen/arm: ffa: refactor ffa_handle_call()
Date: Fri, 26 Apr 2024 10:47:19 +0200 [thread overview]
Message-ID: <20240426084723.4149648-2-jens.wiklander@linaro.org> (raw)
In-Reply-To: <20240426084723.4149648-1-jens.wiklander@linaro.org>
Refactors the large switch block in ffa_handle_call() to use common code
for the simple case where it's either an error code or success with no
further parameters.
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
xen/arch/arm/tee/ffa.c | 30 ++++++++++--------------------
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
index 8665201e34a9..5209612963e1 100644
--- a/xen/arch/arm/tee/ffa.c
+++ b/xen/arch/arm/tee/ffa.c
@@ -273,18 +273,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs)
case FFA_RXTX_MAP_64:
e = ffa_handle_rxtx_map(fid, get_user_reg(regs, 1),
get_user_reg(regs, 2), get_user_reg(regs, 3));
- if ( e )
- ffa_set_regs_error(regs, e);
- else
- ffa_set_regs_success(regs, 0, 0);
- return true;
+ break;
case FFA_RXTX_UNMAP:
e = ffa_handle_rxtx_unmap();
- if ( e )
- ffa_set_regs_error(regs, e);
- else
- ffa_set_regs_success(regs, 0, 0);
- return true;
+ break;
case FFA_PARTITION_INFO_GET:
e = ffa_handle_partition_info_get(get_user_reg(regs, 1),
get_user_reg(regs, 2),
@@ -299,11 +291,7 @@ static bool ffa_handle_call(struct cpu_user_regs *regs)
return true;
case FFA_RX_RELEASE:
e = ffa_handle_rx_release();
- if ( e )
- ffa_set_regs_error(regs, e);
- else
- ffa_set_regs_success(regs, 0, 0);
- return true;
+ break;
case FFA_MSG_SEND_DIRECT_REQ_32:
case FFA_MSG_SEND_DIRECT_REQ_64:
handle_msg_send_direct_req(regs, fid);
@@ -316,17 +304,19 @@ static bool ffa_handle_call(struct cpu_user_regs *regs)
e = ffa_handle_mem_reclaim(regpair_to_uint64(get_user_reg(regs, 2),
get_user_reg(regs, 1)),
get_user_reg(regs, 3));
- if ( e )
- ffa_set_regs_error(regs, e);
- else
- ffa_set_regs_success(regs, 0, 0);
- return true;
+ break;
default:
gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid);
ffa_set_regs_error(regs, FFA_RET_NOT_SUPPORTED);
return true;
}
+
+ if ( e )
+ ffa_set_regs_error(regs, e);
+ else
+ ffa_set_regs_success(regs, 0, 0);
+ return true;
}
static int ffa_domain_init(struct domain *d)
--
2.34.1
next prev parent reply other threads:[~2024-04-26 8:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 8:47 [XEN PATCH v3 0/5] FF-A notifications Jens Wiklander
2024-04-26 8:47 ` Jens Wiklander [this message]
2024-04-26 8:47 ` [XEN PATCH v3 2/5] xen/arm: ffa: use ACCESS_ONCE() Jens Wiklander
2024-04-26 8:47 ` [XEN PATCH v3 3/5] xen/arm: ffa: simplify ffa_handle_mem_share() Jens Wiklander
2024-04-26 8:47 ` [XEN PATCH v3 4/5] xen/arm: allow dynamically assigned SGI handlers Jens Wiklander
2024-04-26 8:47 ` [XEN PATCH v3 5/5] xen/arm: ffa: support notification Jens Wiklander
2024-04-26 9:20 ` Bertrand Marquis
2024-04-26 12:11 ` Jens Wiklander
2024-04-26 12:19 ` Bertrand Marquis
2024-04-26 12:32 ` Jens Wiklander
2024-04-26 12:41 ` Bertrand Marquis
2024-04-26 13:02 ` Jens Wiklander
2024-04-26 15:12 ` Bertrand Marquis
2024-04-26 18:31 ` Julien Grall
2024-04-26 17:58 ` Julien Grall
2024-04-29 9:55 ` Jens Wiklander
2024-04-26 19:07 ` Julien Grall
2024-04-29 7:20 ` Bertrand Marquis
2024-04-29 9:49 ` Jens Wiklander
2024-04-29 20:55 ` Julien Grall
2024-04-29 8:43 ` Jens Wiklander
2024-04-26 9:23 ` [XEN PATCH v3 0/5] FF-A notifications Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426084723.4149648-2-jens.wiklander@linaro.org \
--to=jens.wiklander@linaro.org \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=patches@linaro.org \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.