From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, stable@dpdk.org,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: [PATCH] ethdev: document that stats reset APIs are not thread-safe
Date: Thu, 25 Apr 2024 17:53:08 +0100 [thread overview]
Message-ID: <20240425165308.1078454-1-ferruh.yigit@amd.com> (raw)
Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread
safe has performance impact on datapath.
Instead document APIs as not thread safe and add condition for reliable
stats reset functionality, forwarding should be stopped.
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: Morten Brørup <mb@smartsharesystems.com>
This update triggered by mail list discussion [1].
[1]
https://inbox.dpdk.org/dev/3b2cf48e-2293-4226-b6cd-5f4dd3969f99@lysator.liu.se/
---
lib/ethdev/rte_ethdev.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 548fada1c7ad..40f04c0e191b 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3136,6 +3136,9 @@ int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats);
/**
* Reset the general I/O statistics of an Ethernet device.
*
+ * API is not multi-thread safe.
+ * Application should stop forwarding before calling this API.
+ *
* @param port_id
* The port identifier of the Ethernet device.
* @return
@@ -3296,6 +3299,9 @@ int rte_eth_xstats_get_id_by_name(uint16_t port_id, const char *xstat_name,
/**
* Reset extended statistics of an Ethernet device.
*
+ * API is not multi-thread safe.
+ * Application should stop forwarding before calling this API.
+ *
* @param port_id
* The port identifier of the Ethernet device.
* @return
--
2.34.1
next reply other threads:[~2024-04-25 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 16:53 Ferruh Yigit [this message]
2024-04-26 12:20 ` [PATCH] ethdev: document that stats reset APIs are not thread-safe Morten Brørup
2024-04-26 15:13 ` Stephen Hemminger
2024-04-26 15:17 ` Morten Brørup
2024-04-26 22:57 ` Stephen Hemminger
2024-04-28 15:52 ` Mattias Rönnblom
2024-04-29 6:20 ` Morten Brørup
2024-04-29 15:33 ` Stephen Hemminger
2024-04-28 15:48 ` Mattias Rönnblom
2024-04-29 7:57 ` Morten Brørup
2024-04-29 9:30 ` Mattias Rönnblom
2024-04-26 21:33 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425165308.1078454-1-ferruh.yigit@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.