From: John Stultz via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com, John Stultz <jstultz@google.com>,
Darren Hart <darren@os.amperecomputing.com>
Subject: [LTP] [PATCH 1/6] sched_football: Drop use of sched_yeild()
Date: Tue, 23 Apr 2024 15:57:58 -0700 [thread overview]
Message-ID: <20240423225821.4003538-2-jstultz@google.com> (raw)
In-Reply-To: <20240423225821.4003538-1-jstultz@google.com>
sched_yeild() just causes the SCHED_FIFO tasks to behave like
SCHED_RR which makes analysis of the behavior more difficult to
follow. So lets drop the calls.
Also fixes up some whitespace inconsistencies in the header comment.
Cc: kernel-team@android.com
Cc: Darren Hart <darren@os.amperecomputing.com>
Signed-off-by: John Stultz <jstultz@google.com>
---
| 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--git a/testcases/realtime/func/sched_football/sched_football.c b/testcases/realtime/func/sched_football/sched_football.c
index 6f075aea3..1e205219d 100644
--- a/testcases/realtime/func/sched_football/sched_football.c
+++ b/testcases/realtime/func/sched_football/sched_football.c
@@ -32,12 +32,12 @@
* - Create a fixed number of offense threads (lower priority)
* - Create a referee thread (highest priority)
* - Once everyone is on the field, the offense thread increments the
- * value of 'the_ball' and yields. The defense thread tries to block
- * the ball by never letting the offense players get the CPU (it just
- * does a sched_yield).
+ * value of 'the_ball'. The defense thread tries to block
+ * the ball by never letting the offense players get the CPU (it just
+ * spins).
* - The refree threads wakes up regularly to check if the game is over :)
* - In the end, if the value of 'the_ball' is >0, the test is considered
- * to have failed.
+ * to have failed.
*
* USAGE:
* Use run_auto.sh script in current directory to build and run test.
@@ -113,7 +113,6 @@ void *thread_defense(void *arg)
atomic_inc(&players_ready);
/*keep the ball from being moved */
while (1) {
- sched_yield(); /* let other defenders run */
}
return NULL;
}
@@ -124,7 +123,6 @@ void *thread_offense(void *arg)
atomic_inc(&players_ready);
while (1) {
the_ball++; /* move the ball ahead one yard */
- sched_yield(); /* let other offensive players run */
}
return NULL;
}
--
2.44.0.769.g3c40516874-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-04-24 12:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 22:57 [LTP] [PATCH 0/6] sched_football: Re-add crazy fans and other cleanups John Stultz via ltp
2024-04-23 22:57 ` John Stultz via ltp [this message]
2024-04-23 22:57 ` [LTP] [PATCH 2/6] sched_football: Use atomic for ball John Stultz via ltp
2024-04-29 9:06 ` Cyril Hrubis
2024-04-29 22:56 ` John Stultz via ltp
2024-05-07 9:35 ` Cyril Hrubis
2024-04-23 22:58 ` [LTP] [PATCH 3/6] sched_football: Re-add the crazy fans to interrupt everyone John Stultz via ltp
2024-04-29 9:10 ` Cyril Hrubis
2024-04-29 23:06 ` John Stultz via ltp
2024-04-23 22:58 ` [LTP] [PATCH 4/6] sched_football: Add a sleep before the game begins to get into steady state John Stultz via ltp
2024-04-23 22:58 ` [LTP] [PATCH 5/6] sched_football: Add prctrl calls to set thread comms John Stultz via ltp
2024-04-23 22:58 ` [LTP] [PATCH 6/6] sched_football: Add trace_marker messages if we're tracing John Stultz via ltp
2024-04-29 9:17 ` Cyril Hrubis
2024-04-29 23:14 ` John Stultz via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423225821.4003538-2-jstultz@google.com \
--to=ltp@lists.linux.it \
--cc=darren@os.amperecomputing.com \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.