* [PATCH v2] drm/amdgpu/mes: fix use-after-free issue
@ 2024-04-22 9:39 Jack Xiao
2024-04-22 11:12 ` Lazar, Lijo
0 siblings, 1 reply; 3+ messages in thread
From: Jack Xiao @ 2024-04-22 9:39 UTC (permalink / raw
To: amd-gfx, Alexander.Deucher, Hawking.Zhang, Christian.Koenig,
lijo.lazar
Cc: Jack Xiao
Delete fence fallback timer to fix the ramdom
use-after-free issue.
v2: move to amdgpu_mes.c
Signed-off-by: Jack Xiao <Jack.Xiao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
index 78e4f88f5134..226751ea084b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
@@ -1128,6 +1128,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,
return;
amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);
+ del_timer_sync(&ring->fence_drv.fallback_timer);
amdgpu_ring_fini(ring);
kfree(ring);
}
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/amdgpu/mes: fix use-after-free issue
2024-04-22 9:39 [PATCH v2] drm/amdgpu/mes: fix use-after-free issue Jack Xiao
@ 2024-04-22 11:12 ` Lazar, Lijo
2024-04-22 11:30 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Lazar, Lijo @ 2024-04-22 11:12 UTC (permalink / raw
To: Jack Xiao, amd-gfx, Alexander.Deucher, Hawking.Zhang,
Christian.Koenig
On 4/22/2024 3:09 PM, Jack Xiao wrote:
> Delete fence fallback timer to fix the ramdom
> use-after-free issue.
>
> v2: move to amdgpu_mes.c
>
> Signed-off-by: Jack Xiao <Jack.Xiao@amd.com>
Acked-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> index 78e4f88f5134..226751ea084b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
> @@ -1128,6 +1128,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,
> return;
>
> amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);
> + del_timer_sync(&ring->fence_drv.fallback_timer);
> amdgpu_ring_fini(ring);
> kfree(ring);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/amdgpu/mes: fix use-after-free issue
2024-04-22 11:12 ` Lazar, Lijo
@ 2024-04-22 11:30 ` Christian König
0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2024-04-22 11:30 UTC (permalink / raw
To: Lazar, Lijo, Jack Xiao, amd-gfx, Alexander.Deucher, Hawking.Zhang
Am 22.04.24 um 13:12 schrieb Lazar, Lijo:
>
> On 4/22/2024 3:09 PM, Jack Xiao wrote:
>> Delete fence fallback timer to fix the ramdom
>> use-after-free issue.
>>
>> v2: move to amdgpu_mes.c
>>
>> Signed-off-by: Jack Xiao <Jack.Xiao@amd.com>
> Acked-by: Lijo Lazar <lijo.lazar@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
>
> Thanks,
> Lijo
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
>> index 78e4f88f5134..226751ea084b 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
>> @@ -1128,6 +1128,7 @@ void amdgpu_mes_remove_ring(struct amdgpu_device *adev,
>> return;
>>
>> amdgpu_mes_remove_hw_queue(adev, ring->hw_queue_id);
>> + del_timer_sync(&ring->fence_drv.fallback_timer);
>> amdgpu_ring_fini(ring);
>> kfree(ring);
>> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22 9:39 [PATCH v2] drm/amdgpu/mes: fix use-after-free issue Jack Xiao
2024-04-22 11:12 ` Lazar, Lijo
2024-04-22 11:30 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.