All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
@ 2024-04-22  6:08 Xuxin Xiong
  2024-04-22 14:10 ` Doug Anderson
  0 siblings, 1 reply; 9+ messages in thread
From: Xuxin Xiong @ 2024-04-22  6:08 UTC (permalink / raw
  To: sam, neil.armstrong, daniel, dianders, hsinyi
  Cc: dri-devel, devicetree, linux-kernel, Xuxin Xiong

Add support for the following panel:
CSOT MNB601LS1-1

Signed-off-by: Xuxin Xiong <xuxinxiong@huaqin.corp-partner.google.com>
---
 drivers/gpu/drm/panel/panel-edp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index d58f90bc48fb..5e0b1c94bc62 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -2036,6 +2036,8 @@ static const struct edp_panel_entry edp_panels[] = {
 
 	EDP_PANEL_ENTRY('C', 'S', 'O', 0x1200, &delay_200_500_e50, "MNC207QS1-1"),
 
+	EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50, "MNB601LS1-1"),
+
 	EDP_PANEL_ENTRY('H', 'K', 'C', 0x2d51, &delay_200_500_e200, "Unknown"),
 	EDP_PANEL_ENTRY('H', 'K', 'C', 0x2d5b, &delay_200_500_e200, "Unknown"),
 	EDP_PANEL_ENTRY('H', 'K', 'C', 0x2d5c, &delay_200_500_e200, "MB116AN01-2"),
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-04-22  6:08 [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1 Xuxin Xiong
@ 2024-04-22 14:10 ` Doug Anderson
  2024-04-23  1:28   ` Xuxin Xiong
  0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2024-04-22 14:10 UTC (permalink / raw
  To: Xuxin Xiong
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi,

On Sun, Apr 21, 2024 at 11:09 PM Xuxin Xiong
<xuxinxiong@huaqin.corp-partner.google.com> wrote:
>
> Add support for the following panel:
> CSOT MNB601LS1-1
>
> Signed-off-by: Xuxin Xiong <xuxinxiong@huaqin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index d58f90bc48fb..5e0b1c94bc62 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -2036,6 +2036,8 @@ static const struct edp_panel_entry edp_panels[] = {
>
>         EDP_PANEL_ENTRY('C', 'S', 'O', 0x1200, &delay_200_500_e50, "MNC207QS1-1"),
>
> +       EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50, "MNB601LS1-1"),

Are you positive that both this panel and the one above it (which you
also added) are correct? You identified both of them as CSO panels but
one has "CSO" and one has "CSW". Please double-check and let me know.

-Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-04-22 14:10 ` Doug Anderson
@ 2024-04-23  1:28   ` Xuxin Xiong
  2024-04-23 17:01     ` Doug Anderson
  0 siblings, 1 reply; 9+ messages in thread
From: Xuxin Xiong @ 2024-04-23  1:28 UTC (permalink / raw
  To: Doug Anderson
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 4247 bytes --]

Yes, I read the edid from the panels, one is CSO and the other is CSW.
The details are as follows, please help check. Thank you!


1. MNC207QS1-1
edid-decode (hex):
00 ff ff ff ff ff ff 00 0e 6f 00 12 e7 00 00 00
1e 21 01 04 a5 1b 12 78 03 8a d5 9c 5e 59 90 25
1b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 ae 3f 80 18 71 b0 23 40 30 20
36 00 07 a4 10 00 00 1a 00 00 00 fd 00 28 3c 4b
4b 11 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
00 4d 4e 43 32 30 37 51 53 31 2d 31 0a 20 00 32
----------------
Block 0, Base EDID:
EDID Structure Version & Revision: 1.4
Vendor & Product Identification:
Manufacturer: CSO
Model: 4608
Serial Number: 231
Made in: week 30 of 2023
Basic Display Parameters & Features:
Digital display
Bits per primary color channel: 8
DisplayPort interface
Maximum image size: 27 cm x 18 cm
Gamma: 2.20
Supported color formats: RGB 4:4:4
First detailed timing includes the native pixel format and preferred
refresh rate
Display is continuous frequency
Color Characteristics:
Red : 0.6113, 0.3671
Green: 0.3496, 0.5644
Blue : 0.1474, 0.1064
White: 0.3134, 0.3291
Established Timings I & II: none
Standard Timings: none
Detailed Timing Descriptors:
DTD 1: 1920x1200 60.000 Hz 8:5 74.100 kHz 163.020 MHz (263 mm x 164 mm)
Hfront 48 Hsync 32 Hback 200 Hpol P
Vfront 3 Vsync 6 Vback 26 Vpol N
Display Range Limits:
Monitor ranges (Bare Limits): 40-60 Hz V, 75-75 kHz H, max dotclock 170 MHz
Alphanumeric Data String: 'CSOT T9'
Alphanumeric Data String: 'MNC207QS1-1'
Checksum: 0x32

2. MNB601LS1-1
edid-decode (hex):

00 ff ff ff ff ff ff 00 0e 77 00 11 00 00 00 00
00 22 01 04 95 1a 0e 78 03 a1 35 9b 5e 58 91 25
1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 09 1e 56 dc 50 00 28 30 30 20
36 00 00 90 10 00 00 1a 00 00 00 fd 00 28 3c 30
30 08 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
00 4d 4e 42 36 30 31 4c 53 31 2d 31 0a 20 00 37
----------------
Block 0, Base EDID:
EDID Structure Version & Revision: 1.4
Vendor & Product Identification:
Manufacturer: CSW
Model: 4352
Made in: 2024
Basic Display Parameters & Features:
Digital display
Bits per primary color channel: 6
DisplayPort interface
Maximum image size: 26 cm x 14 cm
Gamma: 2.20
Supported color formats: RGB 4:4:4
First detailed timing includes the native pixel format and preferred
refresh rate
Display is continuous frequency
Color Characteristics:
Red : 0.6074, 0.3691
Green: 0.3437, 0.5673
Blue : 0.1445, 0.1123
White: 0.3134, 0.3291
Established Timings I & II: none
Standard Timings: none
Detailed Timing Descriptors:
DTD 1: 1366x768 60.001 Hz 683:384 48.480 kHz 76.890 MHz (256 mm x 144 mm)
Hfront 48 Hsync 32 Hback 140 Hpol P
Vfront 3 Vsync 6 Vback 31 Vpol N
Display Range Limits:
Monitor ranges (Bare Limits): 40-60 Hz V, 48-48 kHz H, max dotclock 80 MHz
Alphanumeric Data String: 'CSOT T9'
Alphanumeric Data String: 'MNB601LS1-1'
Checksum: 0x37

Doug Anderson <dianders@chromium.org> 于2024年4月22日周一 22:10写道:

> Hi,
>
> On Sun, Apr 21, 2024 at 11:09 PM Xuxin Xiong
> <xuxinxiong@huaqin.corp-partner.google.com> wrote:
> >
> > Add support for the following panel:
> > CSOT MNB601LS1-1
> >
> > Signed-off-by: Xuxin Xiong <xuxinxiong@huaqin.corp-partner.google.com>
> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-edp.c
> b/drivers/gpu/drm/panel/panel-edp.c
> > index d58f90bc48fb..5e0b1c94bc62 100644
> > --- a/drivers/gpu/drm/panel/panel-edp.c
> > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > @@ -2036,6 +2036,8 @@ static const struct edp_panel_entry edp_panels[] =
> {
> >
> >         EDP_PANEL_ENTRY('C', 'S', 'O', 0x1200, &delay_200_500_e50,
> "MNC207QS1-1"),
> >
> > +       EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50,
> "MNB601LS1-1"),
>
> Are you positive that both this panel and the one above it (which you
> also added) are correct? You identified both of them as CSO panels but
> one has "CSO" and one has "CSW". Please double-check and let me know.
>
> -Doug
>

[-- Attachment #2: Type: text/html, Size: 8567 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-04-23  1:28   ` Xuxin Xiong
@ 2024-04-23 17:01     ` Doug Anderson
  2024-04-24  1:55       ` Xuxin Xiong
  0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2024-04-23 17:01 UTC (permalink / raw
  To: Xuxin Xiong
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi,

On Mon, Apr 22, 2024 at 6:28 PM Xuxin Xiong
<xuxinxiong@huaqin.corp-partner.google.com> wrote:
>
> Yes, I read the edid from the panels, one is CSO and the other is CSW.
> The details are as follows, please help check. Thank you!
>
>
> 1. MNC207QS1-1
> edid-decode (hex):
> 00 ff ff ff ff ff ff 00 0e 6f 00 12 e7 00 00 00
> 1e 21 01 04 a5 1b 12 78 03 8a d5 9c 5e 59 90 25
> 1b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 ae 3f 80 18 71 b0 23 40 30 20
> 36 00 07 a4 10 00 00 1a 00 00 00 fd 00 28 3c 4b
> 4b 11 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> 00 4d 4e 43 32 30 37 51 53 31 2d 31 0a 20 00 32
> ----------------
> Block 0, Base EDID:
> EDID Structure Version & Revision: 1.4
> Vendor & Product Identification:
> Manufacturer: CSO
> Model: 4608
> Serial Number: 231
> Made in: week 30 of 2023
> Basic Display Parameters & Features:
> Digital display
> Bits per primary color channel: 8
> DisplayPort interface
> Maximum image size: 27 cm x 18 cm
> Gamma: 2.20
> Supported color formats: RGB 4:4:4
> First detailed timing includes the native pixel format and preferred refresh rate
> Display is continuous frequency
> Color Characteristics:
> Red : 0.6113, 0.3671
> Green: 0.3496, 0.5644
> Blue : 0.1474, 0.1064
> White: 0.3134, 0.3291
> Established Timings I & II: none
> Standard Timings: none
> Detailed Timing Descriptors:
> DTD 1: 1920x1200 60.000 Hz 8:5 74.100 kHz 163.020 MHz (263 mm x 164 mm)
> Hfront 48 Hsync 32 Hback 200 Hpol P
> Vfront 3 Vsync 6 Vback 26 Vpol N
> Display Range Limits:
> Monitor ranges (Bare Limits): 40-60 Hz V, 75-75 kHz H, max dotclock 170 MHz
> Alphanumeric Data String: 'CSOT T9'
> Alphanumeric Data String: 'MNC207QS1-1'
> Checksum: 0x32
>
> 2. MNB601LS1-1
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0e 77 00 11 00 00 00 00
> 00 22 01 04 95 1a 0e 78 03 a1 35 9b 5e 58 91 25
> 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 09 1e 56 dc 50 00 28 30 30 20
> 36 00 00 90 10 00 00 1a 00 00 00 fd 00 28 3c 30
> 30 08 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> 00 4d 4e 42 36 30 31 4c 53 31 2d 31 0a 20 00 37
> ----------------
> Block 0, Base EDID:
> EDID Structure Version & Revision: 1.4
> Vendor & Product Identification:
> Manufacturer: CSW
> Model: 4352
> Made in: 2024
> Basic Display Parameters & Features:
> Digital display
> Bits per primary color channel: 6
> DisplayPort interface
> Maximum image size: 26 cm x 14 cm
> Gamma: 2.20
> Supported color formats: RGB 4:4:4
> First detailed timing includes the native pixel format and preferred refresh rate
> Display is continuous frequency
> Color Characteristics:
> Red : 0.6074, 0.3691
> Green: 0.3437, 0.5673
> Blue : 0.1445, 0.1123
> White: 0.3134, 0.3291
> Established Timings I & II: none
> Standard Timings: none
> Detailed Timing Descriptors:
> DTD 1: 1366x768 60.001 Hz 683:384 48.480 kHz 76.890 MHz (256 mm x 144 mm)
> Hfront 48 Hsync 32 Hback 140 Hpol P
> Vfront 3 Vsync 6 Vback 31 Vpol N
> Display Range Limits:
> Monitor ranges (Bare Limits): 40-60 Hz V, 48-48 kHz H, max dotclock 80 MHz
> Alphanumeric Data String: 'CSOT T9'
> Alphanumeric Data String: 'MNB601LS1-1'
> Checksum: 0x37

OK. This made me look a little deeper. I believe that the three-letter
code is managed by UEFI and I found:

https://uefi.org/PNP_ID_List

...as far as I can tell "CSW" is actually correct for CSOT but "CSO"
was _not_. Looks as if CSO was supposed to be for "California
Institute of Technology" (Caltech). :(

We're probably OK with the recent work that Hsin-Yi did in commit
bf201127c1b8 ("drm/panel-edp: Match edp_panels with panel identity")
to match against the panel name even if Caltech does ship a "CSO"
0x1200 in the future since it looks like the string you added matches
the panel.

That being said, is there any chance that it's not too late and you
can get CSOT to fix the EDID on "MNC207QS1-1"? Can you also make sure
that they're aware of this and don't make the same mistake in the
future?


In any case, given this investigation and the EDID I'm going to say
that the panel you've added here is fine.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

I've pushed your change to drm-misc-next:

a6325ad47bc8 drm/panel-edp: Add panel CSOT MNB601LS1-1

-Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-04-23 17:01     ` Doug Anderson
@ 2024-04-24  1:55       ` Xuxin Xiong
  2024-05-06 15:54         ` Doug Anderson
  0 siblings, 1 reply; 9+ messages in thread
From: Xuxin Xiong @ 2024-04-24  1:55 UTC (permalink / raw
  To: Doug Anderson
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi Doug, thank you!
We had reported this info to the CSOT to correct the vendor id.
If they confirm to fix this with the same product ID, we will submit a
patch to fix this.


Doug Anderson <dianders@chromium.org> 于2024年4月24日周三 01:01写道:
>
> Hi,
>
> On Mon, Apr 22, 2024 at 6:28 PM Xuxin Xiong
> <xuxinxiong@huaqin.corp-partner.google.com> wrote:
> >
> > Yes, I read the edid from the panels, one is CSO and the other is CSW.
> > The details are as follows, please help check. Thank you!
> >
> >
> > 1. MNC207QS1-1
> > edid-decode (hex):
> > 00 ff ff ff ff ff ff 00 0e 6f 00 12 e7 00 00 00
> > 1e 21 01 04 a5 1b 12 78 03 8a d5 9c 5e 59 90 25
> > 1b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> > 01 01 01 01 01 01 ae 3f 80 18 71 b0 23 40 30 20
> > 36 00 07 a4 10 00 00 1a 00 00 00 fd 00 28 3c 4b
> > 4b 11 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> > 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> > 00 4d 4e 43 32 30 37 51 53 31 2d 31 0a 20 00 32
> > ----------------
> > Block 0, Base EDID:
> > EDID Structure Version & Revision: 1.4
> > Vendor & Product Identification:
> > Manufacturer: CSO
> > Model: 4608
> > Serial Number: 231
> > Made in: week 30 of 2023
> > Basic Display Parameters & Features:
> > Digital display
> > Bits per primary color channel: 8
> > DisplayPort interface
> > Maximum image size: 27 cm x 18 cm
> > Gamma: 2.20
> > Supported color formats: RGB 4:4:4
> > First detailed timing includes the native pixel format and preferred refresh rate
> > Display is continuous frequency
> > Color Characteristics:
> > Red : 0.6113, 0.3671
> > Green: 0.3496, 0.5644
> > Blue : 0.1474, 0.1064
> > White: 0.3134, 0.3291
> > Established Timings I & II: none
> > Standard Timings: none
> > Detailed Timing Descriptors:
> > DTD 1: 1920x1200 60.000 Hz 8:5 74.100 kHz 163.020 MHz (263 mm x 164 mm)
> > Hfront 48 Hsync 32 Hback 200 Hpol P
> > Vfront 3 Vsync 6 Vback 26 Vpol N
> > Display Range Limits:
> > Monitor ranges (Bare Limits): 40-60 Hz V, 75-75 kHz H, max dotclock 170 MHz
> > Alphanumeric Data String: 'CSOT T9'
> > Alphanumeric Data String: 'MNC207QS1-1'
> > Checksum: 0x32
> >
> > 2. MNB601LS1-1
> > edid-decode (hex):
> >
> > 00 ff ff ff ff ff ff 00 0e 77 00 11 00 00 00 00
> > 00 22 01 04 95 1a 0e 78 03 a1 35 9b 5e 58 91 25
> > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> > 01 01 01 01 01 01 09 1e 56 dc 50 00 28 30 30 20
> > 36 00 00 90 10 00 00 1a 00 00 00 fd 00 28 3c 30
> > 30 08 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> > 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> > 00 4d 4e 42 36 30 31 4c 53 31 2d 31 0a 20 00 37
> > ----------------
> > Block 0, Base EDID:
> > EDID Structure Version & Revision: 1.4
> > Vendor & Product Identification:
> > Manufacturer: CSW
> > Model: 4352
> > Made in: 2024
> > Basic Display Parameters & Features:
> > Digital display
> > Bits per primary color channel: 6
> > DisplayPort interface
> > Maximum image size: 26 cm x 14 cm
> > Gamma: 2.20
> > Supported color formats: RGB 4:4:4
> > First detailed timing includes the native pixel format and preferred refresh rate
> > Display is continuous frequency
> > Color Characteristics:
> > Red : 0.6074, 0.3691
> > Green: 0.3437, 0.5673
> > Blue : 0.1445, 0.1123
> > White: 0.3134, 0.3291
> > Established Timings I & II: none
> > Standard Timings: none
> > Detailed Timing Descriptors:
> > DTD 1: 1366x768 60.001 Hz 683:384 48.480 kHz 76.890 MHz (256 mm x 144 mm)
> > Hfront 48 Hsync 32 Hback 140 Hpol P
> > Vfront 3 Vsync 6 Vback 31 Vpol N
> > Display Range Limits:
> > Monitor ranges (Bare Limits): 40-60 Hz V, 48-48 kHz H, max dotclock 80 MHz
> > Alphanumeric Data String: 'CSOT T9'
> > Alphanumeric Data String: 'MNB601LS1-1'
> > Checksum: 0x37
>
> OK. This made me look a little deeper. I believe that the three-letter
> code is managed by UEFI and I found:
>
> https://uefi.org/PNP_ID_List
>
> ...as far as I can tell "CSW" is actually correct for CSOT but "CSO"
> was _not_. Looks as if CSO was supposed to be for "California
> Institute of Technology" (Caltech). :(
>
> We're probably OK with the recent work that Hsin-Yi did in commit
> bf201127c1b8 ("drm/panel-edp: Match edp_panels with panel identity")
> to match against the panel name even if Caltech does ship a "CSO"
> 0x1200 in the future since it looks like the string you added matches
> the panel.
>
> That being said, is there any chance that it's not too late and you
> can get CSOT to fix the EDID on "MNC207QS1-1"? Can you also make sure
> that they're aware of this and don't make the same mistake in the
> future?
>
>
> In any case, given this investigation and the EDID I'm going to say
> that the panel you've added here is fine.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> I've pushed your change to drm-misc-next:
>
> a6325ad47bc8 drm/panel-edp: Add panel CSOT MNB601LS1-1
>
> -Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-04-24  1:55       ` Xuxin Xiong
@ 2024-05-06 15:54         ` Doug Anderson
  2024-05-28 16:27           ` Doug Anderson
  0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2024-05-06 15:54 UTC (permalink / raw
  To: Xuxin Xiong
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi,

On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong
<xuxinxiong@huaqin.corp-partner.google.com> wrote:
>
> Hi Doug, thank you!
> We had reported this info to the CSOT to correct the vendor id.
> If they confirm to fix this with the same product ID, we will submit a
> patch to fix this.

FYI, "top posting" like this is generally frowned upon on kernel
mailing lists. One such reference about this is [1]. Some folks are
very passionate about this topic, so please keep it in mind to avoid
upsetting people in the community.

In any case: did you get any response from CSOT about the improper EDID?

[1] https://subspace.kernel.org/etiquette.html

-Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-05-06 15:54         ` Doug Anderson
@ 2024-05-28 16:27           ` Doug Anderson
  2024-06-11 16:49             ` Doug Anderson
  0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2024-05-28 16:27 UTC (permalink / raw
  To: Xuxin Xiong
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi,

On Mon, May 6, 2024 at 8:54 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong
> <xuxinxiong@huaqin.corp-partner.google.com> wrote:
> >
> > Hi Doug, thank you!
> > We had reported this info to the CSOT to correct the vendor id.
> > If they confirm to fix this with the same product ID, we will submit a
> > patch to fix this.
>
> FYI, "top posting" like this is generally frowned upon on kernel
> mailing lists. One such reference about this is [1]. Some folks are
> very passionate about this topic, so please keep it in mind to avoid
> upsetting people in the community.
>
> In any case: did you get any response from CSOT about the improper EDID?

Just following up here. Was there any response from CSOT?

-Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-05-28 16:27           ` Doug Anderson
@ 2024-06-11 16:49             ` Doug Anderson
  2024-06-12  6:08               ` Xuxin Xiong
  0 siblings, 1 reply; 9+ messages in thread
From: Doug Anderson @ 2024-06-11 16:49 UTC (permalink / raw
  To: Xuxin Xiong
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

Hi,

On Tue, May 28, 2024 at 9:27 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Mon, May 6, 2024 at 8:54 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong
> > <xuxinxiong@huaqin.corp-partner.google.com> wrote:
> > >
> > > Hi Doug, thank you!
> > > We had reported this info to the CSOT to correct the vendor id.
> > > If they confirm to fix this with the same product ID, we will submit a
> > > patch to fix this.
> >
> > FYI, "top posting" like this is generally frowned upon on kernel
> > mailing lists. One such reference about this is [1]. Some folks are
> > very passionate about this topic, so please keep it in mind to avoid
> > upsetting people in the community.
> >
> > In any case: did you get any response from CSOT about the improper EDID?
>
> Just following up here. Was there any response from CSOT?

Continuing to follow up here. Did CSOT say anything about this?

-Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1
  2024-06-11 16:49             ` Doug Anderson
@ 2024-06-12  6:08               ` Xuxin Xiong
  0 siblings, 0 replies; 9+ messages in thread
From: Xuxin Xiong @ 2024-06-12  6:08 UTC (permalink / raw
  To: Doug Anderson
  Cc: sam, neil.armstrong, daniel, hsinyi, dri-devel, devicetree,
	linux-kernel

I'm so sorry for the late reply.
The information we got from the CSOT is that when the project was
first started, CSO was used. Later, they realized this problem and
changed the VID of other panel models to CSW. Since the panel has
already been shipped, they will keep it as CSO and only the VID for
that panel will be CSO.
Thanks a lot!

Doug Anderson <dianders@chromium.org> 于2024年6月12日周三 00:50写道:
>
> Hi,
>
> On Tue, May 28, 2024 at 9:27 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Mon, May 6, 2024 at 8:54 AM Doug Anderson <dianders@chromium.org> wrote:
> > >
> > > Hi,
> > >
> > > On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong
> > > <xuxinxiong@huaqin.corp-partner.google.com> wrote:
> > > >
> > > > Hi Doug, thank you!
> > > > We had reported this info to the CSOT to correct the vendor id.
> > > > If they confirm to fix this with the same product ID, we will submit a
> > > > patch to fix this.
> > >
> > > FYI, "top posting" like this is generally frowned upon on kernel
> > > mailing lists. One such reference about this is [1]. Some folks are
> > > very passionate about this topic, so please keep it in mind to avoid
> > > upsetting people in the community.
> > >
> > > In any case: did you get any response from CSOT about the improper EDID?
> >
> > Just following up here. Was there any response from CSOT?
>
> Continuing to follow up here. Did CSOT say anything about this?
>
> -Doug

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-06-12  6:08 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-22  6:08 [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1 Xuxin Xiong
2024-04-22 14:10 ` Doug Anderson
2024-04-23  1:28   ` Xuxin Xiong
2024-04-23 17:01     ` Doug Anderson
2024-04-24  1:55       ` Xuxin Xiong
2024-05-06 15:54         ` Doug Anderson
2024-05-28 16:27           ` Doug Anderson
2024-06-11 16:49             ` Doug Anderson
2024-06-12  6:08               ` Xuxin Xiong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.