From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>, linux-pci@vger.kernel.org
Subject: Re: [bug report] PCI: endpoint: Remove "core_init_notifier" flag
Date: Wed, 17 Apr 2024 21:28:28 +0530 [thread overview]
Message-ID: <20240417155828.GB15187@thinkpad> (raw)
In-Reply-To: <Zh_s3WdFURyll54l@ryzen>
On Wed, Apr 17, 2024 at 05:38:05PM +0200, Niklas Cassel wrote:
> On Wed, Apr 17, 2024 at 03:47:48PM +0300, Dan Carpenter wrote:
> > Hello Manivannan Sadhasivam,
> >
> > Commit a01e7214bef9 ("PCI: endpoint: Remove "core_init_notifier"
> > flag") from Mar 27, 2024 (linux-next), leads to the following Smatch
> > static checker warning:
> >
> > drivers/pci/endpoint/functions/pci-epf-test.c:784 pci_epf_test_core_init()
> > error: we previously assumed 'epc_features' could be null (see line 747)
> >
> > drivers/pci/endpoint/functions/pci-epf-test.c
> > 734 static int pci_epf_test_core_init(struct pci_epf *epf)
> > 735 {
> > 736 struct pci_epf_test *epf_test = epf_get_drvdata(epf);
> > 737 struct pci_epf_header *header = epf->header;
> > 738 const struct pci_epc_features *epc_features;
> > 739 struct pci_epc *epc = epf->epc;
> > 740 struct device *dev = &epf->dev;
> > 741 bool linkup_notifier = false;
> > 742 bool msix_capable = false;
> > 743 bool msi_capable = true;
> > 744 int ret;
>
> We check pci_epc_get_features() in ->bind(), which comes before ->core_init()
> so in practice, this shouldn't be able to be NULL here.
>
Right.
>
> > 745
> > 746 epc_features = pci_epc_get_features(epc, epf->func_no, epf->vfunc_no);
> > 747 if (epc_features) {
> > ^^^^^^^^^^^^
> > epc_features can be NULL
>
> We should probably just chge this to:
>
> """
> if (!epc_features)
> return some_error;
>
> msix_capable = epc_features->msix_capable;
> msi_capable = epc_features->msi_capable;
> """
>
> Such that we don't need another check further down for linkup_notifier.
>
No. We should just remove this NULL check since the check is already present in
bind().
- Mani
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2024-04-17 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 12:47 [bug report] PCI: endpoint: Remove "core_init_notifier" flag Dan Carpenter
2024-04-17 15:38 ` Niklas Cassel
2024-04-17 15:58 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417155828.GB15187@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=cassel@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.