From: "Ушков Даниил" <udav@mts.ru>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ушков Даниил" <udav@mts.ru>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Chenbo Xia" <chenbox@nvidia.com>
Subject: [PATCH] lib/vhost: add flag for async connection in client mode
Date: Wed, 17 Apr 2024 08:41:00 +0000 [thread overview]
Message-ID: <20240417083835.164456-1-udav@mts.ru> (raw)
This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT,
which in combination with the flag RTE_VHOST_USER_CLIENT makes
rte_vhost_driver_start connect asynchronously to the vhost server.
Signed-off-by: Daniil Ushkov <udav@mts.ru>
---
lib/vhost/rte_vhost.h | 1 +
lib/vhost/socket.c | 28 ++++++++++++++++------------
2 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index db92f05344..b0434c4b8d 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -41,6 +41,7 @@ extern "C" {
#define RTE_VHOST_USER_ASYNC_COPY (1ULL << 7)
#define RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS (1ULL << 8)
#define RTE_VHOST_USER_NET_STATS_ENABLE (1ULL << 9)
+#define RTE_VHOST_USER_ASYNC_CONNECT (1ULL << 10)
/* Features. */
#ifndef VIRTIO_NET_F_GUEST_ANNOUNCE
diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index 96b3ab5595..38c400f173 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -45,6 +45,7 @@ struct vhost_user_socket {
bool async_copy;
bool net_compliant_ol_flags;
bool stats_enabled;
+ bool async_connect;
/*
* The "supported_features" indicates the feature bits the
@@ -533,21 +534,23 @@ vhost_user_start_client(struct vhost_user_socket *vsocket)
const char *path = vsocket->path;
struct vhost_user_reconnect *reconn;
- ret = vhost_user_connect_nonblock(vsocket->path, fd, (struct sockaddr *)&vsocket->un,
- sizeof(vsocket->un));
- if (ret == 0) {
- vhost_user_add_connection(fd, vsocket);
- return 0;
- }
+ if (!vsocket->async_connect || !vsocket->reconnect) {
+ ret = vhost_user_connect_nonblock(vsocket->path, fd, (struct sockaddr *)&vsocket->un,
+ sizeof(vsocket->un));
+ if (ret == 0) {
+ vhost_user_add_connection(fd, vsocket);
+ return 0;
+ }
- VHOST_CONFIG_LOG(path, WARNING, "failed to connect: %s", strerror(errno));
+ VHOST_CONFIG_LOG(path, WARNING, "failed to connect: %s", strerror(errno));
- if (ret == -2 || !vsocket->reconnect) {
- close(fd);
- return -1;
- }
+ if (ret == -2 || !vsocket->reconnect) {
+ close(fd);
+ return -1;
+ }
- VHOST_CONFIG_LOG(path, INFO, "reconnecting...");
+ VHOST_CONFIG_LOG(path, INFO, "reconnecting...");
+ }
reconn = malloc(sizeof(*reconn));
if (reconn == NULL) {
VHOST_CONFIG_LOG(path, ERR, "failed to allocate memory for reconnect");
@@ -930,6 +933,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
vsocket->async_copy = flags & RTE_VHOST_USER_ASYNC_COPY;
vsocket->net_compliant_ol_flags = flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
vsocket->stats_enabled = flags & RTE_VHOST_USER_NET_STATS_ENABLE;
+ vsocket->async_connect = flags & RTE_VHOST_USER_ASYNC_CONNECT;
if (vsocket->is_vduse)
vsocket->iommu_support = true;
else
--
2.34.1
next reply other threads:[~2024-04-17 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:41 Ушков Даниил [this message]
2024-04-17 9:15 ` [PATCH v2] lib/vhost: add flag for async connection in client mode Ушков Даниил
2024-04-25 13:47 ` Maxime Coquelin
2024-04-25 14:04 ` Morten Brørup
2024-04-29 19:43 ` Thomas Monjalon
2024-04-26 8:38 ` [PATCH v3] " Daniil Ushkov
2024-04-26 8:47 ` [PATCH v4] " Daniil Ushkov
2024-04-26 21:29 ` [PATCH] " Patrick Robb
2024-05-14 9:13 ` [PATCH v5] This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost server Daniil Ushkov
2024-05-14 9:16 ` [PATCH v6] lib/vhost: add flag for async connection in client mode Daniil Ushkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417083835.164456-1-udav@mts.ru \
--to=udav@mts.ru \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.