From: Christian Brauner <brauner@kernel.org>
To: John Groves <John@groves.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, John Groves <jgroves@micron.com>,
john@jagalactic.com
Subject: Re: [PATCH 1/1] sget_dev() bug fix: dev_t passed by value but stored via stack address
Date: Wed, 10 Apr 2024 12:16:48 +0200 [thread overview]
Message-ID: <20240410-mitnahm-loyal-151d4312b017@brauner> (raw)
In-Reply-To: <7a37d4832e0c2e7cfe8000b0bf47dcc2c50d78d0.1712704849.git.john@groves.net>
On Tue, Apr 09, 2024 at 06:31:44PM -0500, John Groves wrote:
> The ref vs. value logic used by sget_dev() was ungood, storing the
> stack address of the key (dev_t) rather than the value of the key.
> This straightens that out.
>
> In the sget_dev() path, the (void *)data passed to the test and set
> helpers should be the value of the dev_t, not its address.
>
> Signed-off-by: John Groves <john@groves.net>
> ---
Afaict there's nothing wrong with the current logic so I'm missing your
point here. It's casting to a dev_t and then dereferencing it. So I
don't think this patch makes sense.
next prev parent reply other threads:[~2024-04-10 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 23:31 [PATCH 0/1] sget_dev() minor bug fix John Groves
2024-04-09 23:31 ` [PATCH 1/1] sget_dev() bug fix: dev_t passed by value but stored via stack address John Groves
2024-04-10 9:18 ` kernel test robot
2024-04-10 10:16 ` Christian Brauner [this message]
2024-04-10 13:38 ` John Groves
2024-04-10 15:23 ` Christian Brauner
2024-04-10 21:24 ` John Groves
2024-04-17 5:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410-mitnahm-loyal-151d4312b017@brauner \
--to=brauner@kernel.org \
--cc=John@groves.net \
--cc=jack@suse.cz \
--cc=jgroves@micron.com \
--cc=john@jagalactic.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.