From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42CD53FB8E; Mon, 1 Apr 2024 13:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711979552; cv=none; b=XGgSRQmBQ7JoK5TCj09eXDlmOxGCdPdFDsiNgIq8xsVn0+GGjs6KW8RW4s6ou0MksHgzHZbsN/+jKcKwYVQ1K2C+w840AoN2DlrwdazhKfCExFUr3CklF4s+D97WRpEGxsu0RUAqAO5P0/XxWIPOohHjQrvgGd8kTh2YaFoCyL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711979552; c=relaxed/simple; bh=x4zTKubFtBTcQ2cSUnrgIDMP9d4ehF2w18B5zKaS3xM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CEXSZLi7XNibsLbysZbDxuDTGMMQkSP9s0DLTorKrHtPLw6Dm94jqAaqrUGSKI9ZeaFPX4f5L10PeR3dWMxDl+Wzwbb2zBlHE9l19SvZPyMJw+UCeqypdvWHCOwmQqRQbtWV3VxSB4yrQ+8p5/eH22WQLtWbiPAik4KFhiTlI/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=GEvqxBlB; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GEvqxBlB" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EB108250; Mon, 1 Apr 2024 15:51:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711979510; bh=x4zTKubFtBTcQ2cSUnrgIDMP9d4ehF2w18B5zKaS3xM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GEvqxBlBeGmInPWI1eWzSqbLVZxVwN5fYeOAwBR6t6u9b4PAoGQ/brkQIqwD4F/sx Vt7utkRXCeJG0wXzf7zoAwMbVLhwh5oWHZB3NbIAP8Mdyumi+fISfHwhEgZ70lDqyC SlpglQPsy4s1P4+N7Lgp22Cf2H2iDch40C8MAIBo= Date: Mon, 1 Apr 2024 16:52:16 +0300 From: Laurent Pinchart To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, Dave Stevenson , David Plowman , Jean-Michel Hautbois , Hans Verkuil , Naushir Patuck , Sakari Ailus , kernel-list@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v7 09/15] media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface Message-ID: <20240401135216.GF8623@pendragon.ideasonboard.com> References: <20240324220854.15010-1-laurent.pinchart@ideasonboard.com> <20240324220854.15010-10-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Mar 27, 2024 at 01:21:09PM +0200, Tomi Valkeinen wrote: > On 25/03/2024 00:08, Laurent Pinchart wrote: > > From: Dave Stevenson > > > > Add a driver for the Unicam camera receiver block on BCM283x processors. > > It is represented as two video device nodes: unicam-image and > > unicam-embedded which are connected to an internal subdev (named > > unicam-subdev) in order to manage streams routing. > > Shouldn't this driver call get_frame_desc somewhere to get the VC and DT > for the streams? Generally speaking, yes. In practice, configuring the DT from the frame descriptor is probably not very useful, as CSI-2 sources that transmit image data using a DT that doesn't correspond to the media bus code are not very common and I don't expect this to be needed for unicam. Configuring the VC, on the other hand, seems to me like a better use case. I will add get_frame_desc support for the next version. -- Regards, Laurent Pinchart