From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>, <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
vadim.fedorenko@linux.dev,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v2 2/2] virtio-net: support dim profile fine-tuning
Date: Thu, 28 Mar 2024 09:48:47 -0700 [thread overview]
Message-ID: <20240328094847.1af51a8d@kernel.org> (raw)
In-Reply-To: <1711591930.8288093-2-xuanzhuo@linux.alibaba.com>
On Thu, 28 Mar 2024 10:12:10 +0800 Xuan Zhuo wrote:
> For netdim, I think profiles are an aspect. In many cases, this can solve many
> problems.
Okay, but then you should try harder to hide all the config in the core.
The driver should be blissfully unaware that the user is changing
the settings. It should just continue calling net_dim_get_*moderation().
You can create proper dim_init(), dim_destroy() functions for drivers
to call, instead of doing
INIT_WORK(&bla->dim.work, my_driver_do_dim_work);
directly. In dim_init() you can hook the dim structure to net_device
and then ethtool code can operation on it without driver involvement.
About the uAPI - please make sure you add the new stuff to
Documentation/netlink/specs/ethtool.yaml
see: https://docs.kernel.org/next/userspace-api/netlink/specs.html
And break up the attributes, please, no raw C structs of this nature:
+ return nla_put(skb, attr_type, sizeof(struct dim_cq_moder) *
+ NET_DIM_PARAMS_NUM_PROFILES, profs);
They are hard to extend.
next prev parent reply other threads:[~2024-03-28 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 9:19 [PATCH net-next v2 0/2] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-03-27 9:19 ` [PATCH net-next v2 1/2] ethtool: provide customized dim profile management Heng Qi
2024-03-27 9:19 ` [PATCH net-next v2 2/2] virtio-net: support dim profile fine-tuning Heng Qi
2024-03-27 14:45 ` Alexander Lobakin
2024-03-28 0:32 ` Jakub Kicinski
2024-03-28 2:12 ` Xuan Zhuo
2024-03-28 16:48 ` Jakub Kicinski [this message]
2024-03-29 8:56 ` Heng Qi
2024-03-29 15:18 ` Jakub Kicinski
2024-03-28 2:26 ` Heng Qi
2024-03-28 2:02 ` Heng Qi
2024-03-28 7:27 ` Michael S. Tsirkin
2024-03-28 7:27 ` Michael S. Tsirkin
2024-03-28 7:51 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328094847.1af51a8d@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.