From: Maxime Ripard <mripard@kernel.org>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Alex Constantino <dreaming.about.electric.sheep@gmail.com>,
1054514@bugs.debian.org, airlied@redhat.com, carnil@debian.org,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
kraxel@redhat.com, linux-kernel@vger.kernel.org,
spice-devel@lists.freedesktop.org, timo.lindfors@iki.fi,
tzimmermann@suse.de, virtualization@lists.linux-foundation.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH 1/1] drm/qxl: fixes qxl_fence_wait
Date: Wed, 27 Mar 2024 14:27:29 +0100 [thread overview]
Message-ID: <20240327-cuddly-smooth-trogon-59c02d@houat> (raw)
In-Reply-To: <db4c8e74-5c79-49be-9781-a5d8669eccc1@leemhuis.info>
[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]
Hi,
On Wed, Mar 20, 2024 at 04:25:48PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 08.03.24 02:08, Alex Constantino wrote:
> > Fix OOM scenario by doing multiple notifications to the OOM handler through
> > a busy wait logic.
> > Changes from commit 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") would
> > result in a '[TTM] Buffer eviction failed' exception whenever it reached a
> > timeout.
> >
> > Fixes: 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait")
> > Link: https://lore.kernel.org/regressions/fb0fda6a-3750-4e1b-893f-97a3e402b9af@leemhuis.info
> > Reported-by: Timo Lindfors <timo.lindfors@iki.fi>
> > Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054514
> > Signed-off-by: Alex Constantino <dreaming.about.electric.sheep@gmail.com>
> > ---
> > drivers/gpu/drm/qxl/qxl_release.c | 20 ++++++++++++++------
> > 1 file changed, 14 insertions(+), 6 deletions(-)
>
> Hey Dave and Gerd as well as Thomas, Maarten and Maxime (the latter two
> I just added to the CC), it seems to me this regression fix did not
> maybe any progress since it was posted. Did I miss something, is it just
> "we are busy with the merge window", or is there some other a reason?
> Just wondering, I just saw someone on a Fedora IRC channel complaining
> about the regression, that's why I'm asking. Would be really good to
> finally get this resolved...
I've ping'd Gerd last week about it, but he couldn't remember the
details of why that patch was warranted in the first place.
If it works, I'd prefer to revert the original patch that we know used
to work instead of coming up with some less proven logic, which seems to
be quite different to what it used to be.
Alex, could you try reverting 5a838e5d5825c85556011478abde708251cc0776
and letting us know the result?
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2024-03-27 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.20.2310242308150.28457@mail.home>
2023-10-24 21:09 ` Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently Salvatore Bonaccorso
2023-10-24 21:09 ` Salvatore Bonaccorso
2023-10-24 21:09 ` Salvatore Bonaccorso
2023-10-24 21:39 ` Timo Lindfors
2023-10-24 21:39 ` Timo Lindfors
2023-12-06 9:56 ` Linux regression tracking (Thorsten Leemhuis)
2023-12-06 9:56 ` Linux regression tracking (Thorsten Leemhuis)
2023-12-06 10:45 ` Bug#1054514: Info received (Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently) Debian Bug Tracking System
2024-03-08 1:08 ` [PATCH 0/1] drm/qxl: fixes qxl_fence_wait Alex Constantino
2024-03-08 1:08 ` [PATCH 1/1] " Alex Constantino
2024-03-08 8:58 ` Thorsten Leemhuis
2024-03-20 15:25 ` Linux regression tracking (Thorsten Leemhuis)
2024-03-20 15:27 ` Bug#1054514: Info received ([PATCH 1/1] drm/qxl: fixes qxl_fence_wait) Debian Bug Tracking System
2024-03-27 13:27 ` Maxime Ripard [this message]
2024-04-04 18:14 ` [PATCH v2 0/1] Revert "drm/qxl: simplify qxl_fence_wait" Alex Constantino
2024-04-04 18:14 ` [PATCH v2 1/1] " Alex Constantino
2024-04-05 4:37 ` Greg KH
2024-04-05 13:13 ` (subset) " Maxime Ripard
2023-10-24 23:55 ` Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently Bagas Sanjaya
2023-10-24 23:55 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327-cuddly-smooth-trogon-59c02d@houat \
--to=mripard@kernel.org \
--cc=1054514@bugs.debian.org \
--cc=airlied@redhat.com \
--cc=carnil@debian.org \
--cc=daniel@ffwll.ch \
--cc=dreaming.about.electric.sheep@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=regressions@lists.linux.dev \
--cc=spice-devel@lists.freedesktop.org \
--cc=timo.lindfors@iki.fi \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.