* [linux-next:master 614/1266] drivers/firmware/arm_scmi/raw_mode.c:924:8-24: WARNING: scmi_dbg_raw_mode_reset_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
@ 2024-03-26 5:28 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-03-26 5:28 UTC (permalink / raw
To: oe-kbuild; +Cc: lkp, Julia Lawall
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Cristian Marussi <cristian.marussi@arm.com>
CC: Sudeep Holla <sudeep.holla@arm.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 1fdad13606e104ff103ca19d2d660830cb36d43e
commit: 7f620d5b0b1dd7c7972cdf1b40b30552ac7bd325 [614/1266] firmware: arm_scmi: Make raw debugfs entries non-seekable
:::::: branch date: 28 hours ago
:::::: commit date: 11 days ago
config: loongarch-randconfig-r064-20240325 (https://download.01.org/0day-ci/archive/20240326/202403261302.ww11nNYx-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202403261302.ww11nNYx-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/firmware/arm_scmi/raw_mode.c:924:8-24: WARNING: scmi_dbg_raw_mode_reset_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
vim +924 drivers/firmware/arm_scmi/raw_mode.c
3c3d818a9317a5 Cristian Marussi 2023-01-18 886
3c3d818a9317a5 Cristian Marussi 2023-01-18 887 static int scmi_dbg_raw_mode_open(struct inode *inode, struct file *filp)
3c3d818a9317a5 Cristian Marussi 2023-01-18 888 {
7860701d1e6e6e Cristian Marussi 2023-01-18 889 u8 id;
3c3d818a9317a5 Cristian Marussi 2023-01-18 890 struct scmi_raw_mode_info *raw;
3c3d818a9317a5 Cristian Marussi 2023-01-18 891 struct scmi_dbg_raw_data *rd;
7860701d1e6e6e Cristian Marussi 2023-01-18 892 const char *id_str = filp->f_path.dentry->d_parent->d_name.name;
3c3d818a9317a5 Cristian Marussi 2023-01-18 893
3c3d818a9317a5 Cristian Marussi 2023-01-18 894 if (!inode->i_private)
3c3d818a9317a5 Cristian Marussi 2023-01-18 895 return -ENODEV;
3c3d818a9317a5 Cristian Marussi 2023-01-18 896
3c3d818a9317a5 Cristian Marussi 2023-01-18 897 raw = inode->i_private;
3c3d818a9317a5 Cristian Marussi 2023-01-18 898 rd = kzalloc(sizeof(*rd), GFP_KERNEL);
3c3d818a9317a5 Cristian Marussi 2023-01-18 899 if (!rd)
3c3d818a9317a5 Cristian Marussi 2023-01-18 900 return -ENOMEM;
3c3d818a9317a5 Cristian Marussi 2023-01-18 901
3c3d818a9317a5 Cristian Marussi 2023-01-18 902 rd->rx.len = raw->desc->max_msg_size + sizeof(u32);
3c3d818a9317a5 Cristian Marussi 2023-01-18 903 rd->rx.buf = kzalloc(rd->rx.len, GFP_KERNEL);
3c3d818a9317a5 Cristian Marussi 2023-01-18 904 if (!rd->rx.buf) {
3c3d818a9317a5 Cristian Marussi 2023-01-18 905 kfree(rd);
3c3d818a9317a5 Cristian Marussi 2023-01-18 906 return -ENOMEM;
3c3d818a9317a5 Cristian Marussi 2023-01-18 907 }
3c3d818a9317a5 Cristian Marussi 2023-01-18 908
3c3d818a9317a5 Cristian Marussi 2023-01-18 909 rd->tx.len = raw->desc->max_msg_size + sizeof(u32);
3c3d818a9317a5 Cristian Marussi 2023-01-18 910 rd->tx.buf = kzalloc(rd->tx.len, GFP_KERNEL);
3c3d818a9317a5 Cristian Marussi 2023-01-18 911 if (!rd->tx.buf) {
3c3d818a9317a5 Cristian Marussi 2023-01-18 912 kfree(rd->rx.buf);
3c3d818a9317a5 Cristian Marussi 2023-01-18 913 kfree(rd);
3c3d818a9317a5 Cristian Marussi 2023-01-18 914 return -ENOMEM;
3c3d818a9317a5 Cristian Marussi 2023-01-18 915 }
3c3d818a9317a5 Cristian Marussi 2023-01-18 916
7860701d1e6e6e Cristian Marussi 2023-01-18 917 /* Grab channel ID from debugfs entry naming if any */
7860701d1e6e6e Cristian Marussi 2023-01-18 918 if (!kstrtou8(id_str, 16, &id))
7860701d1e6e6e Cristian Marussi 2023-01-18 919 rd->chan_id = id;
7860701d1e6e6e Cristian Marussi 2023-01-18 920
3c3d818a9317a5 Cristian Marussi 2023-01-18 921 rd->raw = raw;
3c3d818a9317a5 Cristian Marussi 2023-01-18 922 filp->private_data = rd;
3c3d818a9317a5 Cristian Marussi 2023-01-18 923
7f620d5b0b1dd7 Cristian Marussi 2024-03-15 @924 return nonseekable_open(inode, filp);
3c3d818a9317a5 Cristian Marussi 2023-01-18 925 }
3c3d818a9317a5 Cristian Marussi 2023-01-18 926
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-26 5:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26 5:28 [linux-next:master 614/1266] drivers/firmware/arm_scmi/raw_mode.c:924:8-24: WARNING: scmi_dbg_raw_mode_reset_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.