All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [broonie-ci:v3_20240302_megi_add_support_for_jack_detection_to_codec_present_in_a64_soc 4/4] sound/soc/sunxi/sun8i-codec.c:1355:43: error: 'struct snd_jack' has no member named 'type'
@ 2024-03-26  4:24 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-03-26  4:24 UTC (permalink / raw
  To: Arnaud Ferraris; +Cc: oe-kbuild-all, Mark Brown, Samuel Holland, Ondrej Jirman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git v3_20240302_megi_add_support_for_jack_detection_to_codec_present_in_a64_soc
head:   21fa98f4197bb3365dda1417708b318f403c13c1
commit: 21fa98f4197bb3365dda1417708b318f403c13c1 [4/4] ASoC: sun8i-codec: Implement jack and accessory detection
config: arc-randconfig-r052-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261243.kcXCPAYs-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261243.kcXCPAYs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403261243.kcXCPAYs-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/soc/sunxi/sun8i-codec.c: In function 'sun8i_codec_jack_work':
>> sound/soc/sunxi/sun8i-codec.c:1355:43: error: 'struct snd_jack' has no member named 'type'
    1355 |         int type_mask = scodec->jack->jack->type;
         |                                           ^~
   sound/soc/sunxi/sun8i-codec.c: In function 'sun8i_codec_jack_irq':
   sound/soc/sunxi/sun8i-codec.c:1494:63: error: 'struct snd_jack' has no member named 'type'
    1494 |                                             scodec->jack->jack->type);
         |                                                               ^~


vim +1355 sound/soc/sunxi/sun8i-codec.c

  1349	
  1350	static void sun8i_codec_jack_work(struct work_struct *work)
  1351	{
  1352		struct sun8i_codec *scodec = container_of(work, struct sun8i_codec,
  1353							  jack_work.work);
  1354		unsigned int mdata;
> 1355		int type_mask = scodec->jack->jack->type;
  1356		int type;
  1357	
  1358		guard(mutex)(&scodec->jack_mutex);
  1359	
  1360		if (scodec->jack_status == SUN8I_JACK_STATUS_DISCONNECTED) {
  1361			if (scodec->last_hmic_irq != SUN8I_HMIC_STS_JACK_IN_IRQ_ST)
  1362				return;
  1363	
  1364			scodec->jack_last_sample = -1;
  1365	
  1366			if (type_mask & SND_JACK_MICROPHONE) {
  1367				/*
  1368				 * If we were in disconnected state, we enable HBIAS and
  1369				 * wait 600ms before reading initial HDATA value.
  1370				 */
  1371				scodec->jack_hbias_ready = ktime_add_ms(ktime_get(), 600);
  1372				sun8i_codec_set_hmic_bias(scodec, true);
  1373				queue_delayed_work(system_power_efficient_wq,
  1374						   &scodec->jack_work,
  1375						   msecs_to_jiffies(610));
  1376				scodec->jack_status = SUN8I_JACK_STATUS_WAITING_HBIAS;
  1377			} else {
  1378				snd_soc_jack_report(scodec->jack, SND_JACK_HEADPHONE,
  1379						    type_mask);
  1380				scodec->jack_status = SUN8I_JACK_STATUS_CONNECTED;
  1381			}
  1382		} else if (scodec->jack_status == SUN8I_JACK_STATUS_WAITING_HBIAS) {
  1383			/*
  1384			 * If we're waiting for HBIAS to stabilize, and we get plug-out
  1385			 * interrupt and nothing more for > 100ms, just cancel the
  1386			 * initialization.
  1387			 */
  1388			if (scodec->last_hmic_irq == SUN8I_HMIC_STS_JACK_OUT_IRQ_ST) {
  1389				scodec->jack_status = SUN8I_JACK_STATUS_DISCONNECTED;
  1390				sun8i_codec_set_hmic_bias(scodec, false);
  1391				return;
  1392			}
  1393	
  1394			/*
  1395			 * If we're not done waiting for HBIAS to stabilize, wait more.
  1396			 */
  1397			if (!ktime_after(ktime_get(), scodec->jack_hbias_ready)) {
  1398				s64 msecs = ktime_ms_delta(scodec->jack_hbias_ready,
  1399							   ktime_get());
  1400	
  1401				queue_delayed_work(system_power_efficient_wq,
  1402						   &scodec->jack_work,
  1403						   msecs_to_jiffies(msecs + 10));
  1404				return;
  1405			}
  1406	
  1407			/*
  1408			 * Everything is stabilized, determine jack type and report it.
  1409			 */
  1410			regmap_read(scodec->regmap, SUN8I_HMIC_STS, &mdata);
  1411			mdata &= SUN8I_HMIC_STS_HMIC_DATA_MASK;
  1412			mdata >>= SUN8I_HMIC_STS_HMIC_DATA;
  1413	
  1414			regmap_write(scodec->regmap, SUN8I_HMIC_STS, 0);
  1415	
  1416			type = mdata < 16 ? SND_JACK_HEADPHONE : SND_JACK_HEADSET;
  1417			if (type == SND_JACK_HEADPHONE)
  1418				sun8i_codec_set_hmic_bias(scodec, false);
  1419	
  1420			snd_soc_jack_report(scodec->jack, type, type_mask);
  1421			scodec->jack_status = SUN8I_JACK_STATUS_CONNECTED;
  1422		} else if (scodec->jack_status == SUN8I_JACK_STATUS_CONNECTED) {
  1423			if (scodec->last_hmic_irq != SUN8I_HMIC_STS_JACK_OUT_IRQ_ST)
  1424				return;
  1425	
  1426			scodec->jack_status = SUN8I_JACK_STATUS_DISCONNECTED;
  1427			if (type_mask & SND_JACK_MICROPHONE)
  1428				sun8i_codec_set_hmic_bias(scodec, false);
  1429	
  1430			snd_soc_jack_report(scodec->jack, 0, type_mask);
  1431		}
  1432	}
  1433	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-03-26  4:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26  4:24 [broonie-ci:v3_20240302_megi_add_support_for_jack_detection_to_codec_present_in_a64_soc 4/4] sound/soc/sunxi/sun8i-codec.c:1355:43: error: 'struct snd_jack' has no member named 'type' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.