From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A622811A9; Sun, 24 Mar 2024 23:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323671; cv=none; b=QPgqs6TkC43vSMDji6QpiqDdv/0mfaCqUO0o2TeBrOPwsiJHi24Az0pP/lLKQDQZx1bdw3mZzXJetDXRX9rQItbNlw9yu4EoN1+y/g6YaoNtTcbReiIaI4Ri1dXy2fLYm/EXo3X3E0/wnhOg6UaiJS1RSOKcaHOcJLGFAGfD2Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323671; c=relaxed/simple; bh=3NZJxN1ilBXYbX6v5QjBJ8M3TSMEdpCJXEWGJUSKqo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mo3603XEOAnemabM6U3yV8xww/oaCu+Cd6oDNBC3QVmRNcYz7fJU4evySvvdGCCI5XNx9ipVxQEDrTrcWcB0xexcjKNvLvbSBau2J6TVAlA2NWrIQkb4Gp1Jg5vThKaKsqAVUfmDEqQhx8rYbbxmwda8rLjYMSI8bFYYDXCUPxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=piiy2pgy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="piiy2pgy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B715C43390; Sun, 24 Mar 2024 23:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323670; bh=3NZJxN1ilBXYbX6v5QjBJ8M3TSMEdpCJXEWGJUSKqo8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=piiy2pgyvYkhSRp4/GD4caYUBTPKhuF3Kq7cxoIvqGD80KH6ImpYbV5wirLe2MuJR kTP0RQu0UUNOv1a8MIJATRnHqFcucdinunxyh2bKAIZUTQGEx/Vrp0o1Gm4LKajUjY MeuFJ9P5lCtBB5Xn2By49HiZzlR8fXRTZuc8b3q/bY+ER6wMveKm5RcG3kNHPY6ZQY sB+FHh59Pbl7GCGaur/+8xPPmurGirOaQwlyV7zOtEAy3yeDCZt+OlN5gCTD3yCLXN so4f3tTegx35DzErd1yvd8XjAefQG4OtytzofBbed/ghBiUPRxffkSLeJcr02ezpal 0jbHteMwTvgcQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rahul Rameshbabu , Julian Calaby , Kalle Valo , Sasha Levin Subject: [PATCH 5.10 042/238] wifi: b43: Stop correct queue in DMA worker when QoS is disabled Date: Sun, 24 Mar 2024 19:37:10 -0400 Message-ID: <20240324234027.1354210-43-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Rahul Rameshbabu [ Upstream commit 581c8967d66c4961076dbbee356834e9c6777184 ] When QoS is disabled, the queue priority value will not map to the correct ieee80211 queue since there is only one queue. Stop queue 0 when QoS is disabled to prevent trying to stop a non-existent queue and failing to stop the actual queue instantiated. Fixes: bad691946966 ("b43: avoid packet losses in the dma worker code.") Signed-off-by: Rahul Rameshbabu Reviewed-by: Julian Calaby Signed-off-by: Kalle Valo Link: https://msgid.link/20231231050300.122806-4-sergeantsagara@protonmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/b43/main.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index f175dbaffc300..6100c0d2a7f3c 100644 --- a/drivers/net/wireless/broadcom/b43/main.c +++ b/drivers/net/wireless/broadcom/b43/main.c @@ -3603,7 +3603,7 @@ static void b43_tx_work(struct work_struct *work) err = b43_dma_tx(dev, skb); if (err == -ENOSPC) { wl->tx_queue_stopped[queue_num] = true; - ieee80211_stop_queue(wl->hw, queue_num); + b43_stop_queue(dev, queue_num); skb_queue_head(&wl->tx_queue[queue_num], skb); break; } @@ -3627,6 +3627,7 @@ static void b43_op_tx(struct ieee80211_hw *hw, struct sk_buff *skb) { struct b43_wl *wl = hw_to_b43_wl(hw); + u16 skb_queue_mapping; if (unlikely(skb->len < 2 + 2 + 6)) { /* Too short, this can't be a valid frame. */ @@ -3635,12 +3636,12 @@ static void b43_op_tx(struct ieee80211_hw *hw, } B43_WARN_ON(skb_shinfo(skb)->nr_frags); - skb_queue_tail(&wl->tx_queue[skb->queue_mapping], skb); - if (!wl->tx_queue_stopped[skb->queue_mapping]) { + skb_queue_mapping = skb_get_queue_mapping(skb); + skb_queue_tail(&wl->tx_queue[skb_queue_mapping], skb); + if (!wl->tx_queue_stopped[skb_queue_mapping]) ieee80211_queue_work(wl->hw, &wl->tx_work); - } else { - ieee80211_stop_queue(wl->hw, skb->queue_mapping); - } + else + b43_stop_queue(wl->current_dev, skb_queue_mapping); } static void b43_qos_params_upload(struct b43_wldev *dev, -- 2.43.0