From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79F717A36A; Sun, 24 Mar 2024 23:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323652; cv=none; b=Iru3fVdOBRZvgwJ0+8F1Inbjt1+Cju3FfGD/ZNGYzipSIWBRcSRlcTlJTAE7O9zUqh6QB5E8+lgbz4lDUCuhJZKcRN+twjkrk2zJInxUTeENQZ0DnWKvPS4PUafFsm61s7JQYtPuEYITox5/X0DjJum/9ySY7yQJqIGvB61/yIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323652; c=relaxed/simple; bh=YEz4yne20Y+PXJLPWPogO6ruSXDx1kKR8hKUaO0QDu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PqY0k39/BYLUVpwRCuXJadcDYiu12XzZe/Uafn8KzhfzqqrCoqwsIe9oDeXAOlVF9BY3R2LoxHQ2axGjhG1MJQT/uiKxJVMq170Z6W9uCEHoXcGgLU0b7bVzYhccDst8obXtg/h941V7/46sBH+MeLAvOK3I3BK7h//VYR7JbU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CUO3XcNI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CUO3XcNI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC833C433C7; Sun, 24 Mar 2024 23:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323652; bh=YEz4yne20Y+PXJLPWPogO6ruSXDx1kKR8hKUaO0QDu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CUO3XcNI6fEqHqNlbPCqkke34sA+455eUNfFW766WWkTXoRwaNpkjSKuqZo9MA75o NRLBIDRJrrDn7x4LdeeG7lKtkwN1x/qYsHCqXJ01q5mMZJNQbacF9AM0ttyxQM2fBA H/yO+GpfODctYGkxRBpRHqV5VFdUYljPhrusn4pzWRy2+ohOpxK66kiOjfsoWmDQx/ 7BXTP67wu8ub9EGRA1gz2KKmwwlQT0TkBqp679VxONpzscajPRllMLevA7krZafzDe 1c8ClYlgXVoB5MRGL0ioqvD6lHTfQ5FM0vM5HckMlOw3faoyjMfCax/9wtmre2fvZa BKLXX4OOmvn3Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Linus Walleij , Dmitry Torokhov , Sasha Levin Subject: [PATCH 5.10 024/238] Input: gpio_keys_polled - suppress deferred probe error for gpio Date: Sun, 24 Mar 2024 19:36:52 -0400 Message-ID: <20240324234027.1354210-25-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit 963465a33141d0d52338e77f80fe543d2c9dc053 ] On a PC Engines APU our admins are faced with: $ dmesg | grep -c "gpio-keys-polled gpio-keys-polled: unable to claim gpio 0, err=-517" 261 Such a message always appears when e.g. a new USB device is plugged in. Suppress this message which considerably clutters the kernel log for EPROBE_DEFER (i.e. -517). Signed-off-by: Uwe Kleine-König Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20240305101042.10953-2-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/gpio_keys_polled.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index c3937d2fc7446..a0f9978c68f55 100644 --- a/drivers/input/keyboard/gpio_keys_polled.c +++ b/drivers/input/keyboard/gpio_keys_polled.c @@ -319,12 +319,10 @@ static int gpio_keys_polled_probe(struct platform_device *pdev) error = devm_gpio_request_one(dev, button->gpio, flags, button->desc ? : DRV_NAME); - if (error) { - dev_err(dev, - "unable to claim gpio %u, err=%d\n", - button->gpio, error); - return error; - } + if (error) + return dev_err_probe(dev, error, + "unable to claim gpio %u\n", + button->gpio); bdata->gpiod = gpio_to_desc(button->gpio); if (!bdata->gpiod) { -- 2.43.0