From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2F48179FBD; Sun, 24 Mar 2024 23:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323649; cv=none; b=fK9HfEEAdsAzfKhw4LikKtLBIc5Dv/6CdI6Aiyg3cvCt9QwZfLYjHP1HBmDLX9nD2jXW5tHqj2wJ4HmxNuMGpsYijLKXjzJ+Ek1S4Z/+Z1RR8xvRuZ7EaXcU1E9832RovSd/xpsTUKZtJyTOTxgPkuTVP14kw+xOrceQoibijv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323649; c=relaxed/simple; bh=Du80a8081lcmLcIyq1r2JOmgELaCBxEoYXMTEtF6bGQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J7WMEBdDhZrXZUdUq8CpYoOE/jdLCD4pJkrgWkPufn88mzAxIkKeA3oL3sys9AnuUFGL5zPBGqbSb9EjUcEcmDwu0KtXmdhWYWGhhVsHVr8UVt46QHI4g+Yz9hk+hm2MvNtCMpIba8MG/qaOThFIiXNzr0VlAAaORtmEiecakpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kXZL/o7I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kXZL/o7I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D1A2C433C7; Sun, 24 Mar 2024 23:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323649; bh=Du80a8081lcmLcIyq1r2JOmgELaCBxEoYXMTEtF6bGQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kXZL/o7IT25/uBFUTxGGnKVy1i7IIJO/iGfzogMkVm9W5RG/V8mC5rcXydJSOCKce DrsvMU2z2iHm5ZLvaSaph4UsLEEqNetSX2+7LUUzrWRKx0pjVgTFHwVnUUNAIo8UvK SzZWUN9OM7ljQCArGpalsIp0+rWXPdl8McjjxAhmmmsxSeSAY1eN7JlSRmK47UKLwA v7JKYatbQTEFzpghkwQAT8ftEgDX9hpwaZBTH+mm0yRFpn9S2x5Ox057QHsOIjFwuw +lNxWV69WtuBkOCCSrFeMbxIonUMAfv4nvEv9QMeZOnC76o4wdOKGj7AXDZCNOG4/p m8TRXxNNCDb4A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yuxuan Hu <20373622@buaa.edu.cn>, Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.10 021/238] Bluetooth: rfcomm: Fix null-ptr-deref in rfcomm_check_security Date: Sun, 24 Mar 2024 19:36:49 -0400 Message-ID: <20240324234027.1354210-22-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Yuxuan Hu <20373622@buaa.edu.cn> [ Upstream commit 2535b848fa0f42ddff3e5255cf5e742c9b77bb26 ] During our fuzz testing of the connection and disconnection process at the RFCOMM layer, we discovered this bug. By comparing the packets from a normal connection and disconnection process with the testcase that triggered a KASAN report. We analyzed the cause of this bug as follows: 1. In the packets captured during a normal connection, the host sends a `Read Encryption Key Size` type of `HCI_CMD` packet (Command Opcode: 0x1408) to the controller to inquire the length of encryption key.After receiving this packet, the controller immediately replies with a Command Completepacket (Event Code: 0x0e) to return the Encryption Key Size. 2. In our fuzz test case, the timing of the controller's response to this packet was delayed to an unexpected point: after the RFCOMM and L2CAP layers had disconnected but before the HCI layer had disconnected. 3. After receiving the Encryption Key Size Response at the time described in point 2, the host still called the rfcomm_check_security function. However, by this time `struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;` had already been released, and when the function executed `return hci_conn_security(conn->hcon, d->sec_level, auth_type, d->out);`, specifically when accessing `conn->hcon`, a null-ptr-deref error occurred. To fix this bug, check if `sk->sk_state` is BT_CLOSED before calling rfcomm_recv_frame in rfcomm_process_rx. Signed-off-by: Yuxuan Hu <20373622@buaa.edu.cn> Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/rfcomm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index 8d6fce9005bdd..4f54c7df3a94f 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -1937,7 +1937,7 @@ static struct rfcomm_session *rfcomm_process_rx(struct rfcomm_session *s) /* Get data directly from socket receive queue without copying it. */ while ((skb = skb_dequeue(&sk->sk_receive_queue))) { skb_orphan(skb); - if (!skb_linearize(skb)) { + if (!skb_linearize(skb) && sk->sk_state != BT_CLOSED) { s = rfcomm_recv_frame(s, skb); if (!s) break; -- 2.43.0