From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F6A6284522; Sun, 24 Mar 2024 23:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323784; cv=none; b=i1ceZrJlfQF4zyvyy70+O91PYWAapajXawjUUPCFVtm4wcYTIAc+I7SxhIUQnJ1v5WfF5WYqznGHOrBYUKJJ9WxHrOmqyd+jEvKMfOBtAodm2vAdDfrj0s191hdVvl88EO18DplU8LoUVQ5w7fDmmaJQ+GdG5jovzbU1nZojFKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323784; c=relaxed/simple; bh=ztQ8/XKKj53vrj2RHX4SHK5hJSeYb4qx+sJnAISMHI4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LoXrlCk/xmkf/jZs/e19jEFPZnVe2ugOFL4D5KD8/wPV4QooDuy/BsxhN6rhvcXVBtN05nVS2yZsHQ5Dpf2jJ/8wUroAs+rdmn04XsC0reD2RY+8aO++f42ue9HrMc5tigP3akHNc2xM21c2peSxI8FncfbXeuGvYSR4WuKIMMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KLrcnvIl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KLrcnvIl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F7D0C43390; Sun, 24 Mar 2024 23:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323783; bh=ztQ8/XKKj53vrj2RHX4SHK5hJSeYb4qx+sJnAISMHI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KLrcnvIlmtx65KSsNr82+7WoVI+EwmO0YRuMIVjoJkpRUAGJnVz+PQKcar7ln/cNA 4ffjATghIogVvjMPrfWezUOURNZjIIvj+QZLS1jc0+T9XLtflgkvhhSrWQkZQUhckG nmkhJzBvIrES6f5D+KtsfaoUP7XJ18vBismqRrm8OcEem49cQIkFwX3gQ6q2R1NYIR uCi41WnQXYBr5Mw4uxxJRDaE61AUoYDw7cOJBYTo+KweMpZS0RmwMKC2gpTYvv/O2A 8vb7wEi7jpYX5TM2FZ9ndu2E7eKKi2wCWaW9KPEJMZzN2GDLfTvI/PFH+G5XxwGwNA HHMZgJCirCUZA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?J=C3=B6rg=20Wedekind?= , Bjorn Helgaas , Sasha Levin Subject: [PATCH 5.10 160/238] PCI: Mark 3ware-9650SE Root Port Extended Tags as broken Date: Sun, 24 Mar 2024 19:39:08 -0400 Message-ID: <20240324234027.1354210-161-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jörg Wedekind [ Upstream commit baf67aefbe7d7deafa59ca49612d163f8889934c ] Per PCIe r6.1, sec 2.2.6.2 and 7.5.3.4, a Requester may not use 8-bit Tags unless its Extended Tag Field Enable is set, but all Receivers/Completers must handle 8-bit Tags correctly regardless of their Extended Tag Field Enable. Some devices do not handle 8-bit Tags as Completers, so add a quirk for them. If we find such a device, we disable Extended Tags for the entire hierarchy to make peer-to-peer DMA possible. The 3ware 9650SE seems to have issues with handling 8-bit tags. Mark it as broken. This fixes PCI Parity Errors like : 3w-9xxx: scsi0: ERROR: (0x06:0x000C): PCI Parity Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000D): PCI Abort: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000E): Controller Queue Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x0010): Microcontroller Error: clearing. Link: https://lore.kernel.org/r/20240219132811.8351-1-joerg@wedekind.de Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported") Closes: https://bugzilla.kernel.org/show_bug.cgi?id=202425 Signed-off-by: Jörg Wedekind Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b67aea8d8f197..646807a443e2d 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5364,6 +5364,7 @@ static void quirk_no_ext_tags(struct pci_dev *pdev) pci_walk_bus(bridge->bus, pci_configure_extended_tags, NULL); } +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_3WARE, 0x1004, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0132, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0140, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0141, quirk_no_ext_tags); -- 2.43.0