From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A133017C63D; Sun, 24 Mar 2024 23:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323776; cv=none; b=SyGsMnuWuO/5QGHYWohc7qEiiTyroCpBRgoM1dGuHk/0F1+kFKKlYrkEUS24vC36AnzdAtbocFBp2CobP6ximew9GJWQNq3v4aAbwEXhRzlO0LOgbi+tbL4KX5TgkuEV//izDjzK+nlSwWqqbnSlK4zeNxBbcnPNv6XzmUyl0aQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323776; c=relaxed/simple; bh=iYn8hq6s2Qn3vdHi8ZTdnpLNgfPLwVGSAJnvl2Q+Sfo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ru89oV7kaobrPrRm/aIUxt7VZq/MZ0VrNv/6NquD44K9pVHNCha0fwAQyrSlIw4vcwzfoZIwr5BO4wQ4bZdDKcohH0iu/Twu34UQREUgpemT6Tp+sNTrUeygDgevn5HVzjIQpTIUsrZ/Iwb3mb+SChScUgkqB73gosNb/gNhr0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=peVo8nRn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="peVo8nRn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E11DFC433C7; Sun, 24 Mar 2024 23:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323776; bh=iYn8hq6s2Qn3vdHi8ZTdnpLNgfPLwVGSAJnvl2Q+Sfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=peVo8nRnpwTd+ITZG/VehJI1g7VfswwfGgMm8CBCW/O1K8ZR/cF81loY++PmaJJoH gRTBDzL4RyRk8ctWxyL2mPBnMrmqNINAhajFMvaxFwlM8qIBP/Fsh9DLBL+JinoUlM ZMH2g8mlPhpA/mQuIQK/nYcdUlBV48SGtGuylg/GqmhZM0YCn8UmjTEBIY5WDTkpd7 0PxMA4AcFPoLYEhZop9dwLC1sXNuqXG/S1KYuSaMwyhZb0Vd7HxHt4Ch6bDGfUbJOr NKjIIY/fjJO5G7wJiNbUzJjo57b4TLeRTdsVKMvbmkkUOAwWkADN7eSahpAYcAsbcT 3mdk3NtTeV1xQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jernej Skrabec , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 152/238] media: sun8i-di: Fix power on/off sequences Date: Sun, 24 Mar 2024 19:39:00 -0400 Message-ID: <20240324234027.1354210-153-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jernej Skrabec [ Upstream commit cff104e33bad38f4b2c8d58816a7accfaa2879f9 ] According to user manual, reset line should be deasserted before clocks are enabled. Also fix power down sequence to be reverse of that. Fixes: a4260ea49547 ("media: sun4i: Add H3 deinterlace driver") Signed-off-by: Jernej Skrabec Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- .../media/platform/sunxi/sun8i-di/sun8i-di.c | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index a9d3272940be0..cb6d32c59191f 100644 --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c @@ -937,11 +937,18 @@ static int deinterlace_runtime_resume(struct device *device) return ret; } + ret = reset_control_deassert(dev->rstc); + if (ret) { + dev_err(dev->dev, "Failed to apply reset\n"); + + goto err_exclusive_rate; + } + ret = clk_prepare_enable(dev->bus_clk); if (ret) { dev_err(dev->dev, "Failed to enable bus clock\n"); - goto err_exclusive_rate; + goto err_rst; } ret = clk_prepare_enable(dev->mod_clk); @@ -958,23 +965,16 @@ static int deinterlace_runtime_resume(struct device *device) goto err_mod_clk; } - ret = reset_control_deassert(dev->rstc); - if (ret) { - dev_err(dev->dev, "Failed to apply reset\n"); - - goto err_ram_clk; - } - deinterlace_init(dev); return 0; -err_ram_clk: - clk_disable_unprepare(dev->ram_clk); err_mod_clk: clk_disable_unprepare(dev->mod_clk); err_bus_clk: clk_disable_unprepare(dev->bus_clk); +err_rst: + reset_control_assert(dev->rstc); err_exclusive_rate: clk_rate_exclusive_put(dev->mod_clk); @@ -985,11 +985,12 @@ static int deinterlace_runtime_suspend(struct device *device) { struct deinterlace_dev *dev = dev_get_drvdata(device); - reset_control_assert(dev->rstc); - clk_disable_unprepare(dev->ram_clk); clk_disable_unprepare(dev->mod_clk); clk_disable_unprepare(dev->bus_clk); + + reset_control_assert(dev->rstc); + clk_rate_exclusive_put(dev->mod_clk); return 0; -- 2.43.0