From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADAC12D76B; Sun, 24 Mar 2024 23:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321950; cv=none; b=SpB6fvxpf1fYYT8P9azotCnd9zxahvEVl0yUaFiJdVroQemLOEmnAWwcNW8SRgKSC0/C4kAU+NZKsFrXVCu3ET90HJlj/0bQ4NHSA8uXuKQq/QN7E+EcS4/1s8GEzoymIzOj83mKqh8cLNM1ajbc4+qT6ROZBW7KilMAGGho0+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321950; c=relaxed/simple; bh=f65IT3YJW0iM5S2hwJ/ZJqvbC+2+6g5WS+AfeSKUXOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a7dgkJzX3brVkKZ6qjnRXeI0xHafD9EIv63qQ81nlvtg3LtfFCLm4b00zl2QcME69GuDp+bErY/RbiTRrJHBTNHk7MidJaEHrDp/B284hko4uzhj4SvfTd92MwNNBsR7OnSsOZV/tnSvXdqs35nvL5MigtrIxEjp7F6ma+HqxQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nrFPAfzf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nrFPAfzf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D678C43390; Sun, 24 Mar 2024 23:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321950; bh=f65IT3YJW0iM5S2hwJ/ZJqvbC+2+6g5WS+AfeSKUXOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nrFPAfzfNJp7ZUEaAwfBxQYLe82WxPu40amS2Drfzx5OdN3AyF+R3NZGBoDcmRdz4 aHwFEieJ5V1nrISMTz37OaDygzckDwDJP5faB490YaEPEapiDlEGJrTSowCN39MXgA SL3T7CSQ0/c0uwaHeWVl7zS8mZvn4Lt+/Ikp/jfWJegCM3hTJ1/5o7ChudNsMcHieF Yht3/U6tNX/c0XaqNUDqQ7tY+bkcZM5e66IhmuhpDEdOLlv5a9ifWRi5ayJIRSSpMp G+jXn1JUJB4LGZpniD7WmB8zHsQtLqRNDvFQDbFyS9WRLX5m07xiuZXbMmVfJbC4GQ YX9NT0w6XMAYQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans de Goede , Mark Brown , Sasha Levin Subject: [PATCH 6.1 022/451] ASoC: rt5645: Make LattePanda board DMI match more precise Date: Sun, 24 Mar 2024 19:04:58 -0400 Message-ID: <20240324231207.1351418-23-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324231207.1351418-1-sashal@kernel.org> References: <20240324231207.1351418-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Hans de Goede [ Upstream commit 551539a8606e28cb2a130f8ef3e9834235b456c4 ] The DMI strings used for the LattePanda board DMI quirks are very generic. Using the dmidecode database from https://linux-hardware.org/ shows that the chosen DMI strings also match the following 2 laptops which also have a rt5645 codec: Insignia NS-P11W7100 https://linux-hardware.org/?computer=E092FFF8BA04 Insignia NS-P10W8100 https://linux-hardware.org/?computer=AFB6C0BF7934 All 4 hw revisions of the LattePanda board have "S70CR" in their BIOS version DMI strings: DF-BI-7-S70CR100-* DF-BI-7-S70CR110-* DF-BI-7-S70CR200-* LP-BS-7-S70CR700-* See e.g. https://linux-hardware.org/?computer=D98250A817C0 Add a partial (non exact) DMI match on this string to make the LattePanda board DMI match more precise to avoid false-positive matches. Signed-off-by: Hans de Goede Link: https://msgid.link/r/20240211212736.179605-1-hdegoede@redhat.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt5645.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 844d14d4c9a51..aac9140749968 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3802,6 +3802,16 @@ static const struct dmi_system_id dmi_platform_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), DMI_EXACT_MATCH(DMI_BOARD_VERSION, "Default string"), + /* + * Above strings are too generic, LattePanda BIOS versions for + * all 4 hw revisions are: + * DF-BI-7-S70CR100-* + * DF-BI-7-S70CR110-* + * DF-BI-7-S70CR200-* + * LP-BS-7-S70CR700-* + * Do a partial match for S70CR to avoid false positive matches. + */ + DMI_MATCH(DMI_BIOS_VERSION, "S70CR"), }, .driver_data = (void *)&lattepanda_board_platform_data, }, -- 2.43.0