From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9792A146004; Sun, 24 Mar 2024 23:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322067; cv=none; b=bFQdzwi4ORaNih4c6SlgivkxC01wKsvHvcixi8WXlEMfYrWiTAEzebYVnfY98nCr4qVTbeAgrvEOjygAD3UHEIrw2WfdQZEH+XiTl+ZhNgLMDAp31+qslc1bq6jebwoc37xwwgPbVEH7Y0KMeV26R+BWraZ0Pqc6l+O7bw+r3q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322067; c=relaxed/simple; bh=jubhwmrQUsrVgFdJLK6lEL3+DBrHBzq3x+JNYFWCb2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oNmU5dBe1viFt7uzrOu1VZLNwB/Tzi2NCsx/7d2B34MxTB4Nx5vtzYA9efgCeX8AyaoEey3fOdtWH5acqnNjfz523KvN/jcRHYXaet4OEIBZgKdNkpOifSuTcqeEk568BcAB7gu05PVEcvUjjsBJg5t7usRwFbBC31IE9aZ1nh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BvjhK9sg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BvjhK9sg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92613C43394; Sun, 24 Mar 2024 23:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711322067; bh=jubhwmrQUsrVgFdJLK6lEL3+DBrHBzq3x+JNYFWCb2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BvjhK9sgmVNzJjOPD/T1jSIzwi/vEgMulMzArYwGMDECXCY50ZUKdGZgsadccEQKM BRlPVOPtqjDBBSfuazn1TNLeUPRUV6TrLKebCnEv8qqEtBBnN+C3xJ81IN9GwbQGhF DJp3w380H6ZwWblxx/s743Ecjn2S2X87x1RHR7kv3qBZ0z+yN1CH04WzG0EHA3mB7n jBIKHgq9dKRxushHLF+lbv1Zyu8MNkF23gLAqNHl2V6K7S2xI0tq8+1QhSdXxV5cGH 5moRPE3QrqatfdPxOaO880gptXe9rrPhO6Y0wd28M2uXbQ6jCCSmpzxNw/EqywQWIl ge+Ek4gBsprXg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Eric Dumazet , Taehee Yoo , Cong Wang , David Ahern , "David S . Miller" , Sasha Levin Subject: [PATCH 6.1 140/451] ipv6: mcast: remove one synchronize_net() barrier in ipv6_mc_down() Date: Sun, 24 Mar 2024 19:06:56 -0400 Message-ID: <20240324231207.1351418-141-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324231207.1351418-1-sashal@kernel.org> References: <20240324231207.1351418-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Eric Dumazet [ Upstream commit 17ef8efc00b34918b966388b2af0993811895a8c ] As discussed in the past (commit 2d3916f31891 ("ipv6: fix skb drops in igmp6_event_query() and igmp6_event_report()")) I think the synchronize_net() call in ipv6_mc_down() is not needed. Under load, synchronize_net() can last between 200 usec and 5 ms. KASAN seems to agree as well. Fixes: f185de28d9ae ("mld: add new workqueues for process mld events") Signed-off-by: Eric Dumazet Cc: Taehee Yoo Cc: Cong Wang Cc: David Ahern Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv6/mcast.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 566f3b7b957e9..a777695389403 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -2722,7 +2722,6 @@ void ipv6_mc_down(struct inet6_dev *idev) /* Should stop work after group drop. or we will * start work again in mld_ifc_event() */ - synchronize_net(); mld_query_stop_work(idev); mld_report_stop_work(idev); -- 2.43.0