From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5953B14EC6E; Sun, 24 Mar 2024 23:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321324; cv=none; b=FyBcKeAsq8LREPANyB5WJSyJUKwzr1lYvpY3vd1AcEGVnfrc5ciYuALuiqo7Sa+7gjE6eelxcgkazI8S3RLqXjN/PZqaRuzGTpapP1x+XRwDC5IuZWyOYEU//fbfYKkuhrTdAAQygPE/ukTxmj3t+C7x8JkPKiDoYlJz3z2PI1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321324; c=relaxed/simple; bh=S9i6rVDTLrc92ZdyKfg4Ixk7H6eGpB3PH6E05e+MPh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m9V5ERgnMijAd9vB4prs9mllnDYQC+SjJstWjz0WO4wysPV1NJ5zq/V1aKOUlAUtmVD4A6Pv6JoMZZrdUvTKonvtB59lMNwz8cEpGB64wG/FrF09EauNBBHjuMKmsJOQqLS+tiuiSYSS2LI+xP7SlMoS4BrxgBmCdoyWygzZKHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SXjzIX/i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SXjzIX/i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A3D4C43394; Sun, 24 Mar 2024 23:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321323; bh=S9i6rVDTLrc92ZdyKfg4Ixk7H6eGpB3PH6E05e+MPh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SXjzIX/iH6QFscj9a1f9+LtfwqGB/fwcUqRBJIGZravSle0gLegkGHzFqfn9rZ7Qc T/k+r7vm+9wOgsJekqivTXUHhGB99SMTwCB4WJ2LB0+6oHbOz5BOGsQSImikE5UGTO 54o/45L2TssKziCLToJ3tNHWlBpAdin7H0Nlutk9bzOqXh1zE9TxZUYww9BpvQy+GA RoTZVrKO578aW3CeaBQKLZUQ21Q3v8Cmul4U6UkarpQ5srTxsY95VnWaRow6ty2c5b h2kMqMX1G1Y31f6SehJWYmQFAmaz1/6Q1RrNe2jp8mDHtGmJALjbAVB3OCdRksdFQF pzQgJHEUsc2jw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Felix Fietkau , Johannes Berg , Sasha Levin Subject: [PATCH 6.6 046/638] wifi: mac80211: only call drv_sta_rc_update for uploaded stations Date: Sun, 24 Mar 2024 18:51:23 -0400 Message-ID: <20240324230116.1348576-47-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Felix Fietkau [ Upstream commit 413dafc8170fcb925fb17af8842f06af305f8e0b ] When a station has not been uploaded yet, receiving SMPS or channel width notification action frames can lead to rate_control_rate_update calling drv_sta_rc_update with uninitialized driver private data. Fix this by adding a missing check for sta->uploaded. Signed-off-by: Felix Fietkau Link: https://msgid.link/20240221140535.16102-1-nbd@nbd.name Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/rate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index d5ea5f5bcf3a0..9d33fd2377c88 100644 --- a/net/mac80211/rate.c +++ b/net/mac80211/rate.c @@ -119,7 +119,8 @@ void rate_control_rate_update(struct ieee80211_local *local, rcu_read_unlock(); } - drv_sta_rc_update(local, sta->sdata, &sta->sta, changed); + if (sta->uploaded) + drv_sta_rc_update(local, sta->sdata, &sta->sta, changed); } int ieee80211_rate_control_register(const struct rate_control_ops *ops) -- 2.43.0