From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BE920124F; Sun, 24 Mar 2024 23:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321400; cv=none; b=elTN+6gSUOJZTmIyjGvAAEKYrTe4O4A+lvqd1MrLYxyPt0OaOnfYhqlUNfEd5KwLefC4zZbNiwEZyytr2p4K3t1y/kfXKL/kA5gDwuQ7z6Iaz9GFuF1+CW6DOnlI9zDpiokOhurb0Qx8frSlcjDUfZfxMQf4bTNmGSAA4tEcPNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321400; c=relaxed/simple; bh=60vo75mBcZsaaWRfia1pLHWloNQ83WhNjty4gGNM0pg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RXzWQPWSWg2Ci63wI7Bcgn+ton61QVbpB77eItsdISukwEm+INM3roaAt/246wU+M+P4z2nTGiZwljpm8a8beggSAtFG6SO/c3ub2uU4RXpezF6xFq8xNXNsodIilDobNHZFzWdeFUhKVdbc82r/EPABBtsi+437xwLz/WpR2Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ATCeXs4E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ATCeXs4E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB6CAC43399; Sun, 24 Mar 2024 23:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321399; bh=60vo75mBcZsaaWRfia1pLHWloNQ83WhNjty4gGNM0pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ATCeXs4Ea5v5rMysJmtWoRq6DicMVTx7aH564fdAztM3zbV/Sxthve5b4nkgLvw7l lUyDqYRS5lwkhRe68YmTNyly0qZxxYOn4uxqxS5IpmPGw/MySd3K68LzsiUXkf17cU qUnsT8IuB0FarveKl1iRkihmvsAwbrQZ829v6uYZ/RatMqCPT7x3u5Sv9gks3yYnmo qhuiS4pm5i9j2EWUCELs5R4TF272mryhKwwEWBHImrBXBn0NH1pecBIJKpup+gpavH YmvNvuH+qgEhFWtgFQ6sLXFtkDfk5hvHLaMnv19TaTmGjet6gGwCrXcAQz0ob4szdb RQyOj0I/85Xdg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jinjie Ruan , Russell King , Kalle Valo , Sasha Levin Subject: [PATCH 6.6 123/638] wifi: mwifiex: debugfs: Drop unnecessary error check for debugfs_create_dir() Date: Sun, 24 Mar 2024 18:52:40 -0400 Message-ID: <20240324230116.1348576-124-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jinjie Ruan [ Upstream commit 50180c7f8e3de7c2d87f619131776598fcb1478d ] debugfs_create_dir() returns ERR_PTR and never return NULL. As Russell suggested, this patch removes the error checking for debugfs_create_dir(). This is because the DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in start_creating() which can handle it gracefully. So these checks are unnecessary. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Jinjie Ruan Suggested-by: Russell King (Oracle) Signed-off-by: Kalle Valo Link: https://msgid.link/20230903030216.1509013-3-ruanjinjie@huawei.com Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c index f9c9fec7c792a..d14a0f4c1b6d7 100644 --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c @@ -970,9 +970,6 @@ mwifiex_dev_debugfs_init(struct mwifiex_private *priv) priv->dfs_dev_dir = debugfs_create_dir(priv->netdev->name, mwifiex_dfs_dir); - if (!priv->dfs_dev_dir) - return; - MWIFIEX_DFS_ADD_FILE(info); MWIFIEX_DFS_ADD_FILE(debug); MWIFIEX_DFS_ADD_FILE(getlog); -- 2.43.0