From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BF61D2A89; Sun, 24 Mar 2024 22:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320537; cv=none; b=oWsYlFc210Vlig+g/0Jhgurkm+JOVj8fe9hyngwgJMD/UejF5t2ughsCkqlcjp1ETkkzuJ9TjjNGftyZ1sQSv4SoAkHsEcdC+xxPIwOQWdQjdvIMWZ/Ag/y1tZlrX48vm+sxVAETy5IrP9JJJ8jV5MSr02sPLI73Au9D9JoluYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320537; c=relaxed/simple; bh=XuA+8nGkGj4xp7oyuXzOhHBuT5R9Q9Rrl3+R1s6tAsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QoiqGIqLdnjeQ9kUB0l3a0go+DsFiMltqRwe+0cHg3hikn86ILJwVXDXQ3Pnc0Ka4w+6Lq16IjHBnRizWOuOw3qtZsiempOI9Spert/i8sELQlIfQZevanNgv3vnsw4MzNMD5deQjcFXDKREgUjv/WqBVaC062ueC9mnYdfajuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CEdqcoRc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CEdqcoRc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D50D6C43394; Sun, 24 Mar 2024 22:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320536; bh=XuA+8nGkGj4xp7oyuXzOhHBuT5R9Q9Rrl3+R1s6tAsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CEdqcoRcuGNUa7tUtfHeUY6YJkW6bYvND0zCz2TxybrJbhnluXpHv+0XOMKt5YuE0 9rx+fcPlNHg6q0C0OImznsXOkRPGcq4cv75XRe7S8XeLiEv9bN/55DCTSGvhg7bWi/ s6g47hfMHrGZ5RdEP6sdap4+IEURjO411xK53b8/VXkHrP+tiYv4c7fHFLs+4dnFa4 hNCWtm/9Cvc9XpStK+Jfvc47IWsvuFCbMHTc/JpHR3B5NZk2WZcjjOV6YESTZN0pF0 GFyIg0O91J2UEa6QPjUQYxJmuRedqJ9DYnHn1PdFsmHBnJsP4ujCX9m/vRTUQbeMun eilbW8ZydnCGw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Li Nan , Song Liu , Sasha Levin Subject: [PATCH 6.7 098/713] md: fix kmemleak of rdev->serial Date: Sun, 24 Mar 2024 18:37:04 -0400 Message-ID: <20240324224720.1345309-99-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Li Nan [ Upstream commit 6cf350658736681b9d6b0b6e58c5c76b235bb4c4 ] If kobject_add() is fail in bind_rdev_to_array(), 'rdev->serial' will be alloc not be freed, and kmemleak occurs. unreferenced object 0xffff88815a350000 (size 49152): comm "mdadm", pid 789, jiffies 4294716910 hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace (crc f773277a): [<0000000058b0a453>] kmemleak_alloc+0x61/0xe0 [<00000000366adf14>] __kmalloc_large_node+0x15e/0x270 [<000000002e82961b>] __kmalloc_node.cold+0x11/0x7f [<00000000f206d60a>] kvmalloc_node+0x74/0x150 [<0000000034bf3363>] rdev_init_serial+0x67/0x170 [<0000000010e08fe9>] mddev_create_serial_pool+0x62/0x220 [<00000000c3837bf0>] bind_rdev_to_array+0x2af/0x630 [<0000000073c28560>] md_add_new_disk+0x400/0x9f0 [<00000000770e30ff>] md_ioctl+0x15bf/0x1c10 [<000000006cfab718>] blkdev_ioctl+0x191/0x3f0 [<0000000085086a11>] vfs_ioctl+0x22/0x60 [<0000000018b656fe>] __x64_sys_ioctl+0xba/0xe0 [<00000000e54e675e>] do_syscall_64+0x71/0x150 [<000000008b0ad622>] entry_SYSCALL_64_after_hwframe+0x6c/0x74 Fixes: 963c555e75b0 ("md: introduce mddev_create/destroy_wb_pool for the change of member device") Signed-off-by: Li Nan Signed-off-by: Song Liu Link: https://lore.kernel.org/r/20240208085556.2412922-1-linan666@huaweicloud.com Signed-off-by: Sasha Levin --- drivers/md/md.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/md.c b/drivers/md/md.c index 58889bc72659a..0b49033afa6bc 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2582,6 +2582,7 @@ static int bind_rdev_to_array(struct md_rdev *rdev, struct mddev *mddev) fail: pr_warn("md: failed to register dev-%s for %s\n", b, mdname(mddev)); + mddev_destroy_serial_pool(mddev, rdev); return err; } -- 2.43.0