From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D061DF7A7; Sun, 24 Mar 2024 22:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321021; cv=none; b=Ck4Ykt/PiE9QseqOxP5sdGKZT15yTeHEZYzXMkCosJbsScdTkQFg/IlH/TcXeVFbgAdFMvhbeEKrYhRUvizcEW0CS/4l9+tMqrjwym/D+AdU37a/IvhqnCdrFcEXh3G/JOerloKUNuHva3m7ZfiiaocxRR/CRJZ2i6S9SUtHeYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321021; c=relaxed/simple; bh=DnIEbnQD9ob1MO8/v30ZkD/ZbTdidfNE4UviQRjCoEE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GGt+ucxNdK67tZrSm8EOk+yp/c+6gQjbN2uarrSg3dvV3ZlcGn6G/3XI3qBZVQ+T3el8afAbc+dtbeKHTCS2jNeF4EZ/XK1tgZB0u+57Jph5MHM+Rk1/7ykQvoOwuIcht1NrGDqnvOlJej1Eptd9iBngopk5Iirgz8t3WcDhKhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d/UJPF6a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d/UJPF6a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9712C433F1; Sun, 24 Mar 2024 22:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321021; bh=DnIEbnQD9ob1MO8/v30ZkD/ZbTdidfNE4UviQRjCoEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d/UJPF6aggbyvwY/hws/WfWqFudFI8et+5oqdmbLUeVjtiCdSJlqnZPahfzM5Zz3o QItexT1TbK2ZUjIUbf/dPwMna/bhxb/I22yex5yeDbnIArq5jFgomg1k0Jv94ZCBda QkGdDMVHrbjz2GtrILeBxBd2giS+GEpDgaNylU7nYGV6bbHGTvhv0ROyLr/KMpJVGe lxqxJ9x+eyXpZrrWZbAa/XNPQGI4XSJQnCnFa3erB5blNv20+/6dYnuLMiBrksEsjd cHAmXZgsik1Q6wt+aD8C/KUoD2Purfc2WVLvgSLeAzR5WZ9Dt0RU/gpRfC8ctZWSuA SCTvfzVAEFsgw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexey Kodanev , Jack Wang , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.7 584/713] RDMA/rtrs-clt: Check strnlen return len in sysfs mpath_policy_store() Date: Sun, 24 Mar 2024 18:45:10 -0400 Message-ID: <20240324224720.1345309-585-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Alexey Kodanev [ Upstream commit 7a7b7f575a25aa68ee934ee8107294487efcb3fe ] strnlen() may return 0 (e.g. for "\0\n" string), it's better to check the result of strnlen() before using 'len - 1' expression for the 'buf' array index. Detected using the static analysis tool - Svace. Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy") Signed-off-by: Alexey Kodanev Link: https://lore.kernel.org/r/20240221113204.147478-1-aleksei.kodanev@bell-sw.com Acked-by: Jack Wang Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c index d3c436ead6946..4aa80c9388f05 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c @@ -133,7 +133,7 @@ static ssize_t mpath_policy_store(struct device *dev, /* distinguish "mi" and "min-latency" with length */ len = strnlen(buf, NAME_MAX); - if (buf[len - 1] == '\n') + if (len && buf[len - 1] == '\n') len--; if (!strncasecmp(buf, "round-robin", 11) || -- 2.43.0