From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A521BD5EB; Sun, 24 Mar 2024 22:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320320; cv=none; b=HHM4fxtMLEmDZSDgewRDLHCv82DhtoodFNJ6WnjXC2MM+1F0p3cJH1KUEiEnOUnmlRzzWxFzNp0OgRd3U7wJmdmA293OnasnY8LBxDnNWDSE6ZN/4Oypk2RhlskNGvRVQmDYgpVfQBLUYY5qYMDaAmIYxCYkzF9WrInfA7Dt3T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320320; c=relaxed/simple; bh=AcjHXO0Hh108C+In5UCWd0oFxN4M2YjPIj9Da/8FyXQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JWoh5nZhSkgY/dih9L+LuD5ub9OmapP58N0Jy9JaqMoYr6/7IXmyxuC35x0s6HUT1aY6MNqDqf77kn9z1gVp7aoq+kVwbzzB2aRE37r6vIdenmYblgg7gDKZpjCTIbd6xi72SeE/OtZ+cbB6WkOmj3T6HYEeJCwdDkSWt6d/Cdg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jUVVvClm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jUVVvClm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48134C433A6; Sun, 24 Mar 2024 22:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320320; bh=AcjHXO0Hh108C+In5UCWd0oFxN4M2YjPIj9Da/8FyXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jUVVvClmgnyd+7OqhTduhW8hl3Mc3NUmwjU3Ndo4ATNs1MWdJSzWePQT2KT4B2Odg 3trPadqqjca1ZZQd1FjtuWrX/jo/OkN0pBJDhiUAtosKSVJtHXUwgV+K57ctaucOFx AgryI+QluVp762VdjDQcG7nhnt00fase0kpxRUIbAr1nxu5hFHX1hqDxSJ2zfwbJ/P o35hg6bNrQFlrrpLcxhPmy3zIyXC7ycL07KPhD8UqvRbTxoxqtK/Ja2pAkfT0hhBzN 9ydZ+pdSMcfBk+LNw8Q1gXWxx4ziEtRk/HopgRzIotLoDYeyxA2ytCeWdgHw6D1XLS ffoI4HADmLvNw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin , AngeloGioacchino Del Regno , Sasha Levin Subject: [PATCH 6.8 627/715] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Sun, 24 Mar 2024 18:33:26 -0400 Message-ID: <20240324223455.1342824-628-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Randy Dunlap [ Upstream commit 544c42f798e1651dcb04fb0395219bf0f1c2607e ] IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Randy Dunlap Link: https://lore.kernel.org/r/20240213050258.6167-1-rdunlap@infradead.org Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index e37a4341f442d..c63e32d012f23 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1858,7 +1858,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31234C47DD9 for ; Sun, 24 Mar 2024 22:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b6Il1KL8AdZXcxUxVKpRpoRsgc3ctgEpsrMdsu5l7aU=; b=wPUJ8PmDv5Eocz 8Zi26JLTe99dN6BMKUM8cb0srWK6Wp+5SnW14oe33jSFNM1DU8klkks4B6aeQsAxTKajhBR3dbdmR 4WBe+JnXHwVCGwzTsMB/Aa4PZnLSp5wtYiPD7nyCVF3TvJ03jQLmqt3+JT9BSEHDVzEhcS6Q2p2Ar nww566xoE/TqZ0TIyA2wSiVXlmT0XwW5DAsmduM2kFfTorpgl/FvYh7bnRv8/i/j//OxsB3MNIxDG maUBgKd5cunYgBul/Yys20p0V5rZYwPGkS+WIgeg8SogsOrD/dOT1uumsSRP5ImlBLT4bgy2z9ILC VMimsi0AFZgDXFfEnCqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roWai-0000000DfCR-3YPU; Sun, 24 Mar 2024 22:45:24 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roWag-0000000DfAh-1VMM; Sun, 24 Mar 2024 22:45:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 64C10CE0E5D; Sun, 24 Mar 2024 22:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48134C433A6; Sun, 24 Mar 2024 22:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320320; bh=AcjHXO0Hh108C+In5UCWd0oFxN4M2YjPIj9Da/8FyXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jUVVvClmgnyd+7OqhTduhW8hl3Mc3NUmwjU3Ndo4ATNs1MWdJSzWePQT2KT4B2Odg 3trPadqqjca1ZZQd1FjtuWrX/jo/OkN0pBJDhiUAtosKSVJtHXUwgV+K57ctaucOFx AgryI+QluVp762VdjDQcG7nhnt00fase0kpxRUIbAr1nxu5hFHX1hqDxSJ2zfwbJ/P o35hg6bNrQFlrrpLcxhPmy3zIyXC7ycL07KPhD8UqvRbTxoxqtK/Ja2pAkfT0hhBzN 9ydZ+pdSMcfBk+LNw8Q1gXWxx4ziEtRk/HopgRzIotLoDYeyxA2ytCeWdgHw6D1XLS ffoI4HADmLvNw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin , AngeloGioacchino Del Regno , Sasha Levin Subject: [PATCH 6.8 627/715] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Sun, 24 Mar 2024 18:33:26 -0400 Message-ID: <20240324223455.1342824-628-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240324_154522_601764_E740ACCE X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Randy Dunlap [ Upstream commit 544c42f798e1651dcb04fb0395219bf0f1c2607e ] IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Randy Dunlap Link: https://lore.kernel.org/r/20240213050258.6167-1-rdunlap@infradead.org Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index e37a4341f442d..c63e32d012f23 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1858,7 +1858,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel