From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4626D18A711; Sun, 24 Mar 2024 22:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320069; cv=none; b=F5Km6h2O7F8tHcAD6ouCRIOr4DFJfJnFOtgd3BUINZYM6fY1bWmmmDPRfsiFpdsWsY5ERDUJvqT+xc/munv/Fp0A4mUS5cMbW1C10dyl6hu6kxsglvioMvo9MoMcv4a6jBKY77psr27yM1YaZgXJO28lC+o6lksGKojBEgv6dVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320069; c=relaxed/simple; bh=ScdJiw+URJuyh2T7e7ak8jdhuXXwsn0SgimfE69B4C0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XPC6seWBbraAkdAp5spDg6HYEJJXvktZGKcz9IEApY95SFhmFI3CWb4zmTutVfQPJh7YeDtUUezLal8vMHcH1eoP/JxXGapHyIU7aRmXR3X0Q4gHHuwd4IPDutOzyFV1MZx/P2hcCeXhgsmDghdJ9/Dvzk4+etpMNKpOzPJr4WI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OlO2AUgr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OlO2AUgr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA07CC433B1; Sun, 24 Mar 2024 22:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320068; bh=ScdJiw+URJuyh2T7e7ak8jdhuXXwsn0SgimfE69B4C0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OlO2AUgrGEg0dAeLPb799rs/MMfp8nfmij5qMYv+Gupdpko3O2TLjheSFtWLAWnIA RhvnLfa+Zmw6IOYGiQtu6QkVKiB6sL5rvfD6UlOUCWfnjk5EYlyMlnoaT08tHVlWGZ 03Hh+O7OlOC988QDIyxcpuUc4yRFOz7eh3EdKoqIl0RQc7qGHIN0FEGj7afLqjFlP6 G266tM5ryWwALpToY76QKQ/6gbP76f3KWJaYd82+dVfnoSR2jyFz775ZG8pQ3SHLJw Y3USvIqFHvtviC0IeM9JjKcC+YapAnp+yVQBPgQiNf/qRotlAWkj4CBJSt2cA8CjBV QKSEtwUNUPukA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Alex Hung , Qingqing Zhuo , Rodrigo Siqueira , Aurabindo Pillai , Alex Deucher , Harry Wentland , Sasha Levin Subject: [PATCH 6.8 378/715] drm/amd/display: Fix a potential buffer overflow in 'dp_dsc_clock_en_read()' Date: Sun, 24 Mar 2024 18:29:17 -0400 Message-ID: <20240324223455.1342824-379-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit 4b09715f1504f1b6e8dff0e9643630610bc05141 ] Tell snprintf() to store at most 10 bytes in the output buffer instead of 30. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1508 dp_dsc_clock_en_read() error: snprintf() is printing too much 30 vs 10 Fixes: c06e09b76639 ("drm/amd/display: Add DSC parameters logging to debugfs") Cc: Alex Hung Cc: Qingqing Zhuo Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Harry Wentland Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c index 68a8463239127..85fc6181303bb 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c @@ -1483,7 +1483,7 @@ static ssize_t dp_dsc_clock_en_read(struct file *f, char __user *buf, const uint32_t rd_buf_size = 10; struct pipe_ctx *pipe_ctx; ssize_t result = 0; - int i, r, str_len = 30; + int i, r, str_len = 10; rd_buf = kcalloc(rd_buf_size, sizeof(char), GFP_KERNEL); -- 2.43.0