From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74E74180B9A; Sun, 24 Mar 2024 22:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320022; cv=none; b=umDYVg4Nn3qotlIUM1uzVSs0Of4KdLGXwDxWyGI8AUzi8NL4md732ArM930x2nApxivjrc6FI/QtMl2T8cyj6UGcvQM8v/DjTzDlaq4yOB/UbcQGpT23rEKnFwOT4b8/fsNZOM+49SLX5Qs29LyxoKIdpUp+9k4XRciEbGG6POg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320022; c=relaxed/simple; bh=vP825Ku2Y5fpQtvsySFA7Z6w4KP+omheovnqVtB+F0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E+7abthOQwiN9pfh2v9hd5u5bvQSajTEcu99GS0Cpovu2Ugc4HRlZ7Mg3X+YFjBIWpT8v5arGEdg61ctI8QHMiifjhtTySvUt5AUbyvydcJuMqm5UT6cdusblvsS8S1TCtvnUJb7YcfSdK+fyoGASWIBCclIhfSDBcLKbkOtBOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H4gVxb9E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H4gVxb9E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B69BCC433A6; Sun, 24 Mar 2024 22:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320022; bh=vP825Ku2Y5fpQtvsySFA7Z6w4KP+omheovnqVtB+F0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H4gVxb9EJQBbnIzVWnlknzNh62vVXNlHs1NTzHbUC/wtIcY9Si2ozdf7XrB9s7qYL sGfTg9Ajr13stJvqiVlnfgde0toZgYbkcE55zoAtGKICyJz2Wu4Z4edESScPRbRfI1 i0Wa7e3xubN25KykRJDGSlll4W2q/dJmfHY9oM6j6hZefTD5jXqHcMOVdvj+2CKkHr rqetDkZ2HLaGhrmFsNStbaHr0MSm2GaN1aHntcyaOOaTEmi8nYFh17rdz3bSbQlxF+ h1myY6Z/LyIy2pjAiQsWy146vJCtcvKR/oDC42CE0oV7juLdcmQXMMxW7+I9iFtXvo 3d7k6TpBvaaxw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jijie Shao , "David S . Miller" , Sasha Levin Subject: [PATCH 6.8 330/715] net: hns3: fix wrong judgment condition issue Date: Sun, 24 Mar 2024 18:28:29 -0400 Message-ID: <20240324223455.1342824-331-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jijie Shao [ Upstream commit 07a1d6dc90baedcf5d713e2b003b9e387130ee30 ] In hns3_dcbnl_ieee_delapp, should check ieee_delapp not ieee_setapp. This path fix the wrong judgment. Fixes: 0ba22bcb222d ("net: hns3: add support config dscp map to tc") Signed-off-by: Jijie Shao Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3_dcbnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_dcbnl.c b/drivers/net/ethernet/hisilicon/hns3/hns3_dcbnl.c index 3b6dbf158b98d..f72dc0cee30e5 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_dcbnl.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_dcbnl.c @@ -76,7 +76,7 @@ static int hns3_dcbnl_ieee_delapp(struct net_device *ndev, struct dcb_app *app) if (hns3_nic_resetting(ndev)) return -EBUSY; - if (h->kinfo.dcb_ops->ieee_setapp) + if (h->kinfo.dcb_ops->ieee_delapp) return h->kinfo.dcb_ops->ieee_delapp(h, app); return -EOPNOTSUPP; -- 2.43.0