From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30156CDDF; Sun, 24 Mar 2024 22:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319726; cv=none; b=EJ8bN+Pomj4IFwsALjL01CFdv+CHpIIZUYN6/xI4yKV/wkLr8UGVyJABBmnz2x8EcpJuN+O0bIC+xm/XhfvNqzKzrVpleYbXDYmU8vDyAw6q8nSf8aiUuEJoscG2BcEx5nryooP/tq9s1uW6FAgtkwnqK4lKtUK+3p6Z8AqFrVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319726; c=relaxed/simple; bh=kcjCwDbEJD49FCkn7bWPsxt2uts52PTkJf8FWlS/DAE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LrZ/kagZnJATaoeKQTqhnHOseecuk01hMqndGbuEpAmuNL10YaOAnUJBxrvxUJ8HJYhqpgMz1F98QDsAJ+8Kr+fJWCkck7p07CJktJmEZy/rSSsowyd5lhloXohlJDpoUhGVM8FdsEn29H2EhJplm9Fjo3jYv5bXYPHxre87HxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g4HSJJqq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g4HSJJqq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C652C43399; Sun, 24 Mar 2024 22:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711319726; bh=kcjCwDbEJD49FCkn7bWPsxt2uts52PTkJf8FWlS/DAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g4HSJJqqKGlxdGpcT5rJiXw1C/IvAoxCdtZxXPALN7yNikhdMW5kfFfMU+Kzrnnfk NN0x+mpIMNWHJm8XiJmnQl0kOHipfPkvyXnH4Ih5Msd+VNpczCgG7Jm0LmkL7GiPxk iiYXf5yQj2bLblQZEEWKmhv/KLlOq9USb8SXWcchrXCnthb7XNxs9JsfzDPPzpcoJI 79rN3nmh455mvlcOM1NEJ2RdYLwhXXtsYojrkuh0NK+vrrfgfVW14ErqMDGh99yDtK 3HTNPH2JQN8SNgiX7gV502/By41lhcjA95d5iK8REqbycf+w7elNF3tPTfSdCmF8n4 27AOb14G6gzOA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: David Gow , Guenter Roeck , Justin Stitt , Daniel Latypov , Rae Moar , Shuah Khan , Sasha Levin Subject: [PATCH 6.8 028/715] kunit: test: Log the correct filter string in executor_test Date: Sun, 24 Mar 2024 18:23:27 -0400 Message-ID: <20240324223455.1342824-29-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: David Gow [ Upstream commit 6f2f793fba78eb4a0d5a34a71bc781118ed923d3 ] KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(), but passed a random character from the filter, rather than the whole string. This was found by annotating KUNIT_ASSERT_EQ_MSG() to let gcc validate the format string. Fixes: 76066f93f1df ("kunit: add tests for filtering attributes") Signed-off-by: David Gow Tested-by: Guenter Roeck Reviewed-by: Justin Stitt Reviewed-by: Daniel Latypov Reviewed-by: Rae Moar Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- lib/kunit/executor_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c index 22d4ee86dbedd..3f7f967e3688e 100644 --- a/lib/kunit/executor_test.c +++ b/lib/kunit/executor_test.c @@ -129,7 +129,7 @@ static void parse_filter_attr_test(struct kunit *test) GFP_KERNEL); for (j = 0; j < filter_count; j++) { parsed_filters[j] = kunit_next_attr_filter(&filter, &err); - KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter '%s'", filters[j]); + KUNIT_ASSERT_EQ_MSG(test, err, 0, "failed to parse filter from '%s'", filters); } KUNIT_EXPECT_STREQ(test, kunit_attr_filter_name(parsed_filters[0]), "speed"); -- 2.43.0