From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AFB132492; Sun, 24 Mar 2024 22:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319822; cv=none; b=H7PKMHyIEy45Ing8Pu7ymAiWnj0LGH88hi8mLUuDpCUuzTPhXitMVmV0YqD12AihEPOmlyhRRhgua9gG9D4hBUO5USwYqXLMXaBmORPv/w3TdBz1T6f6G6urexCEfFYlJdqtQXdqpZLerpjW03TipmpsiHR2R2EMud/3ZsuSkBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319822; c=relaxed/simple; bh=CCMTvASji0/stHiT5ImMEo2vqL9mPQDDspFCl9RXgnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KAf28DxIsPUM45o/9mXyr1TDtVgrYMr1q6LOFP8e2995g1khMKBMStmtun7G2GF+5ZJbYXSww+vwJ5I+IVadORn/eqkWn+jnI+aeQLrXInobdHpQ7/f6ftwYHCWiSo6s9NmZ0oCG2LIjzLQwg5O0ciIi0lu8h6wxiVGVpiAyOyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=plO59LZM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="plO59LZM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 505D7C43394; Sun, 24 Mar 2024 22:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711319822; bh=CCMTvASji0/stHiT5ImMEo2vqL9mPQDDspFCl9RXgnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=plO59LZMxM2D1ai6tS0+AVbxeNPsEgDW4/FCynbQfAmkcbz9SaFHpOTVqXuu83Fzo dmuObQz/K7RJA/AwoYslTiFG3rIGZusVbDTcy/wJ2EY4lanzFtAR9uQPJ4nkd/BWPc IS/HJo3qUBoSFGUTYAPZw4N46uH/yvjCni2hvqnuBMCT4NxbLQczwlsiw+25+hxsTw T0SALn8VHaN+GsDja781YldPUZVQCxkkuboIjWhoIxFj4Q0+1Aa0JXvhAi83LwZyV8 uMnB0+uGQI5rk7QteOF065IY8xheckGymLmPVmwT0Gp0OnWZIQifVuAp5x5P6IQxVZ eIgPpX/JOdBjw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Raj Kumar Bhagat , Jeff Johnson , Kalle Valo , Sasha Levin Subject: [PATCH 6.8 124/715] wifi: ath12k: fix fetching MCBC flag for QCN9274 Date: Sun, 24 Mar 2024 18:25:03 -0400 Message-ID: <20240324223455.1342824-125-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Raj Kumar Bhagat [ Upstream commit 902700d55d4a4522bb3eb4ef94f752a19c42230a ] In QCN9274, RX packet's multicast and broadcast(MCBC) flag is fetched from RX descriptor's msdu_end info5 member but it is not correct for QCN9274. Due to this with encryption, ARP request packet is wrongly marked as MCBC packet and it is sent to mac80211 without setting RX_FLAG_PN_VALIDATED & RX_FLAG_DECRYPTED flag. This results in packet getting dropped in mac80211. Hence ping initiated from station to AP fails. Fix this by fetching correct MCBC flag in case of QCN9274. For QC9274 MCBC flag should be fetched from RX descriptor's mpdu_start info6 member. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1 Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Fixes: 8f04852e90cb ("wifi: ath12k: Use msdu_end to check MCBC") Signed-off-by: Raj Kumar Bhagat Acked-by: Jeff Johnson Signed-off-by: Kalle Valo Link: https://msgid.link/20240129065724.2310207-5-quic_rajkbhag@quicinc.com Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath12k/hal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c index a489369d80687..1bdab8604db94 100644 --- a/drivers/net/wireless/ath/ath12k/hal.c +++ b/drivers/net/wireless/ath/ath12k/hal.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: BSD-3-Clause-Clear /* * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved. */ #include #include "hal_tx.h" @@ -449,8 +449,8 @@ static u8 *ath12k_hw_qcn9274_rx_desc_mpdu_start_addr2(struct hal_rx_desc *desc) static bool ath12k_hw_qcn9274_rx_desc_is_da_mcbc(struct hal_rx_desc *desc) { - return __le16_to_cpu(desc->u.qcn9274.msdu_end.info5) & - RX_MSDU_END_INFO5_DA_IS_MCBC; + return __le32_to_cpu(desc->u.qcn9274.mpdu_start.info6) & + RX_MPDU_START_INFO6_MCAST_BCAST; } static void ath12k_hw_qcn9274_rx_desc_get_dot11_hdr(struct hal_rx_desc *desc, -- 2.43.0