From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <martin.lau@linux.dev>
Cc: <bpf@vger.kernel.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
<netdev@vger.kernel.org>
Subject: Re: BUG? flaky "migrate_reuseport/IPv4 TCP_NEW_SYN_RECV reqsk_timer_handler" test
Date: Fri, 22 Mar 2024 11:08:41 -0700 [thread overview]
Message-ID: <20240322180841.54368-1-kuniyu@amazon.com> (raw)
In-Reply-To: <0edaead1-b20b-4222-9ed5-4347efcebbc2@linux.dev>
Hi Martin,
Thanks for the report.
From: Martin KaFai Lau <martin.lau@linux.dev>
Date: Thu, 21 Mar 2024 18:39:53 -0700
> Hi Kuniyuki,
>
> The bpf CI has recently hit failure in the "migrate_reuseport/IPv4
> TCP_NEW_SYN_RECV" test. It does not always fail but becomes more flaky recently:
> https://github.com/kernel-patches/bpf/actions/runs/8354884067/job/22869153115
>
> It could be due to some slowness in the bpf CI environment but failing because
> of environment slowness is still not expected.
>
> I took a very quick look. It seems like the test depends on the firing of the
> timer's handler "reqsk_timer_handler()", so there is a sleep(1) in the test.
Yes, it depends on the timing of the reqsk tiemr.
> May be the timer fired slower and the test failed? If that is the case, it may
> help to directly trace the reqsk_timer_handler() and wait for enough time to
> ensure it is called.
Sounds good. I'll give it a try.
Thanks!
>
> This test has been temporarily disabled for now
> (https://github.com/kernel-patches/vmtest/blob/master/ci/vmtest/configs/DENYLIST).
> Once you have a fix, we can re-enable it again to ensure this migrate feature
> will not regress.
>
> Thanks,
> Martin
prev parent reply other threads:[~2024-03-22 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 1:39 BUG? flaky "migrate_reuseport/IPv4 TCP_NEW_SYN_RECV reqsk_timer_handler" test Martin KaFai Lau
2024-03-22 1:54 ` Jakub Kicinski
2024-03-22 18:08 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322180841.54368-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=bpf@vger.kernel.org \
--cc=kuni1840@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.