* [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule
@ 2024-03-19 16:51 Tom Rini
2024-03-22 7:13 ` Michal Simek
2024-04-10 17:43 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2024-03-19 16:51 UTC (permalink / raw
To: u-boot
With configs such as "am64x_evm_a53" or "imx8mp_venice" which list
multiple device trees to build we get a warning such as:
scripts/Makefile.spl:578: target 'spl/dts/freescale/' given more than once in the same rule
If we sort this list first the warning goes away.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
scripts/Makefile.spl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index d074ba235006..60db38d5bddd 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -575,7 +575,7 @@ endif
SPL_OF_LIST_TARGETS = $(patsubst %,dts/%.dtb,$(subst ",,$(CONFIG_SPL_OF_LIST)))
SHRUNK_ARCH_DTB = $(addprefix $(obj)/,$(SPL_OF_LIST_TARGETS))
-$(dir $(SHRUNK_ARCH_DTB)):
+$(sort $(dir $(SHRUNK_ARCH_DTB))):
$(shell [ -d $@ ] || mkdir -p $@)
.SECONDEXPANSION:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule
2024-03-19 16:51 [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule Tom Rini
@ 2024-03-22 7:13 ` Michal Simek
2024-04-10 17:43 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2024-03-22 7:13 UTC (permalink / raw
To: Tom Rini; +Cc: u-boot
út 19. 3. 2024 v 17:51 odesílatel Tom Rini <trini@konsulko.com> napsal:
> With configs such as "am64x_evm_a53" or "imx8mp_venice" which list
> multiple device trees to build we get a warning such as:
> scripts/Makefile.spl:578: target 'spl/dts/freescale/' given more than once
> in the same rule
>
> If we sort this list first the warning goes away.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> scripts/Makefile.spl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
> index d074ba235006..60db38d5bddd 100644
> --- a/scripts/Makefile.spl
> +++ b/scripts/Makefile.spl
> @@ -575,7 +575,7 @@ endif
>
> SPL_OF_LIST_TARGETS = $(patsubst %,dts/%.dtb,$(subst
> ",,$(CONFIG_SPL_OF_LIST)))
> SHRUNK_ARCH_DTB = $(addprefix $(obj)/,$(SPL_OF_LIST_TARGETS))
> -$(dir $(SHRUNK_ARCH_DTB)):
> +$(sort $(dir $(SHRUNK_ARCH_DTB))):
> $(shell [ -d $@ ] || mkdir -p $@)
>
> .SECONDEXPANSION:
> --
> 2.34.1
>
>
The same issue also for zynqmp.
Tested-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule
2024-03-19 16:51 [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule Tom Rini
2024-03-22 7:13 ` Michal Simek
@ 2024-04-10 17:43 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2024-04-10 17:43 UTC (permalink / raw
To: u-boot, Tom Rini
On Tue, 19 Mar 2024 12:51:31 -0400, Tom Rini wrote:
> With configs such as "am64x_evm_a53" or "imx8mp_venice" which list
> multiple device trees to build we get a warning such as:
> scripts/Makefile.spl:578: target 'spl/dts/freescale/' given more than once in the same rule
>
> If we sort this list first the warning goes away.
>
>
> [...]
Applied to u-boot/master, thanks!
--
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-10 17:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 16:51 [PATCH] scripts/Makefile.spl: Use 'sort' in SHRUNK_ARCH_DTB rule Tom Rini
2024-03-22 7:13 ` Michal Simek
2024-04-10 17:43 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.