From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mikhail Rudenko <mike.rudenko@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v3 09/20] media: i2c: ov4689: Use runtime PM autosuspend
Date: Mon, 4 Mar 2024 22:45:10 +0200 [thread overview]
Message-ID: <20240304204510.GD9233@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240229165333.227484-10-mike.rudenko@gmail.com>
Hi Mikhail,
Thank you for the patch.
On Thu, Feb 29, 2024 at 07:53:22PM +0300, Mikhail Rudenko wrote:
> Use runtime PM autosuspend to avoid powering off the sensor during
> fast stop-reconfigure-restart cycles.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/ov4689.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index 0e0e694510aa..2354397ab34c 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -426,7 +426,8 @@ static int ov4689_s_stream(struct v4l2_subdev *sd, int on)
> } else {
> cci_write(ov4689->regmap, OV4689_REG_CTRL_MODE,
> OV4689_MODE_SW_STANDBY, NULL);
> - pm_runtime_put(dev);
> + pm_runtime_mark_last_busy(dev);
> + pm_runtime_put_autosuspend(dev);
> }
>
> unlock_and_return:
> @@ -606,7 +607,8 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
> break;
> }
>
> - pm_runtime_put(dev);
> + pm_runtime_mark_last_busy(dev);
> + pm_runtime_put_autosuspend(dev);
>
> return ret;
> }
> @@ -876,8 +878,10 @@ static int ov4689_probe(struct i2c_client *client)
> }
>
> pm_runtime_set_active(dev);
> + pm_runtime_get_noresume(dev);
> pm_runtime_enable(dev);
> - pm_runtime_idle(dev);
> + pm_runtime_set_autosuspend_delay(dev, 1000);
> + pm_runtime_use_autosuspend(dev);
>
> ret = v4l2_async_register_subdev_sensor(sd);
> if (ret) {
> @@ -885,11 +889,14 @@ static int ov4689_probe(struct i2c_client *client)
> goto err_clean_subdev_pm;
> }
>
> + pm_runtime_mark_last_busy(dev);
> + pm_runtime_put_autosuspend(dev);
> +
> return 0;
>
> err_clean_subdev_pm:
> pm_runtime_disable(dev);
> - pm_runtime_set_suspended(dev);
> + pm_runtime_put_noidle(dev);
> v4l2_subdev_cleanup(sd);
> err_clean_entity:
> media_entity_cleanup(&sd->entity);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-03-04 20:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:53 [PATCH v3 00/20] Omnivision OV4689 refactoring and improvements Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 01/20] media: i2c: ov4689: Clean up and annotate the register table Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 02/20] media: i2c: ov4689: Sort register definitions by address Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 03/20] media: i2c: ov4689: Fix typo in a comment Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 04/20] media: i2c: ov4689: CCI conversion Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 05/20] media: i2c: ov4689: Remove i2c_client from ov4689 struct Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 06/20] media: i2c: ov4689: Refactor ov4689_set_ctrl Mikhail Rudenko
2024-03-04 16:49 ` Kieran Bingham
2024-03-04 20:17 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 07/20] media: i2c: ov4689: Use sub-device active state Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 08/20] media: i2c: ov4689: Enable runtime PM before registering sub-device Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 09/20] media: i2c: ov4689: Use runtime PM autosuspend Mikhail Rudenko
2024-03-04 20:45 ` Laurent Pinchart [this message]
2024-02-29 16:53 ` [PATCH v3 10/20] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 11/20] media: i2c: ov4689: Make horizontal blanking configurable Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 12/20] media: i2c: ov4689: Implement vflip/hflip controls Mikhail Rudenko
2024-03-04 16:54 ` Kieran Bingham
2024-03-04 20:19 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 13/20] media: i2c: ov4689: Implement digital gain control Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 14/20] media: i2c: ov4689: Implement manual color balance controls Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 15/20] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode Mikhail Rudenko
2024-03-04 17:01 ` Kieran Bingham
2024-02-29 16:53 ` [PATCH v3 16/20] media: i2c: ov4689: Set timing registers programmatically Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 17/20] media: i2c: ov4689: Configurable analogue crop Mikhail Rudenko
2024-03-05 14:27 ` Kieran Bingham
2024-03-05 14:35 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 18/20] media: i2c: ov4689: Eliminate struct ov4689_mode Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 19/20] media: i2c: ov4689: Refactor ov4689_s_stream Mikhail Rudenko
2024-03-04 21:31 ` Laurent Pinchart
2024-03-04 21:48 ` Mikhail Rudenko
2024-02-29 16:53 ` [PATCH v3 20/20] media: i2c: ov4689: Implement 2x2 binning Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304204510.GD9233@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.