* [PATCH] insane: Clarify runtime/ warning
@ 2024-02-10 7:45 Richard Purdie
2024-02-10 8:15 ` [OE-core] " Peter Kjellerstedt
0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2024-02-10 7:45 UTC (permalink / raw
To: openembedded-core
We should be pointing people at VIRTUAL-RUNTIME, not virtual so tweak
the warning. Try and make it clear the difference between the build
dependencies and the runtime ones.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/classes-global/insane.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 828f618cda1..fa950652921 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1611,7 +1611,7 @@ python () {
for k in ['RDEPENDS', 'RPROVIDES']:
for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
if var.startswith("virtual/"):
- bb.warn("%s is set to %s, the substring 'virtual/' holds no meaning in this context. It is suggested to use the 'virtual-' instead." % (k, var))
+ bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use the 'VIRTUAL-RUNTIME_' instead." % (k, var))
issues = []
if (d.getVar('PACKAGES') or "").split():
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [OE-core] [PATCH] insane: Clarify runtime/ warning
2024-02-10 7:45 [PATCH] insane: Clarify runtime/ warning Richard Purdie
@ 2024-02-10 8:15 ` Peter Kjellerstedt
0 siblings, 0 replies; 2+ messages in thread
From: Peter Kjellerstedt @ 2024-02-10 8:15 UTC (permalink / raw
To: Richard Purdie, openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 10 februari 2024 08:46
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] insane: Clarify runtime/ warning
>
> We should be pointing people at VIRTUAL-RUNTIME, not virtual so tweak
> the warning. Try and make it clear the difference between the build
> dependencies and the runtime ones.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/classes-global/insane.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
> index 828f618cda1..fa950652921 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -1611,7 +1611,7 @@ python () {
> for k in ['RDEPENDS', 'RPROVIDES']:
> for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
> if var.startswith("virtual/"):
> - bb.warn("%s is set to %s, the substring 'virtual/' holds no meaning in this context. It is suggested to use the 'virtual-' instead." % (k, var))
> + bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use the 'VIRTUAL- RUNTIME_' instead." % (k, var))
I suggest changing "the 'VIRTUAL-RUNTIME_'" to "a 'VIRTUAL-RUNTIME_' variable":
bb.warn("%s is set to %s but the substring 'virtual/' holds no meaning in this context. It only works for build time dependencies, not runtime ones. It is suggested to use a 'VIRTUAL-RUNTIME_' variable instead." % (k, var))
>
> issues = []
> if (d.getVar('PACKAGES') or "").split():
> --
> 2.40.1
//Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-10 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-10 7:45 [PATCH] insane: Clarify runtime/ warning Richard Purdie
2024-02-10 8:15 ` [OE-core] " Peter Kjellerstedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.