* [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
@ 2024-01-24 9:36 ` Kunwu Chan
0 siblings, 0 replies; 7+ messages in thread
From: Kunwu Chan @ 2024-01-24 9:36 UTC (permalink / raw
To: mpe, npiggin, christophe.leroy, aneesh.kumar, naveen.n.rao
Cc: Kunwu Chan, linuxppc-dev, linux-kernel, kvm
This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
in about 14 years before.
If there are no plans to enable this part code in the future,
we can remove this dead code.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
arch/powerpc/kvm/book3s.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
index 8acec144120e..c2f50e04eec8 100644
--- a/arch/powerpc/kvm/book3s.c
+++ b/arch/powerpc/kvm/book3s.c
@@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
break;
}
-#if 0
- printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
-#endif
if (deliver)
kvmppc_inject_interrupt(vcpu, vec, 0);
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
@ 2024-01-24 9:36 ` Kunwu Chan
0 siblings, 0 replies; 7+ messages in thread
From: Kunwu Chan @ 2024-01-24 9:36 UTC (permalink / raw
To: mpe, npiggin, christophe.leroy, aneesh.kumar, naveen.n.rao
Cc: linuxppc-dev, kvm, linux-kernel, Kunwu Chan
This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
in about 14 years before.
If there are no plans to enable this part code in the future,
we can remove this dead code.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
arch/powerpc/kvm/book3s.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
index 8acec144120e..c2f50e04eec8 100644
--- a/arch/powerpc/kvm/book3s.c
+++ b/arch/powerpc/kvm/book3s.c
@@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
break;
}
-#if 0
- printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
-#endif
if (deliver)
kvmppc_inject_interrupt(vcpu, vec, 0);
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
2024-01-24 9:36 ` Kunwu Chan
@ 2024-01-24 13:01 ` Christophe Leroy
-1 siblings, 0 replies; 7+ messages in thread
From: Christophe Leroy @ 2024-01-24 13:01 UTC (permalink / raw
To: Kunwu Chan, mpe@ellerman.id.au, npiggin@gmail.com,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
> in about 14 years before.
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
> arch/powerpc/kvm/book3s.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 8acec144120e..c2f50e04eec8 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
> break;
> }
>
> -#if 0
> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
> -#endif
Please also remove one of the two blank lines.
>
> if (deliver)
> kvmppc_inject_interrupt(vcpu, vec, 0);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
@ 2024-01-24 13:01 ` Christophe Leroy
0 siblings, 0 replies; 7+ messages in thread
From: Christophe Leroy @ 2024-01-24 13:01 UTC (permalink / raw
To: Kunwu Chan, mpe@ellerman.id.au, npiggin@gmail.com,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
> in about 14 years before.
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
> arch/powerpc/kvm/book3s.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 8acec144120e..c2f50e04eec8 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
> break;
> }
>
> -#if 0
> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
> -#endif
Please also remove one of the two blank lines.
>
> if (deliver)
> kvmppc_inject_interrupt(vcpu, vec, 0);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
2024-01-24 9:36 ` Kunwu Chan
(?)
(?)
@ 2024-01-24 17:04 ` Markus Elfring
-1 siblings, 0 replies; 7+ messages in thread
From: Markus Elfring @ 2024-01-24 17:04 UTC (permalink / raw
To: Kunwu Chan, kvm, linuxppc-dev, kernel-janitors, Aneesh Kumar K.V,
Christophe Leroy, Naveen N. Rao, Nicholas Piggin,
Michael Ellerman
Cc: LKML
> If there are no plans to enable this part code in the future,
Will the word combination “code part” become preferred for
a subsequent change description?
> we can remove this dead code.
And omit another blank line accordingly?
Regards,
Markus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
2024-01-24 13:01 ` Christophe Leroy
@ 2024-01-25 8:36 ` Kunwu Chan
-1 siblings, 0 replies; 7+ messages in thread
From: Kunwu Chan @ 2024-01-25 8:36 UTC (permalink / raw
To: Christophe Leroy, mpe@ellerman.id.au, npiggin@gmail.com,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
On 2024/1/24 21:01, Christophe Leroy wrote:
>
>
> Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
>> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
>> in about 14 years before.
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>> arch/powerpc/kvm/book3s.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
>> index 8acec144120e..c2f50e04eec8 100644
>> --- a/arch/powerpc/kvm/book3s.c
>> +++ b/arch/powerpc/kvm/book3s.c
>> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
>> break;
>> }
>>
>> -#if 0
>> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
>> -#endif
>
> Please also remove one of the two blank lines.
Thanks for your reply. I've send the v2 patch:
https://lore.kernel.org/all/20240125082637.532826-1-chentao@kylinos.cn/
https://lore.kernel.org/all/20240125083348.533883-1-chentao@kylinos.cn/
>>
>> if (deliver)
>> kvmppc_inject_interrupt(vcpu, vec, 0);
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver
@ 2024-01-25 8:36 ` Kunwu Chan
0 siblings, 0 replies; 7+ messages in thread
From: Kunwu Chan @ 2024-01-25 8:36 UTC (permalink / raw
To: Christophe Leroy, mpe@ellerman.id.au, npiggin@gmail.com,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
On 2024/1/24 21:01, Christophe Leroy wrote:
>
>
> Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
>> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
>> in about 14 years before.
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>> arch/powerpc/kvm/book3s.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
>> index 8acec144120e..c2f50e04eec8 100644
>> --- a/arch/powerpc/kvm/book3s.c
>> +++ b/arch/powerpc/kvm/book3s.c
>> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
>> break;
>> }
>>
>> -#if 0
>> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
>> -#endif
>
> Please also remove one of the two blank lines.
Thanks for your reply. I've send the v2 patch:
https://lore.kernel.org/all/20240125082637.532826-1-chentao@kylinos.cn/
https://lore.kernel.org/all/20240125083348.533883-1-chentao@kylinos.cn/
>>
>> if (deliver)
>> kvmppc_inject_interrupt(vcpu, vec, 0);
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-25 8:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 9:36 [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver Kunwu Chan
2024-01-24 9:36 ` Kunwu Chan
2024-01-24 13:01 ` Christophe Leroy
2024-01-24 13:01 ` Christophe Leroy
2024-01-25 8:36 ` Kunwu Chan
2024-01-25 8:36 ` Kunwu Chan
2024-01-24 17:04 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.