From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cmaiolino@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology
Date: Wed, 17 Jan 2024 15:57:47 -0800 [thread overview]
Message-ID: <20240117235747.GB674499@frogsfrogsfrogs> (raw)
In-Reply-To: <20240117173312.868103-4-hch@lst.de>
On Wed, Jan 17, 2024 at 06:33:10PM +0100, Christoph Hellwig wrote:
> The only caller already performs the exact same check.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Makes sense now,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> libxfs/topology.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/libxfs/topology.c b/libxfs/topology.c
> index 8ae5f7483..3a659c262 100644
> --- a/libxfs/topology.c
> +++ b/libxfs/topology.c
> @@ -181,15 +181,6 @@ blkid_get_topology(
> {
> blkid_topology tp;
> blkid_probe pr;
> - struct stat statbuf;
> -
> - /* can't get topology info from a file */
> - if (!stat(device, &statbuf) && S_ISREG(statbuf.st_mode)) {
> - fprintf(stderr,
> - _("%s: Warning: trying to probe topology of a file %s!\n"),
> - progname, device);
> - return;
> - }
>
> pr = blkid_new_probe_from_filename(device);
> if (!pr)
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2024-01-17 23:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:33 fix log sector size detection v2 Christoph Hellwig
2024-01-17 17:33 ` [PATCH 1/5] libxfs: remove the unused fs_topology_t typedef Christoph Hellwig
2024-01-17 17:33 ` [PATCH 2/5] libxfs: refactor the fs_topology structure Christoph Hellwig
2024-01-17 23:55 ` Darrick J. Wong
2024-01-17 17:33 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Christoph Hellwig
2024-01-17 23:57 ` Darrick J. Wong [this message]
2024-01-17 17:33 ` [PATCH 4/5] libxfs: also query log device topology in get_topology Christoph Hellwig
2024-01-17 17:33 ` [PATCH 5/5] mkfs: use a sensible log sector size default Christoph Hellwig
2024-01-29 9:25 ` Pankaj Raghav (Samsung)
2024-01-17 21:14 ` fix log sector size detection v2 Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2024-03-13 1:48 [PATCHSET V2 05/10] xfsprogs: fix log sector size detection Darrick J. Wong
2024-03-13 2:12 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Darrick J. Wong
2024-03-13 21:40 fix log sector size detection v3 Christoph Hellwig
2024-03-13 21:40 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Christoph Hellwig
2024-03-26 2:56 [PATCHSET V2 05/18] xfsprogs: fix log sector size detection Darrick J. Wong
2024-03-26 3:22 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Darrick J. Wong
2024-04-17 21:17 [PATCHSET V3 07/11] xfsprogs: fix log sector size detection Darrick J. Wong
2024-04-17 21:41 ` [PATCH 3/5] libxfs: remove the S_ISREG check from blkid_get_topology Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117235747.GB674499@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.