* [LTP] [PATCH v1] Add more check points for Review Checklist doc
@ 2023-12-30 8:26 Wei Gao via ltp
2024-01-23 14:04 ` [LTP] [PATCH v2] " Wei Gao via ltp
0 siblings, 1 reply; 3+ messages in thread
From: Wei Gao via ltp @ 2023-12-30 8:26 UTC (permalink / raw
To: ltp
Signed-off-by: Wei Gao <wegao@suse.com>
---
doc/Maintainer-Patch-Review-Checklist.asciidoc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/Maintainer-Patch-Review-Checklist.asciidoc b/doc/Maintainer-Patch-Review-Checklist.asciidoc
index 452de0d49..8bc3468a0 100644
--- a/doc/Maintainer-Patch-Review-Checklist.asciidoc
+++ b/doc/Maintainer-Patch-Review-Checklist.asciidoc
@@ -22,6 +22,7 @@ The following are examples and may not be appropriate for all tests.
- Use sanitizers e.g. undefined behaviour, address.
- Compile on non-x86
- Compile on x86 with -m32
+ - Test patches on GitHub Actions will covers various architectures
* Use `make check`
* Run effected tests in a VM
- Use single vCPU
@@ -30,10 +31,11 @@ The following are examples and may not be appropriate for all tests.
* Run effected tests on an embedded device
* Run effected tests on non-x86 machine in general
* Run reproducers on a kernel where the bug is present
-* Run tests with "-i0"
+* Run tests with "-i0" and "-in"
* Compare usage of system calls with man page descriptions
-* Compare usage of system calls with kernel code
+* Compare usage of system calls with kernel code or commit message
* Search the LTP library for existing helper functions
+* Check doc formatting e.g. cd metadata && make && chromium ../docparse/*.html
## How to find subtle errors
--
2.35.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH v2] Add more check points for Review Checklist doc
2023-12-30 8:26 [LTP] [PATCH v1] Add more check points for Review Checklist doc Wei Gao via ltp
@ 2024-01-23 14:04 ` Wei Gao via ltp
2024-03-19 12:35 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Wei Gao via ltp @ 2024-01-23 14:04 UTC (permalink / raw
To: ltp
Signed-off-by: Wei Gao <wegao@suse.com>
---
doc/Maintainer-Patch-Review-Checklist.asciidoc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/Maintainer-Patch-Review-Checklist.asciidoc b/doc/Maintainer-Patch-Review-Checklist.asciidoc
index 452de0d49..e5dd624b1 100644
--- a/doc/Maintainer-Patch-Review-Checklist.asciidoc
+++ b/doc/Maintainer-Patch-Review-Checklist.asciidoc
@@ -22,6 +22,7 @@ The following are examples and may not be appropriate for all tests.
- Use sanitizers e.g. undefined behaviour, address.
- Compile on non-x86
- Compile on x86 with -m32
+ - Test patches on GitHub Actions will covers various architectures
* Use `make check`
* Run effected tests in a VM
- Use single vCPU
@@ -30,10 +31,12 @@ The following are examples and may not be appropriate for all tests.
* Run effected tests on an embedded device
* Run effected tests on non-x86 machine in general
* Run reproducers on a kernel where the bug is present
-* Run tests with "-i0"
+* Run tests with "-i0" and "-in"
* Compare usage of system calls with man page descriptions
-* Compare usage of system calls with kernel code
+* Compare usage of system calls with kernel code or commit message
* Search the LTP library for existing helper functions
+* Check doc formatting e.g. cd metadata && make && chromium ../docparse/*.html
+* Preview in your fork when change doc such as C-Test-API.asciidoc
## How to find subtle errors
--
2.35.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v2] Add more check points for Review Checklist doc
2024-01-23 14:04 ` [LTP] [PATCH v2] " Wei Gao via ltp
@ 2024-03-19 12:35 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2024-03-19 12:35 UTC (permalink / raw
To: Wei Gao; +Cc: ltp
Hi!
I've adjusted the wording here and there and pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-19 12:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-30 8:26 [LTP] [PATCH v1] Add more check points for Review Checklist doc Wei Gao via ltp
2024-01-23 14:04 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-03-19 12:35 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.