* [PATCH] genirq: Fix irqs_unhandled in note_interrupt
@ 2023-11-28 2:10 Angus Chen
2024-02-19 15:03 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Angus Chen @ 2023-11-28 2:10 UTC (permalink / raw
To: tglx; +Cc: linux-kernel, Angus Chen
Commit 4f27c00bf80f ("Improve behaviour of spurious IRQ detect")
introduced a age of last_unhandled,after irq_count reached 100000,
we set irqs_unhandled = 0,but we didn't clear last_unhandled.
So we can see the print of irq_spurious_proc_show is not consistent.
Like below:
root@jmkernel:~# cat /proc/irq/138/spurious
count 99998
unhandled 1
last_unhandled 1543930240 ms
root@jmkernel:~# cat /proc/irq/138/spurious
count 0
unhandled 0
last_unhandled 1548915240 ms
we can set last_unhandled=1 as a prompting message.
Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
kernel/irq/spurious.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 02b2daf07441..e883df04bdf1 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -428,7 +428,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
mod_timer(&poll_spurious_irq_timer,
jiffies + POLL_SPURIOUS_IRQ_INTERVAL);
}
- desc->irqs_unhandled = 0;
+ desc->irqs_unhandled = 1;
}
bool noirqdebug __read_mostly;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] genirq: Fix irqs_unhandled in note_interrupt
2023-11-28 2:10 [PATCH] genirq: Fix irqs_unhandled in note_interrupt Angus Chen
@ 2024-02-19 15:03 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2024-02-19 15:03 UTC (permalink / raw
To: Angus Chen; +Cc: linux-kernel, Angus Chen
On Tue, Nov 28 2023 at 10:10, Angus Chen wrote:
> Commit 4f27c00bf80f ("Improve behaviour of spurious IRQ detect")
> introduced a age of last_unhandled,after irq_count reached 100000,
> we set irqs_unhandled = 0,but we didn't clear last_unhandled.
We do nothing. Please write changelogs in passive voice.
> So we can see the print of irq_spurious_proc_show is not consistent.
> Like below:
> root@jmkernel:~# cat /proc/irq/138/spurious
> count 99998
> unhandled 1
> last_unhandled 1543930240 ms
>
> root@jmkernel:~# cat /proc/irq/138/spurious
> count 0
> unhandled 0
> last_unhandled 1548915240 ms
I can't figure out what you are trying to demonstrate here.
> we can set last_unhandled=1 as a prompting message.
This makes no sense either.
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
> kernel/irq/spurious.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> index 02b2daf07441..e883df04bdf1 100644
> --- a/kernel/irq/spurious.c
> +++ b/kernel/irq/spurious.c
> @@ -428,7 +428,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
> mod_timer(&poll_spurious_irq_timer,
> jiffies + POLL_SPURIOUS_IRQ_INTERVAL);
> }
> - desc->irqs_unhandled = 0;
> + desc->irqs_unhandled = 1;
Why? Just to do some incomprehensible /proc/ output cosmetics instead of
fixing the related procfs function?
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-19 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 2:10 [PATCH] genirq: Fix irqs_unhandled in note_interrupt Angus Chen
2024-02-19 15:03 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.