All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] firmware: ti_sci: Fix few compiler warnings
@ 2023-06-21  8:23 ` Dhruva Gole
  0 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2023-06-21  8:23 UTC (permalink / raw
  To: Nishanth Menon
  Cc: Praneeth, Vignesh, Dhruva Gole, Tero Kristo, Santosh Shilimkar,
	linux-arm-kernel, linux-kernel

Fix below warnings:

 CC      drivers/firmware/ti_sci.o
drivers/firmware/ti_sci.c:1988: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_set_irq'
drivers/firmware/ti_sci.c:2036: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_free_irq'
drivers/firmware/ti_sci.c:2632: warning: Function parameter or member
...
drivers/firmware/ti_sci.c:2748: warning: expecting prototype for ti_sci_cmd_get_boot_status(). Prototype was for ti_sci_cmd_proc_get_status() instead
drivers/firmware/ti_sci.c:3267: warning: Function parameter or member 'sub_type' not described in 'devm_ti_sci_get_resource'
drivers/firmware/ti_sci.c:3267: warning: Excess function parameter 'suub_type' description in 'devm_ti_sci_get_resource'

Fixes: 1e407f337f40 ("firmware: ti_sci: Add support for processor control")
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
 drivers/firmware/ti_sci.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 039d92a595ec..eca947bb35b9 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1978,8 +1978,6 @@ static int ti_sci_free_irq(const struct ti_sci_handle *handle, u32 valid_params,
  * @src_index:		IRQ source index within the source device
  * @dst_id:		Device ID of the IRQ destination
  * @dst_host_irq:	IRQ number of the destination device
- * @vint_irq:		Boolean specifying if this interrupt belongs to
- *			Interrupt Aggregator.
  *
  * Return: 0 if all went fine, else return appropriate error.
  */
@@ -2026,8 +2024,6 @@ static int ti_sci_cmd_set_event_map(const struct ti_sci_handle *handle,
  * @src_index:		IRQ source index within the source device
  * @dst_id:		Device ID of the IRQ destination
  * @dst_host_irq:	IRQ number of the destination device
- * @vint_irq:		Boolean specifying if this interrupt belongs to
- *			Interrupt Aggregator.
  *
  * Return: 0 if all went fine, else return appropriate error.
  */
@@ -2736,7 +2732,7 @@ static int ti_sci_cmd_proc_set_control(const struct ti_sci_handle *handle,
 }
 
 /**
- * ti_sci_cmd_get_boot_status() - Command to get the processor boot status
+ * ti_sci_cmd_proc_get_status() - Command to get the processor boot status
  * @handle:	Pointer to TI SCI handle
  * @proc_id:	Processor ID this request is for
  *
@@ -3256,7 +3252,7 @@ EXPORT_SYMBOL_GPL(devm_ti_sci_get_of_resource);
  * @handle:	TISCI handle
  * @dev:	Device pointer to which the resource is assigned
  * @dev_id:	TISCI device id to which the resource is assigned
- * @suub_type:	TISCI resource subytpe representing the resource.
+ * @sub_type:	TISCI resource subytpe representing the resource.
  *
  * Return: Pointer to ti_sci_resource if all went well else appropriate
  *	   error pointer.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] firmware: ti_sci: Fix few compiler warnings
@ 2023-06-21  8:23 ` Dhruva Gole
  0 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2023-06-21  8:23 UTC (permalink / raw
  To: Nishanth Menon
  Cc: Praneeth, Vignesh, Dhruva Gole, Tero Kristo, Santosh Shilimkar,
	linux-arm-kernel, linux-kernel

Fix below warnings:

 CC      drivers/firmware/ti_sci.o
drivers/firmware/ti_sci.c:1988: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_set_irq'
drivers/firmware/ti_sci.c:2036: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_free_irq'
drivers/firmware/ti_sci.c:2632: warning: Function parameter or member
...
drivers/firmware/ti_sci.c:2748: warning: expecting prototype for ti_sci_cmd_get_boot_status(). Prototype was for ti_sci_cmd_proc_get_status() instead
drivers/firmware/ti_sci.c:3267: warning: Function parameter or member 'sub_type' not described in 'devm_ti_sci_get_resource'
drivers/firmware/ti_sci.c:3267: warning: Excess function parameter 'suub_type' description in 'devm_ti_sci_get_resource'

Fixes: 1e407f337f40 ("firmware: ti_sci: Add support for processor control")
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---
 drivers/firmware/ti_sci.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 039d92a595ec..eca947bb35b9 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -1978,8 +1978,6 @@ static int ti_sci_free_irq(const struct ti_sci_handle *handle, u32 valid_params,
  * @src_index:		IRQ source index within the source device
  * @dst_id:		Device ID of the IRQ destination
  * @dst_host_irq:	IRQ number of the destination device
- * @vint_irq:		Boolean specifying if this interrupt belongs to
- *			Interrupt Aggregator.
  *
  * Return: 0 if all went fine, else return appropriate error.
  */
@@ -2026,8 +2024,6 @@ static int ti_sci_cmd_set_event_map(const struct ti_sci_handle *handle,
  * @src_index:		IRQ source index within the source device
  * @dst_id:		Device ID of the IRQ destination
  * @dst_host_irq:	IRQ number of the destination device
- * @vint_irq:		Boolean specifying if this interrupt belongs to
- *			Interrupt Aggregator.
  *
  * Return: 0 if all went fine, else return appropriate error.
  */
@@ -2736,7 +2732,7 @@ static int ti_sci_cmd_proc_set_control(const struct ti_sci_handle *handle,
 }
 
 /**
- * ti_sci_cmd_get_boot_status() - Command to get the processor boot status
+ * ti_sci_cmd_proc_get_status() - Command to get the processor boot status
  * @handle:	Pointer to TI SCI handle
  * @proc_id:	Processor ID this request is for
  *
@@ -3256,7 +3252,7 @@ EXPORT_SYMBOL_GPL(devm_ti_sci_get_of_resource);
  * @handle:	TISCI handle
  * @dev:	Device pointer to which the resource is assigned
  * @dev_id:	TISCI device id to which the resource is assigned
- * @suub_type:	TISCI resource subytpe representing the resource.
+ * @sub_type:	TISCI resource subytpe representing the resource.
  *
  * Return: Pointer to ti_sci_resource if all went well else appropriate
  *	   error pointer.
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] firmware: ti_sci: Fix few compiler warnings
  2023-06-21  8:23 ` Dhruva Gole
@ 2023-06-21  8:34   ` Dhruva Gole
  -1 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2023-06-21  8:34 UTC (permalink / raw
  To: Nishanth Menon
  Cc: Praneeth, Vignesh, Tero Kristo, Santosh Shilimkar,
	linux-arm-kernel, linux-kernel

Oops, seems like I missed similar patch,

On 21/06/23 13:53, Dhruva Gole wrote:
> Fix below warnings:
> 
>   CC      drivers/firmware/ti_sci.o
> drivers/firmware/ti_sci.c:1988: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_set_irq'
> drivers/firmware/ti_sci.c:2036: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_free_irq'
> drivers/firmware/ti_sci.c:2632: warning: Function parameter or member
> ...
> drivers/firmware/ti_sci.c:2748: warning: expecting prototype for ti_sci_cmd_get_boot_status(). Prototype was for ti_sci_cmd_proc_get_status() instead
> drivers/firmware/ti_sci.c:3267: warning: Function parameter or member 'sub_type' not described in 'devm_ti_sci_get_resource'
> drivers/firmware/ti_sci.c:3267: warning: Excess function parameter 'suub_type' description in 'devm_ti_sci_get_resource'
> 
> Fixes: 1e407f337f40 ("firmware: ti_sci: Add support for processor control")
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---

Nishanth already submitted this before I did,

https://lore.kernel.org/all/20230621021619.265162-1-nm@ti.com/

-- 
Thanks and Regards,
Dhruva Gole

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] firmware: ti_sci: Fix few compiler warnings
@ 2023-06-21  8:34   ` Dhruva Gole
  0 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2023-06-21  8:34 UTC (permalink / raw
  To: Nishanth Menon
  Cc: Praneeth, Vignesh, Tero Kristo, Santosh Shilimkar,
	linux-arm-kernel, linux-kernel

Oops, seems like I missed similar patch,

On 21/06/23 13:53, Dhruva Gole wrote:
> Fix below warnings:
> 
>   CC      drivers/firmware/ti_sci.o
> drivers/firmware/ti_sci.c:1988: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_set_irq'
> drivers/firmware/ti_sci.c:2036: warning: Excess function parameter 'vint_irq' description in 'ti_sci_cmd_free_irq'
> drivers/firmware/ti_sci.c:2632: warning: Function parameter or member
> ...
> drivers/firmware/ti_sci.c:2748: warning: expecting prototype for ti_sci_cmd_get_boot_status(). Prototype was for ti_sci_cmd_proc_get_status() instead
> drivers/firmware/ti_sci.c:3267: warning: Function parameter or member 'sub_type' not described in 'devm_ti_sci_get_resource'
> drivers/firmware/ti_sci.c:3267: warning: Excess function parameter 'suub_type' description in 'devm_ti_sci_get_resource'
> 
> Fixes: 1e407f337f40 ("firmware: ti_sci: Add support for processor control")
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---

Nishanth already submitted this before I did,

https://lore.kernel.org/all/20230621021619.265162-1-nm@ti.com/

-- 
Thanks and Regards,
Dhruva Gole

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-21  8:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-21  8:23 [PATCH] firmware: ti_sci: Fix few compiler warnings Dhruva Gole
2023-06-21  8:23 ` Dhruva Gole
2023-06-21  8:34 ` Dhruva Gole
2023-06-21  8:34   ` Dhruva Gole

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.