* [RESEND PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info
@ 2023-05-11 17:54 Krzysztof Kozlowski
2023-05-13 15:06 ` Xu Yilun
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-11 17:54 UTC (permalink / raw)
To: Wu Hao, Tom Rix, Moritz Fischer, Xu Yilun, linux-fpga,
linux-kernel
Cc: Krzysztof Kozlowski, Russ Weight
Statically allocated array of pointers to hwmon_channel_info can be made
const for safety.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/fpga/dfl-fme-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
index 77ea04d4edbe..bcb5d34b3b82 100644
--- a/drivers/fpga/dfl-fme-main.c
+++ b/drivers/fpga/dfl-fme-main.c
@@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = {
.read = thermal_hwmon_read,
};
-static const struct hwmon_channel_info *thermal_hwmon_info[] = {
+static const struct hwmon_channel_info * const thermal_hwmon_info[] = {
HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY |
HWMON_T_MAX | HWMON_T_MAX_ALARM |
HWMON_T_CRIT | HWMON_T_CRIT_ALARM),
@@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = {
.write = power_hwmon_write,
};
-static const struct hwmon_channel_info *power_hwmon_info[] = {
+static const struct hwmon_channel_info * const power_hwmon_info[] = {
HWMON_CHANNEL_INFO(power, HWMON_P_INPUT |
HWMON_P_MAX | HWMON_P_MAX_ALARM |
HWMON_P_CRIT | HWMON_P_CRIT_ALARM),
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info
2023-05-11 17:54 [RESEND PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info Krzysztof Kozlowski
@ 2023-05-13 15:06 ` Xu Yilun
0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2023-05-13 15:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wu Hao, Tom Rix, Moritz Fischer, linux-fpga, linux-kernel,
Russ Weight
On 2023-05-11 at 19:54:49 +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointers to hwmon_channel_info can be made
> const for safety.
>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-13 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-11 17:54 [RESEND PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info Krzysztof Kozlowski
2023-05-13 15:06 ` Xu Yilun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.